----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/#review31563 -----------------------------------------------------------
sorry for the late reply; the people who could review this one were off in the last week at a dev sprint and reviews tend to get neglected when that happens. but better late than never, right? ;) looks pretty good, a few minor issues below, and Marco Martin should also have a glance through it. plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml <http://git.reviewboard.kde.org/r/110122/#comment23501> no minimum is set here as there was in the prior code. there should probably be some sensible minimum applied. plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml <http://git.reviewboard.kde.org/r/110122/#comment23502> this tends to lead to accidental timers running when the code changes later (QML makes it a little too easy to accomplish that at times ;) would prefer that this stays as a single shot and is restarted as needed. - Aaron J. Seigo On April 25, 2013, 1:58 p.m., James Pike wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110122/ > ----------------------------------------------------------- > > (Updated April 25, 2013, 1:58 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Currently the timeout of the last notification to arrive is used as a basis > for hiding the notification display. This means that a notification with a > high timeout can get hidden by a new notification arriving with a much lower > timeout. > > This patch simply changes the behaviour to, when expiring a timer, go back > through the stack and display the most recent unexpired timer. If all timers > are expired the notification is closed as before. > > > This addresses bug 318295. > http://bugs.kde.org/show_bug.cgi?id=318295 > > > Diffs > ----- > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml > 2fa1b11 > > Diff: http://git.reviewboard.kde.org/r/110122/diff/ > > > Testing > ------- > > Test script in https://bugs.kde.org/show_bug.cgi?id=318295 > > > Thanks, > > James Pike > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
