Re: Menu branch

2013-04-20 Thread Eike Hein
Hi again, had a look at the diffs now. Looking good to me from the code side, but a couple of thoughts on the UI: - I think the split is working out as well as we had hoped, but the devil is in the details ... on the dialog page: - The repetition of "Sorting" between the group box title and

Re: Review Request 110065: fix notifcation plasmoid about some undefined data when retreive data from data engine

2013-04-20 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110065/ --- (Updated April 20, 2013, 6:14 p.m.) Review request for Plasma and Marco Ma

Re: Review Request 110029: Fix X pixmap leak in shadow handling code

2013-04-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110029/ --- (Updated April 20, 2013, 1:46 p.m.) Status -- This change has been ma

Re: Review Request 110029: Fix X pixmap leak in shadow handling code

2013-04-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110029/#review31331 --- This review has been submitted with commit b29820e09a0a0e355f6

Re: Review Request 109965: Refactor assetimporters

2013-04-20 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109965/ --- (Updated April 20, 2013, 10:52 a.m.) Review request for Plasma. Changes

Re: Review Request 109965: Refactor assetimporters

2013-04-20 Thread Giorgos Tsiapaliokas
> On April 13, 2013, 2:12 a.m., Aaron J. Seigo wrote: > > looking very good. a few comments below, but this should be ready soon, i > > imagine. Regarding the cache of the partnerId and licenseId, I cache those values in the *init method. I don't follow you in this one. What is the difference

Re: Review Request 110065: fix notifcation plasmoid about some undefined data when retreive data from data engine

2013-04-20 Thread Marco Martin
> On April 18, 2013, 8:17 a.m., Aaron J. Seigo wrote: > > plasma/generic/applets/notifications/contents/ui/JobDelegate.qml, lines > > 33-39 > > > > > > this is likely to break property binding, so if infoMessage c

Re: Menu branch

2013-04-20 Thread Eike Hein
On Friday 19 April 2013 11:32:48 Ignat Semenov wrote: > setLayout() and setAlignment() both trigger a complete relayout of the view. > Relayouting the view twice is suboptimal, however, in the code there is a > 10ms timer to delay the relayout so as not to block the caller. Should that > timer be e