----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110065/ -----------------------------------------------------------
(Updated April 20, 2013, 6:14 p.m.) Review request for Plasma and Marco Martin. Changes ------- great.. we can avoid the (potential) property binding problem by put data as function argument. Description ------- Current notifications will give quite a lot warning, since jobsSource.data[modelData] might be undefined in the first place. And this can also cause label1NameText to be shown as "undefinded: " for a job, this can be reproduced when you do the job of copy a large folder to sftp, the label1 will be undefined when doing the folder creation. Diffs (updated) ----- plasma/generic/applets/notifications/contents/ui/JobDelegate.qml cf60946 Diff: http://git.reviewboard.kde.org/r/110065/diff/ Testing ------- all related warning is now suppressed, and undefined will not be shown in the same case. Thanks, Xuetian Weng
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
