Re: Review Request 109906: Make plasma-desktop and krunner use KDE_VERSION_STRING instead of some never changing version.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109906/ --- (Updated April 9, 2013, 3:01 a.m.) Status -- This change has been mar

Re: Review Request 109906: Make plasma-desktop and krunner use KDE_VERSION_STRING instead of some never changing version.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109906/#review30733 --- This review has been submitted with commit 1379c79d28b13e04bf4

[plasma-framework] src/shell: rename testplasma2 binary to plasma-shell

Git commit ea41410004e9e634e40124b5d4ac690cecb7b99b by Sebastian Kügler. Committed on 09/04/2013 at 03:00. Pushed by sebas into branch 'master'. rename testplasma2 binary to plasma-shell This also means that the config file is now ~/.config5/plasma-shell-appletsrc CCMAIL:plasma-devel@kde.org M

Re: Review Request 106110: Make autohide panel do not intercept events in fullscreen app

> On March 20, 2013, 2 p.m., Aaron J. Seigo wrote: > > plasma/desktop/shell/panelview.cpp, line 1496 > > > > > > Better would simply be to compare screens. If they are on the same > > screen -> don't interfere.

Re: Review Request 109910: bodega-server: Replace github.com with github.io for security reasons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109910/ --- (Updated April 8, 2013, 11:03 p.m.) Status -- This change has been ma

Re: Review Request 109910: bodega-server: Replace github.com with github.io for security reasons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109910/#review30729 --- This review has been submitted with commit 18ff7f20ed36db56c55

Re: [Kde-pim] draft proposal

Hi Heena, On Wednesday, April 03, 2013 21:03:14 Heena Mahour wrote: > Please give suggestion and could you please elaborate which plasmoids(apart > from notes sharing using akonadi) are to be created for this project? Overall, your proposal starts to look pretty good! One thing that struck me is

Re: Review Request 109878: PlasmaClock - fix remaining compilation warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109878/#review30725 --- Ship it! Ship It! - Aaron J. Seigo On April 8, 2013, 3:08 p

Re: Review Request 106118: Plasmate: Add KWin Scripting support to konsolepreviewer.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/#review30724 --- Ship it! Ship It! - Aaron J. Seigo On Feb. 12, 2013, 12:26

Re: Review Request 108992: Simple optimizations in SignalPlotter

> On April 5, 2013, 3:43 p.m., Albert Astals Cid wrote: > > Aaron can you re-review to see if the requests you made are fixed and this > > is ready to go? no, it still needs to be changed to address the points raised - Aaron J. --- Th

Re: Review Request 109857: Add the "theme" directory to the plasmoid directory structure

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109857/#review30722 --- Ship it! Ship It! - Aaron J. Seigo On April 4, 2013, 5:14 p

Re: Review Request 109859: Allow plasmoids to provide fallbacks for themed images

> On April 8, 2013, 8:44 p.m., Aaron J. Seigo wrote: > > this also will need to be documented here: http://techbase.kde.org/Development/Tutorials/Plasma/JavaScript/API-Painting#Svg - Aaron J. --- This is an automatically generated e-ma

Re: Review Request 109859: Allow plasmoids to provide fallbacks for themed images

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109859/#review30720 --- Ship it! - Aaron J. Seigo On April 4, 2013, 5:14 p.m., Alex

Re: Review Request 109906: Make plasma-desktop and krunner use KDE_VERSION_STRING instead of some never changing version.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109906/#review30718 --- Ship it! this is fine for now. however, i find the global re

Re: Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109825/#review30715 --- resources/facebook/facebookresource_notifications.cpp

Re: [Kde-pim] draft proposal

On Monday, 2013-04-08, Heena Mahour wrote: > Hey Kevin :D , > okay ...Between what is to be included in theming/animations? That is outside my expertise, I'll have to refer that to the Plasma people :) Cheers, Kevin > > On Mon, Apr 8, 2013 at 10:35 PM, Kevin Krammer wrote: > > Hi Heena, > > >

Re: Review Request 106110: Make autohide panel do not intercept events in fullscreen app

> On March 20, 2013, 2 p.m., Aaron J. Seigo wrote: > > plasma/desktop/shell/panelview.cpp, line 1496 > > > > > > Better would simply be to compare screens. If they are on the same > > screen -> don't interfere.

Re: [Kde-pim] draft proposal

Hey Kevin :D , okay ...Between what is to be included in theming/animations? On Mon, Apr 8, 2013 at 10:35 PM, Kevin Krammer wrote: > Hi Heena, > > On Monday, 2013-04-08, Heena Mahour wrote: > > Hi Kevin, > > Focussing on the implementation plan ,it will include :- > > 1.) provide Plasma user in

Re: [Kde-pim] draft proposal

Hi Heena, On Monday, 2013-04-08, Heena Mahour wrote: > Hi Kevin, > Focussing on the implementation plan ,it will include :- > 1.) provide Plasma user interfaces for at least current state of mail > account backend (Akonadi resources) > 2.) UI for common actions (1) and (2) are actually details of

Re: Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109825/#review30707 --- resources/facebook/facebookresource_notifications.cpp

Re: [Kde-pim] draft proposal

Hi Kevin, Focussing on the implementation plan ,it will include :- 1.) provide Plasma user interfaces for at least current state of mail account backend (Akonadi resources) 2.) UI for common actions 3.)notes applet 4.) monitoring, control and management of the various background processes which are

Re: Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109825/#review30706 --- Bah, reviewboard lost my update comment. The latest patch fixes

Re: Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109825/ --- (Updated April 8, 2013, 4:55 p.m.) Review request for KDEPIM and Plasma.

Re: Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifications

> On April 5, 2013, 4:48 p.m., Kevin Krammer wrote: > > resources/facebook/facebookresource_notifications.cpp, line 291 > > > > > > is this something you haven't gotten around to do yet or something you > > are n

Re: Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifications

> On April 5, 2013, 4:48 p.m., Kevin Krammer wrote: > > resources/facebook/facebookresource_notifications.cpp, line 291 > > > > > > is this something you haven't gotten around to do yet or something you > > are n

Re: Review Request 109910: bodega-server: Replace github.com with github.io for security reasons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109910/#review30697 --- Ship it! Ship It! - Aaron J. Seigo On April 8, 2013, 12:17

Re: Review Request 109821: make the DvcsJob async

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109821/#review30695 --- Ship it! the only possible downside i can see at the moment is

Re: Review Request 109793: Check network connection before starting youtube and mediawiki runners

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109793/ --- (Updated April 8, 2013, 3:43 p.m.) Status -- This change has been mar

Re: Review Request 109793: Check network connection before starting youtube and mediawiki runners

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109793/#review30692 --- This review has been submitted with commit cff026f4d746dff9dbc

Re: Review Request 109780: Enable following links/urls from the plasma notifications popup applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109780/#review30691 --- Ship it! Ship It! - Aaron J. Seigo On March 28, 2013, 8:20

Re: Review Request 109773: New runner that translates words and sentences via Google Translate.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109773/#review30684 --- runners/translator/translator.cpp

Re: Review Request 109878: PlasmaClock - fix remaining compilation warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109878/ --- (Updated April 8, 2013, 3:08 p.m.) Review request for Plasma and Aaron J.

Re: Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifications

> On April 5, 2013, 4:48 p.m., Kevin Krammer wrote: > > resources/facebook/facebookresource_notifications.cpp, line 215 > > > > > > Actually it might even be possible to access the KComponentData object > > of th

Re: Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifications

> On April 5, 2013, 4:48 p.m., Kevin Krammer wrote: > > resources/facebook/facebookresource_notifications.cpp, line 215 > > > > > > Actually it might even be possible to access the KComponentData object > > of th

Re: Review Request 109861: PlasmaClock - show General configuration page only if kttsd is available

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109861/ --- (Updated April 8, 2013, 2:22 p.m.) Status -- This change has been mar

Re: Review Request 109861: PlasmaClock - show General configuration page only if kttsd is available

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109861/#review30677 --- This review has been submitted with commit 29587d50c4b4bece952

Re: Review Request 109878: PlasmaClock - fix remaining compilation warnings

> On April 8, 2013, 1:59 p.m., Aaron J. Seigo wrote: > > libs/plasmaclock/calendartable.cpp, line 888 > > > > > > does passing in QVariant() alone not work? would remove the need for > > the "old" magic string in

Re: Review Request 109878: PlasmaClock - fix remaining compilation warnings

> On April 8, 2013, 1:59 p.m., Aaron J. Seigo wrote: > > libs/plasmaclock/calendartable.cpp, line 888 > > > > > > does passing in QVariant() alone not work? would remove the need for > > the "old" magic string in

Re: Review Request 106110: Make autohide panel do not intercept events in fullscreen app

> On March 20, 2013, 2 p.m., Aaron J. Seigo wrote: > > plasma/desktop/shell/panelview.cpp, line 1496 > > > > > > Better would simply be to compare screens. If they are on the same > > screen -> don't interfere.

Re: Review Request 109878: PlasmaClock - fix remaining compilation warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109878/#review30670 --- libs/plasmaclock/calendartable.cpp

Re: Review Request 109861: PlasmaClock - show General configuration page only if kttsd is available

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109861/#review30669 --- Ship it! Ship It! - Aaron J. Seigo On April 5, 2013, 4:42 p

Re: Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifications

> On April 5, 2013, 4:48 p.m., Kevin Krammer wrote: > > resources/facebook/facebookresource_notifications.cpp, line 215 > > > > > > Actually it might even be possible to access the KComponentData object > > of th

Re: Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifications

> On April 5, 2013, 4:48 p.m., Kevin Krammer wrote: > > resources/facebook/facebookresource_notifications.cpp, line 215 > > > > > > Actually it might even be possible to access the KComponentData object > > of th

Re: Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifications

> On April 5, 2013, 4:48 p.m., Kevin Krammer wrote: > > resources/facebook/facebookresource_notifications.cpp, line 215 > > > > > > Actually it might even be possible to access the KComponentData object > > of th

Review Request 109910: bodega-server: Replace github.com with github.io for security reasons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109910/ --- Review request for Plasma. Description --- 1) the github.com urls no

Re: Review Request 109793: Check network connection before starting youtube and mediawiki runners

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109793/#review30663 --- Ship it! Patch is fine as is, Solid is already used there, so

Re: Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifications

> On April 5, 2013, 4:48 p.m., Kevin Krammer wrote: > > resources/facebook/facebookresource_notifications.cpp, line 231 > > > > > > while you have a point that the case of n == 1 is already covered, my > > still

activities_optional branch in kde-workspace

hi.. i noticed a new branch when i pulled kde-workspace today (finally!): activities_optional the lone commit in it was pushed on april 1, so maybe it's an april fools joke, but if it isn't, it looks like someone is trying to do something that makes no sense (and has no chance of being merged

Re: Review Request 109604: Model to provide easy access to KWin's Clients from QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109604/ --- (Updated April 8, 2013, 8:31 a.m.) Status -- This change has been mar

Re: Review Request 109604: Model to provide easy access to KWin's Clients from QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109604/#review30652 --- This review has been submitted with commit c4c32f76340c2724072

Review Request 109906: Make plasma-desktop and krunner use KDE_VERSION_STRING instead of some never changing version.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109906/ --- Review request for Plasma and Aaron J. Seigo. Description --- What th