> On March 20, 2013, 2 p.m., Aaron J. Seigo wrote: > > plasma/desktop/shell/panelview.cpp, line 1496 > > <http://git.reviewboard.kde.org/r/106110/diff/5/?file=120303#file120303line1496> > > > > Better would simply be to compare screens. If they are on the same > > screen -> don't interfere. > > Thomas Lübking wrote: > a fullscreen window can cover more than one screen (@Martin: there's even > a netwm hint on that for xinerama ;-) > What you wanted to check is whether the panel and the window intersect. > > Aaron J. Seigo wrote: > which would require calculating the geometry when the panel is unhidden. > it is easier to ask "is this window full screen and does it show on the same > screen as this panel". it has nothing to do with "does a window only cover > one screen" and can be done sth like: > activeWindow.geometry().intersects(QApplication::desktop()->screenGeometry(screen())); > > Thomas Lübking wrote: > > it is easier to ask "is this window full screen and does it show on the > same screen as this panel" > Can panels only be on one screen? > If not, this gonna fail if your panel spans completely across both > screens and the FS is on the smaller one (depending on how you calculate > screen())
"Can panels only be on one screen?" yes, because anything else is insane. "Look, Ma, my panel done jump up about 3 inches from this monitor to that one .. and when i unplug that monitor the panel does jump all around and don't fit proper like no more" been there, done that with kicker, won't do it again :) - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106110/#review29551 ----------------------------------------------------------- On March 22, 2013, 4:53 p.m., Alexey Shmalko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106110/ > ----------------------------------------------------------- > > (Updated March 22, 2013, 4:53 p.m.) > > > Review request for kwin and Plasma. > > > Description > ------- > > Make autohide panel do not intercept events in fullscreen app. > > I changed PanelView::createUnhideTrigger() to check whether current active > application is in fullscreen mode. So in fullscreen applications panel will > be always hidden. > > > This addresses bug 217560. > http://bugs.kde.org/show_bug.cgi?id=217560 > > > Diffs > ----- > > plasma/desktop/shell/panelview.cpp 7713740 > > Diff: http://git.reviewboard.kde.org/r/106110/diff/ > > > Testing > ------- > > Tested with patched gentoo ebuild. Works fine. > > > Thanks, > > Alexey Shmalko > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
