Re: Plasma mediacenter rss plugin

2013-04-05 Thread Gregor Tätzner
On Friday 05 April 2013 23:49:45 Shantanu Tushar Jha wrote: > Well right now the panel implementation is a vertical bar at the left. We > are planning to change the panel concept to a overlay which comes over the > browser. This is better because it eases navigation and gives more room to > backend

Re: Review Request 108798: Fix most of the compile issues due to wrong header used and comment out in shell/CMakeLists.txt testapplet which doesn't exist

2013-04-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108798/#review30513 --- The patch doesn't apply anymore, please update it and don't for

Re: Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons

2013-04-05 Thread Marco Martin
> On April 5, 2013, 4:16 p.m., Albert Astals Cid wrote: > > Can you please attach the diff properly and not give ship its to yourself? > > > > I'd suggest you discard this review that is already broken and start a new > > one where you attach the diff properly and you don't give you a ship it t

Re: Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons

2013-04-05 Thread Leszek Lesner
> On April 5, 2013, 4:16 p.m., Albert Astals Cid wrote: > > Can you please attach the diff properly and not give ship its to yourself? > > > > I'd suggest you discard this review that is already broken and start a new > > one where you attach the diff properly and you don't give you a ship it t

Re: Review Request 108458: Fix webslice's handling of page resizes

2013-04-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108458/ --- (Updated April 5, 2013, 6:39 p.m.) Status -- This change has been mar

Re: Review Request 108458: Fix webslice's handling of page resizes

2013-04-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108458/#review30502 --- This review has been submitted with commit 919370eba3978f641b8

Review Request 109878: PlasmaClock - fix remaining compilation warnings

2013-04-05 Thread Michał Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109878/ --- Review request for Plasma and Aaron J. Seigo. Description --- Fix rem

Re: Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons

2013-04-05 Thread Albert Astals Cid
> On April 5, 2013, 4:16 p.m., Albert Astals Cid wrote: > > Can you please attach the diff properly and not give ship its to yourself? > > > > I'd suggest you discard this review that is already broken and start a new > > one where you attach the diff properly and you don't give you a ship it t

Re: Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons

2013-04-05 Thread Leszek Lesner
> On April 5, 2013, 4:16 p.m., Albert Astals Cid wrote: > > Can you please attach the diff properly and not give ship its to yourself? > > > > I'd suggest you discard this review that is already broken and start a new > > one where you attach the diff properly and you don't give you a ship it t

Re: Plasma mediacenter rss plugin

2013-04-05 Thread Shantanu Tushar Jha
Well right now the panel implementation is a vertical bar at the left. We are planning to change the panel concept to a overlay which comes over the browser. This is better because it eases navigation and gives more room to backends to put stuff. How does that sound to you? On Fri, Apr 5, 2013 at

outreach program for women (qmlify plasmoids)

2013-04-05 Thread Heena Mahour
Hi , Actually I have applied for outreach program for women under the project - qmlify plasmoids (kde) .I would like to get some suggestions and other interesting ideas for this program (Mentors are welcome :-D ) Regards -- -Heena Delhi College of Engineering(COE),India http://about.me/heena.mah

Re: Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons

2013-04-05 Thread Albert Astals Cid
> On April 5, 2013, 4:16 p.m., Albert Astals Cid wrote: > > Can you please attach the diff properly and not give ship its to yourself? > > > > I'd suggest you discard this review that is already broken and start a new > > one where you attach the diff properly and you don't give you a ship it t

Re: Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifications

2013-04-05 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109825/#review30479 --- resources/facebook/facebookresource_notifications.cpp

Re: Review Request 109861: PlasmaClock - show General configuration page only if kttsd is available

2013-04-05 Thread Michał Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109861/ --- (Updated April 5, 2013, 4:42 p.m.) Review request for Plasma and Aaron J.

Re: Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons

2013-04-05 Thread Leszek Lesner
> On April 5, 2013, 4:16 p.m., Albert Astals Cid wrote: > > Can you please attach the diff properly and not give ship its to yourself? > > > > I'd suggest you discard this review that is already broken and start a new > > one where you attach the diff properly and you don't give you a ship it t

Re: Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons

2013-04-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108325/#review30476 --- Can you please attach the diff properly and not give ship its t

Re: Review Request 108241: use Plasma::Dialog for icontasks tooltips

2013-04-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108241/ --- (Updated April 5, 2013, 4:09 p.m.) Status -- This change has been mar

Re: Review Request 108241: use Plasma::Dialog for icontasks tooltips

2013-04-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108241/#review30475 --- This review has been submitted with commit d0237179c5fc321cfb4

Re: Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifications

2013-04-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109825/ --- (Updated April 5, 2013, 4:01 p.m.) Review request for KDEPIM and Plasma.

Re: Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifications

2013-04-05 Thread Martin Klapetek
> On April 2, 2013, 5:53 p.m., Kevin Krammer wrote: > > resources/facebook/CMakeLists.txt, line 18 > > > > > > the resource's identifier is akonadi_facebook_resource, any reason this > > is _agent? Not really, I

Re: Review Request 106118: Plasmate: Add KWin Scripting support to konsolepreviewer.

2013-04-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/#review30470 --- Can any of the people that reviewed the previous versions revie

Re: Review Request 109860: Time data engine - use time zone latitude and longitude as default values

2013-04-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109860/ --- (Updated April 5, 2013, 3:45 p.m.) Status -- This change has been mar

Re: Review Request 109860: Time data engine - use time zone latitude and longitude as default values

2013-04-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109860/#review30465 --- This review has been submitted with commit ce998ad37d8cf31e7b8

Re: Review Request 108992: Simple optimizations in SignalPlotter

2013-04-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108992/#review30464 --- Aaron can you re-review to see if the requests you made are fix

Re: Pastebin customized icon in plasma themes

2013-04-05 Thread Aaron J. Seigo
On Monday, April 1, 2013 14:16:52 Aleix Pol wrote: > I just saw David's system and he's using a different icon theme (for > applications), so I guess it's the pastebin plasmoid not taking into > account the plasma theme. It uses the icon theme, not the plasma theme, for its icons. -- Aaron J. Se

Re: Folderview: add "Unsorted" to the "sort Icons" context menu?

2013-04-05 Thread Aaron J. Seigo
On Friday, March 29, 2013 23:55:31 Ignat Semenov wrote: > 1)Why do we need the unsorted option at all in the Display page combo? Are Probably because when the folderview is unsorted (because the user dragged things around), what else to show? I suppose in a perfect world, one might only add the

Re: Review Request 109862: PlasmaClock - fix some compilation warnings

2013-04-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109862/ --- (Updated April 5, 2013, 3:37 p.m.) Status -- This change has been mar

Re: Review Request 109862: PlasmaClock - fix some compilation warnings

2013-04-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109862/#review30460 --- This review has been submitted with commit 640aaaba3dba06bb2ea

Re: Review Request 109860: Time data engine - use time zone latitude and longitude as default values

2013-04-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109860/#review30459 --- Ship it! Ship It! - Marco Martin On April 4, 2013, 7:02 p.m

Re: Plasma mediacenter rss plugin

2013-04-05 Thread Gregor Tätzner
On Thursday 04 April 2013 22:56:25 Shantanu Tushar Jha wrote: > Hi Gregor, > > Yep I noticed the branch sometime back and nice to see that you're > interested and implemented it. Right now I'm really low on time and don't > build kde from git these days so building a specific kdepimlibs branch is

Re: Review Request 109862: PlasmaClock - fix some compilation warnings

2013-04-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109862/#review30447 --- Ship it! Ship It! - Marco Martin On April 4, 2013, 8:01 p.m

Re: Review Request 109492: Allow Rich Text in QML notifications plasmoid

2013-04-05 Thread nucleo nucleo
> On March 31, 2013, 10:19 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 81fd37ec62cf8f064996aac409e6808ec7916153 by David Edmundson to branch > > KDE/4.10. > > nucleo nucleo wrote: > I still see popups with things like "" with kde-workspace-4.10.2 and > back

Re: Review Request 109492: Allow Rich Text in QML notifications plasmoid

2013-04-05 Thread nucleo nucleo
> On March 31, 2013, 10:19 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 81fd37ec62cf8f064996aac409e6808ec7916153 by David Edmundson to branch > > KDE/4.10. > > nucleo nucleo wrote: > I still see popups with things like "" with kde-workspace-4.10.2 and > back

Re: Review Request 109492: Allow Rich Text in QML notifications plasmoid

2013-04-05 Thread nucleo nucleo
> On March 31, 2013, 10:19 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 81fd37ec62cf8f064996aac409e6808ec7916153 by David Edmundson to branch > > KDE/4.10. I still see popups with things like "" with kde-workspace-4.10.2 and backported patch. I use DBus based po