----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109825/ -----------------------------------------------------------
(Updated April 5, 2013, 4:01 p.m.) Review request for KDEPIM and Plasma. Changes ------- Fix issues found by Kevin Description ------- This patch displays a KNotification whenever an unread notification exists on Facebook. This KNotification groups at most 3 notifications into one popup and then say "...and N more" if there is more. It also keeps track of which notifications were already displayed and does not display them again unless they were updated on the server. This is all stored in a separate config file. Then it creates a KSNI for the notifications where it always show the newest three notifications in the tooltip (regardless if it was displayed before or not) and creates a menu with the notifications, which opens browser with the notification link. Diffs (updated) ----- resources/facebook/CMakeLists.txt e8c6381 resources/facebook/facebookresource.h 4a16c0c resources/facebook/facebookresource.cpp 67e8f3b resources/facebook/facebookresource_notifications.cpp 7f6b8c4 resources/facebook/serializer/akonadi_serializer_socialnotification.cpp a261e14 resources/facebook/settingsbase.kcfg 9f8e4b5 resources/facebook/settingsdialog.cpp bfb7826 resources/facebook/settingsdialog.ui 68b6a24 Diff: http://git.reviewboard.kde.org/r/109825/diff/ Testing ------- Yes. File Attachments ---------------- KSNI http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/facebook_notifications.png Thanks, Martin Klapetek
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
