Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread David Edmundson
Initial code review of Share-Like-Connect: from provider.h ~Provider(); This class is designed to be subclassed, yet the destructor is public and non virtual. The derived classes will leak everything. -- virtual QVariant executeAction(SLC::Provider::Action action, const QVariantHash &conte

Re: A (somewhat) problematic merge

2012-11-05 Thread Luiz Romário Santana Rios
Disregard that, I just tried to merge the romariorios/calculator-qml branch into master and it went fine. I still have no idea, though, of why that wasn't working properly. Maybe I was doing something wroking. Anyway, just ignore this email. 2012/11/6 Luiz Romário Santana Rios > So, I've ported

A (somewhat) problematic merge

2012-11-05 Thread Luiz Romário Santana Rios
So, I've ported the Calculator applet to QML and I did it in a separate branch. But, as my work is based on the work already done by bettio, I merged his branch into mine and continued the work from there. The problem is that there was a lot of old stuff in his branch (it was branched from an old m

Re: Review Request: Port the Calculator applet to QML

2012-11-05 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107001/ --- (Updated Nov. 6, 2012, 2:54 a.m.) Review request for Plasma. Changes ---

Re: Review Request: Port the Calculator applet to QML

2012-11-05 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107001/ --- (Updated Nov. 6, 2012, 2:42 a.m.) Review request for Plasma. Changes ---

Re: Help

2012-11-05 Thread Jeremy Whiting
Mike, Unfortunately I've hit Virtualbox and Linux not letting the scroll wheel on the mouse work also, not on opensuse, but on both a ubuntu guest and a debian guest. I believe it's a bug in VirtualBox itself unfortunately. BR, Jeremy On Mon, Nov 5, 2012 at 2:33 PM, Chani wrote: > -- F

Fwd: Help

2012-11-05 Thread Chani
-- Forwarded message -- From: Mike Vassalotti Date: Mon, Nov 5, 2012 at 1:29 PM Subject: Help To: ch...@kde.org Dear Chani, I use Linux Open SUSE in Oracle Virtual Box. Everything is working fine except for one: I cannot get the mouse wheel to work for scrolling on the various

Re: kickoff qml

2012-11-05 Thread Gregor Tätzner
On Tuesday 23 October 2012 21:16:41 David Edmundson wrote: > On Mon, Oct 22, 2012 at 10:16 AM, Marco Martin wrote: > > Hi all, > > one thing i would like to have merged for 4.10 is the qml port of kickoff. > > i have been looking at it past few days, and it seems to have most of the > > features,

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Albert Astals Cid
El Dijous, 1 de novembre de 2012, a les 20:06:36, Aaron J. Seigo va escriure: > Hello all ... Hi > This is to inform everyone that the plasmate and share-like-connect > repositories have been moved into KDE Review so that, if all goes according > to plan, we can move them to their more permanent

Re: Review Request: load the images for the themes correctly

2012-11-05 Thread Giorgos Tsiapaliokas
> On Nov. 2, 2012, 10:20 a.m., Aaron J. Seigo wrote: > > plasmate/packagemodel.cpp, lines 546-551 > > > > > > this looks wrong; in the Package definition there is an entry for > > "colors". even if it is not create

Re: Review Request: load the images for the themes correctly

2012-11-05 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106680/ --- (Updated Nov. 5, 2012, 5:51 p.m.) Review request for Plasma. Changes ---

Review Request: Plasmate: Rename windowswitcher and remote-widgets-browser

2012-11-05 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107221/ --- Review request for Plasma. Description --- With this patch i am renam

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-05 Thread Sebastian Kügler
> On Nov. 5, 2012, 3 p.m., Sebastian Kügler wrote: > > plasmate/previewer/plasmoid/previewcontainment.h, line 42 > > > > > > add the bool visible also here > > Antonis Tsiapaliokas wrote: > Sorry but i don't get

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-05 Thread Antonis Tsiapaliokas
> On Nov. 5, 2012, 3 p.m., Sebastian Kügler wrote: > > plasmate/previewer/plasmoid/previewcontainment.h, line 42 > > > > > > add the bool visible also here Sorry but i don't get you. Why should i put a bool paramete

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-05 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/#review21450 --- this patch should disable the konsole widget from every plasmoi

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Pino Toscano
Alle lunedì 5 novembre 2012, Giorgos Tsiapaliokas ha scritto: > On 4 November 2012 16:55, Pino Toscano wrote: > > - the following binaries are installed in $prefix/bin: > > - plasmaengineexplorer > > - plasmakconfigxteditor > > - plasmaremoteinstaller > > - plasmate > > - plasmawallpaper

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Pino Toscano
Hi, Alle lunedì 5 novembre 2012, Giorgos Tsiapaliokas ha scritto: > On 3 November 2012 19:35, Pino Toscano wrote: > > - a numer of .ui files sets bold/bigger texts, but using a qt rich > > text which forces a font size (and in few cases also the font > > face) > > and which is the correct way in

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/#review21444 --- plasmate/mainwindow.cpp

Review Request: Plasmate: Fix the hard coded names of plasmateremoteinstaller and plasmateprevierlog

2012-11-05 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107212/ --- Review request for Plasma. Description --- On this patch i have fix t

Re: Review Request: Plasmate: Fix the coding style of the MetaData Editor

2012-11-05 Thread Daker Pinheiro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107210/#review21443 --- Ship it! Ship It! - Daker Pinheiro On Nov. 5, 2012, 2:36 p.

Review Request: Plasmate: Fix the coding style of the MetaData Editor

2012-11-05 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107210/ --- Review request for Plasma. Description --- on plasmate/plasmate/edito

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Giorgos Tsiapaliokas
On 4 November 2012 16:55, Pino Toscano wrote: > - the following binaries are installed in $prefix/bin: > - plasmaengineexplorer > - plasmakconfigxteditor > - plasmaremoteinstaller > - plasmate > - plasmawallpaperviewer > - plasmoidviewer > - remote-widgets-browser (*) > - windowswi

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Giorgos Tsiapaliokas
Hello, On 3 November 2012 19:35, Pino Toscano wrote: > - a numer of .ui files sets bold/bigger texts, but using a qt rich text > which forces a font size (and in few cases also the font face) and which is the correct way in order to fix this? > - RemoteInstaller uses "/var/tmp/plasmaremoteinst

Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-05 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/ --- Review request for Plasma. Description --- Right now the python bindi

Re: Review Request: digital clock widget - popup focus

2012-11-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105933/#review21437 --- This is not a bug, but a feature. :) The calendar, as opposed

Re: set flickable content position

2012-11-05 Thread Reza Shah
Seems these codes fixed the problem. QImageItem { id: comicPicture anchors.centerIn: parent width: actualSize ? comicPicture.nativeWidth : viewContainer.width height: actualSize ? comicPicture.nativeHeight : viewContainer.height smooth: true fillMode: QImageItem.PreserveA

Re: set flickable content position

2012-11-05 Thread Reza Shah
Hi Marco, I replaced as your suggestion, it worked, but has little problem with the scrollbar position as in this: http://paste.opensuse.org/4552016. Is this fixable from my codes? Regards, Reza On Sun, Nov 4, 2012 at 9:27 PM, Marco Martin wrote: > > use viewContainer.contentWidth instead of > c

Re: Review Request: Fix bold text in battery-monitor tooltip

2012-11-05 Thread Michele Gastaldo
> On Nov. 2, 2012, 11:18 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/batterymonitor/contents/code/logic.js, line 68 > > > > > > The first agument is a comment for the translators. It won't need to be >

Re: Review Request: Fix bold text in battery-monitor tooltip

2012-11-05 Thread Michele Gastaldo
> On Nov. 5, 2012, 3:05 a.m., David Edmundson wrote: > > Michele, do you have a commit account? If not I'll push on your behalf. No I don't, I've just started in the magic world of KDE development! Thank you for the help! - Michele ---

Re: Review Request: Fix bold text in battery-monitor tooltip

2012-11-05 Thread Sebastian Kügler
> On Nov. 2, 2012, 11:18 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/batterymonitor/contents/code/logic.js, line 68 > > > > > > The first agument is a comment for the translators. It won't need to be >