Re: Review Request: Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2

2012-10-10 Thread Richard Stockton
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106789/#review20177 --- Patch R3 is *BAD*, don't bother. I'll upload a new one shortly.

Re: Review Request: Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2

2012-10-10 Thread Richard Stockton
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106789/ --- (Updated Oct. 10, 2012, 11:54 p.m.) Review request for Plasma and Greg T.

Review Request: Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2

2012-10-10 Thread Richard Stockton
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106789/ --- Review request for Plasma and Greg T. Description --- Fix regression

Re: Review Request: Fix battery applet screen power management

2012-10-10 Thread Oliver Henshaw
> On Oct. 10, 2012, 3:43 p.m., Lukáš Tinkl wrote: > > Good catch, is this code only in master or also in 4.9 branch? Yep, it's needed in 4.9 branch and master. - Oliver --- This is an automatically generated e-mail. To reply, visit: htt

Re: Review Request: Fix battery applet screen power management

2012-10-10 Thread Sebastian Kügler
On Wednesday, October 10, 2012 15:43:11 Lukáš Tinkl wrote: > Good catch, is this code only in master or also in 4.9 branch? Should be the same in both, this fix needs to go into both branches. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 _

Re: Review Request: miscelaneous things for kdelibs/plasma

2012-10-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106782/#review20159 --- This review has been submitted with commit 168961c452d09c8d0c2

Re: Review Request: missing initializations in plasma

2012-10-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106781/#review20158 --- This review has been submitted with commit d14c7dd902486528f04

Re: Review Request: missing initializations in plasma

2012-10-10 Thread Daker Pinheiro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106781/#review20155 --- Ship it! Ship It! - Daker Pinheiro On Oct. 10, 2012, 3:42 p

Re: Review Request: missing initializations in plasma

2012-10-10 Thread Daker Pinheiro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106781/#review20154 --- Looks good. :-) - Daker Pinheiro On Oct. 10, 2012, 3:42 p.m

Re: Review Request: miscelaneous things for kdelibs/plasma

2012-10-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106782/#review20151 --- Ship it! Ship It! - Marco Martin On Oct. 10, 2012, 3:41 p.m

Re: Review Request: miscelaneous things for kdelibs/plasma

2012-10-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106782/#review20150 --- Ship it! Looks good to me. - David Edmundson On Oct. 10, 20

Re: Review Request: Fix battery applet screen power management

2012-10-10 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106784/#review20147 --- Good catch, is this code only in master or also in 4.9 branch?

Review Request: Fix battery applet screen power management

2012-10-10 Thread Oliver Henshaw
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106784/ --- Review request for Plasma and Solid. Description --- Fix battery appl

Re: Review Request: missing initializations in plasma

2012-10-10 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106781/ --- (Updated Oct. 10, 2012, 3:42 p.m.) Review request for kdelibs and Plasma.

Re: Review Request: miscelaneous things for kdelibs/plasma

2012-10-10 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106782/ --- (Updated Oct. 10, 2012, 3:41 p.m.) Review request for kdelibs and Plasma.

Re: Review Request: Translate strings in Global Keyboard Shortcuts component KDE Keyboard Layout Switcher

2012-10-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106424/#review20131 --- Ship it! Ship It! - David Edmundson On Sept. 11, 2012, 1:40

Re: Review Request: Avoid Calling setFailedToLaunch from Microblog Plasmoid

2012-10-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106622/#review20128 --- This review has been submitted with commit 7d8cbab9fda4232cbd5

Re: Review Request: Avoid Calling setFailedToLaunch from Microblog Plasmoid

2012-10-10 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106622/ --- (Updated Oct. 10, 2012, 1:24 p.m.) Review request for Plasma. Changes --

Re: kephal or qdesktopwidget

2012-10-10 Thread Aaron J. Seigo
On Wednesday, October 10, 2012 08:32:00 Reza Shah wrote: > Hi Aaron, > > Managed to test using targetSizeHint on multi monitor setup. > The targetSizeHint returned size for both monitor are the same as > monitor resolution itself. > > I tried with color wallpaper, seems no problem at both monitor