----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106782/#review20151 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Oct. 10, 2012, 3:41 p.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106782/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2012, 3:41 p.m.) > > > Review request for kdelibs and Plasma. > > > Description > ------- > > 1. change order between setting parent d-> property and deleting this d->. > (Probably does nothing) > 2. Assign directly this to o pointer > 3. Avoid the use of a possible null pointer (it is checked before) propAnim > > > Diffs > ----- > > plasma/containment.cpp 5f13c2b > plasma/datacontainer.cpp fd1ad89 > plasma/private/applethandle.cpp f6d51a2 > > Diff: http://git.reviewboard.kde.org/r/106782/diff/ > > > Testing > ------- > > This has helped me to know more about bug 297684 > (that I still suffer :-( ) > > > Thanks, > > Jaime Torres Amate > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
