Re: Review Request: Activities support for Okular

> On Oct. 2, 2012, 6:13 p.m., Albert Astals Cid wrote: > > Any reason this is at the Document level and not at the Part level? Feels > > to me it belongs more into the part than the document. > > Ivan Čukić wrote: > This is really meant to be a document-link (Resource == Document most of >

Re: Plasma Wallpapers in QML

Hi, It should be fixed now! Good night*! Aleix PS: or whatever is according to your time zone ;) On Wed, Oct 3, 2012 at 4:24 AM, Reza Shah wrote: > HI Aleix, > > The thumbnail selection faster now. > But seems the wallpaper will always set to Haenau. > Tried with ascii or hunyango, but Haenau w

Re: Plasma Wallpapers in QML

HI Aleix, The thumbnail selection faster now. But seems the wallpaper will always set to Haenau. Tried with ascii or hunyango, but Haenau will be displayed. On Wed, Oct 3, 2012 at 10:34 AM, Aleix Pol wrote: > ...and pushed. > ___ Plasma-devel mailing l

Re: Plasma Wallpapers in QML

...and pushed. On Wed, Oct 3, 2012 at 3:05 AM, Aleix Pol wrote: > On Wed, Oct 3, 2012 at 1:52 AM, Reza Shah wrote: >> HI Aleix, >> >> Tried with latest one, seems there were some delay in configuration dialog: >> - when clicking Haenau, i can feel slight delay until the thumbnail selected, >>

Review Request: Fix TextArea Plasma component documentation

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106703/ --- Review request for Plasma. Description --- The documentartion of the

Re: Plasma Wallpapers in QML

On Wed, Oct 3, 2012 at 1:52 AM, Reza Shah wrote: > HI Aleix, > > Tried with latest one, seems there were some delay in configuration dialog: > - when clicking Haenau, i can feel slight delay until the thumbnail selected, > you can compare with ascii and hunyango (do selection between them). > -

Review Request: Correct horizontalAlignment and verticalAlignment properties of TextArea

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106702/ --- Review request for Plasma. Description --- Partially corrects bug #30

Re: Plasma Wallpapers in QML

HI Aleix, Tried with latest one, seems there were some delay in configuration dialog: - when clicking Haenau, i can feel slight delay until the thumbnail selected, you can compare with ascii and hunyango (do selection between them). - seem the thumbnails are 'active', they changed their appearea

Re: Review Request: Activities support for Okular

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106685/ --- (Updated Oct. 2, 2012, 10:40 p.m.) Review request for Okular, Plasma and A

Re: Review Request: Activities support for Gwenview

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106687/ --- (Updated Oct. 2, 2012, 10:26 p.m.) Review request for Gwenview and Plasma.

Re: Plasma Wallpapers in QML

seems bounce plasmoid can be converted as animated wallpaper. it has sound, well not the baby one :) can be tickled On Wed, Oct 3, 2012 at 6:13 AM, Aaron J. Seigo wrote: > On Tuesday, October 2, 2012 20:28:29 Aleix Pol wrote: >> I just pushed the mouse events forwarding to the QGraphicsScene, not

Re: Review Request: Activities support for Okular

> On Oct. 2, 2012, 6:13 p.m., Albert Astals Cid wrote: > > Any reason this is at the Document level and not at the Part level? Feels > > to me it belongs more into the part than the document. > > Ivan Čukić wrote: > This is really meant to be a document-link (Resource == Document most of >

Re: Plasma Wallpapers in QML

On Tuesday, October 2, 2012 20:28:29 Aleix Pol wrote: > I just pushed the mouse events forwarding to the QGraphicsScene, not > it's not only alive but it can be tickled ;). ... so who'll be the first one to find a cute picture of a baby and a funny giggling sound and make it into a wallpaper? ;)

Re: Review Request: Activities support for Okular

> On Oct. 2, 2012, 6:13 p.m., Albert Astals Cid wrote: > > Any reason this is at the Document level and not at the Part level? Feels > > to me it belongs more into the part than the document. > > Ivan Čukić wrote: > This is really meant to be a document-link (Resource == Document most of >

Re: Review Request: Use Product instead of description for device names

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106637/#review19783 --- We have decided to add some magic in libsolid udisk backend tha

Re: Plasma Wallpapers in QML

On Tuesday 02 October 2012, Aleix Pol wrote: > > reason was it was asking the scene a repaint every time, with a qpixmap > > as cache is way faster now. > > > > a current issue is that every delegate you click on is actually parsing > > the qml (ouch ;) > > > > -- > > Marco Martin > > ___

Re: Plasma Wallpapers in QML

On Tue, Oct 2, 2012 at 5:39 PM, Aleix Pol wrote: > On Tue, Oct 2, 2012 at 5:33 PM, Marco Martin wrote: >> On Tuesday 02 October 2012, Aleix Pol wrote: >>> > I'll look into this during next (or this, already >.<) week. >>> > >>> > Looked into Haenau, looking promising! >>> > >>> > Thanks for carin

Re: Review Request: Activities support for Okular

> On Oct. 2, 2012, 6:13 p.m., Albert Astals Cid wrote: > > Any reason this is at the Document level and not at the Part level? Feels > > to me it belongs more into the part than the document. > > Ivan Čukić wrote: > This is really meant to be a document-link (Resource == Document most of >

Re: Review Request: Activities support for Okular

> On Oct. 2, 2012, 6:13 p.m., Albert Astals Cid wrote: > > Any reason this is at the Document level and not at the Part level? Feels > > to me it belongs more into the part than the document. This is really meant to be a document-link (Resource == Document most of the time -> thus ResourceInst

Re: Review Request: Activities support for Okular

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106685/#review19772 --- Any reason this is at the Document level and not at the Part le

Re: plasma2 and ToolTipManager

On Tue, Oct 2, 2012 at 6:38 AM, Martin Gräßlin wrote: > I hope you realize that the discussion about screenshots is quite some > bikeshedding at the moment as haha, well i'm just making sure that this is known really, so that we think about it as we go. it may be bikeshedding, but it's also good

Re: Review Request: Activities support for Okular

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106685/ --- (Updated Oct. 2, 2012, 4:15 p.m.) Review request for Okular, Plasma and Al

Re: Review Request: Activities support for Gwenview

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106687/ --- (Updated Oct. 2, 2012, 4:06 p.m.) Review request for Gwenview and Plasma.

Re: Plasma Wallpapers in QML

On Tue, Oct 2, 2012 at 5:33 PM, Marco Martin wrote: > On Tuesday 02 October 2012, Aleix Pol wrote: >> > I'll look into this during next (or this, already >.<) week. >> > >> > Looked into Haenau, looking promising! >> > >> > Thanks for caring, Marco! :) >> > Aleix >> >> I pushed a new dialog with t

Re: Plasma Wallpapers in QML

On Tuesday 02 October 2012, Aleix Pol wrote: > > I'll look into this during next (or this, already >.<) week. > > > > Looked into Haenau, looking promising! > > > > Thanks for caring, Marco! :) > > Aleix > > I pushed a new dialog with the previews. It still doesn't get much CPU > here (or maybe

Re: Plasma Wallpapers in QML

On Mon, Oct 1, 2012 at 12:56 AM, Aleix Pol wrote: > On Sat, Sep 29, 2012 at 5:25 PM, Marco Martin wrote: >> On Saturday 29 September 2012, Marco Martin wrote: >>> i tried to do a wallpaper (called haenau) in the style of the "typical" >>> default kde wallpaper that is just some simple svg shapes

Re: Review Request: add preview thumbnail at color wallpaper config dialog

> On Oct. 2, 2012, 2:20 p.m., Aleix Pol Gonzalez wrote: > > plasma/generic/wallpapers/color/itemsview.h, line 1 > > > > > > Shouldn't the ItemsView be in some kind of common place? > > > > I probably should b

Re: Review Request: Activities support for Gwenview

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106687/#review19757 --- Thanks for this contribution! I have a few remarks however: 1.

Re: Review Request: add preview thumbnail at color wallpaper config dialog

> On Oct. 2, 2012, 2:20 p.m., Aleix Pol Gonzalez wrote: > > plasma/generic/wallpapers/color/itemsview.h, line 1 > > > > > > Shouldn't the ItemsView be in some kind of common place? > > > > I probably should b

Re: Review Request: add preview thumbnail at color wallpaper config dialog

> On Oct. 2, 2012, 2:20 p.m., Aleix Pol Gonzalez wrote: > > plasma/generic/wallpapers/color/itemsview.h, line 1 > > > > > > Shouldn't the ItemsView be in some kind of common place? > > > > I probably should b

Re: Display Configuration KCM design review

On Tuesday, October 2, 2012 14:29:24 Dan Vrátil wrote: > I'm now working on new KCM. code -- where is the code currently? i find it is often a lot easier to comment (and help out) when i can build and try the code directly duality in interaction -- my first thought is

Re: Review Request: add preview thumbnail at color wallpaper config dialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106626/#review19754 --- plasma/generic/wallpapers/color/itemsview.h

Re: plasma2 and ToolTipManager

On Tuesday, October 2, 2012 12:38:11 Martin Gräßlin wrote: > should at least try to make that possible and not kill that before we > even start with going to Wayland, can we? yes, i agree. my concern is that we may be tempted to answer too many questions with "put it in the window manager" in spi

Re: Display Configuration KCM design review

On Tuesday 02 October 2012, Daniel Nicoletti wrote: > You should also place the main view inside a framed view, > so it looks more like native QWidgets. Another nice option > would have no background in QML view and just be rendered > into the huge gray area, maybe with an horizontal line > to deli

Re: Display Configuration KCM design review

On Tuesday 02 October 2012, Dan Vrátil wrote: > > That's what I though too. But if I understand the code correctly, > > http://quickgit.kde.org/index.php?p=kde- > runtime.git&a=blob&f=plasma%2Fdeclarativeimports%2Fqtextracomponents%2Fqico > nitem.cpp > > on line 114, it forces KIconLoader to loa

Re: Display Configuration KCM design review

On Tuesday 02 October 2012, Dan Vrátil wrote: > > i was about to ask what it was for ;) > > maybe the primary should just have written "primary" in it > > the others have a "make primary" below the monitor (not in it since > > doesn't fit) > > also, what does the green thick? > > When you click th

Re: Display Configuration KCM design review

On Tuesday 02 of October 2012 15:17:20 Marco Martin wrote: > On Tuesday 02 October 2012, Dan Vrátil wrote: > > On Tuesday 02 of October 2012 14:52:50 Marco Martin wrote: > > > On Tuesday 02 October 2012, Marco Martin wrote: > > > > * no underline below the resolution > > > > * could them be a bit s

Re: Display Configuration KCM design review

On Tuesday 02 October 2012, Dan Vrátil wrote: > On Tuesday 02 of October 2012 14:52:50 Marco Martin wrote: > > On Tuesday 02 October 2012, Marco Martin wrote: > > > * no underline below the resolution > > > * could them be a bit spaced? now they are touching and looks quite > > > cramped > > > * gr

Re: Display Configuration KCM design review

You should also place the main view inside a framed view, so it looks more like native QWidgets. Another nice option would have no background in QML view and just be rendered into the huge gray area, maybe with an horizontal line to delimit the area with buttons.. Also copy this class to your code

Re: Display Configuration KCM design review

On Tuesday 02 of October 2012 14:52:50 Marco Martin wrote: > On Tuesday 02 October 2012, Marco Martin wrote: > > * no underline below the resolution > > * could them be a bit spaced? now they are touching and looks quite > > cramped > > * green rounded rectanlgles doesn't look that good > > ah, an

Re: Display Configuration KCM design review

On Tuesday 02 of October 2012 14:50:01 Marco Martin wrote: > On Tuesday 02 October 2012, Dan Vrátil wrote: > > Hi! > > > > As some might notice [0], we are working with Alex Fiestas on new display > > management for KDE. I'm now working on new KCM. Aaron suggested in > > comments > > below the blo

Re: Display Configuration KCM design review

On Tuesday 02 of October 2012 14:48:25 Sebastian Kügler wrote: > On Tuesday, October 02, 2012 14:29:24 Dan Vrátil wrote: > > As some might notice [0], we are working with Alex Fiestas on new display > > management for KDE. I'm now working on new KCM. Aaron suggested in > > comments > > below the bl

Re: Display Configuration KCM design review

On Tuesday 02 October 2012, Marco Martin wrote: > * no underline below the resolution > * could them be a bit spaced? now they are touching and looks quite cramped > * green rounded rectanlgles doesn't look that good ah, another thing: what is the use of that "i" icon? it seems rendered at the wr

Re: Review Request: add preview thumbnail at color wallpaper config dialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106626/#review19747 --- This review has been submitted with commit 0f171c51284bcaf442d

Re: Display Configuration KCM design review

On Tuesday 02 October 2012, Dan Vrátil wrote: > Hi! > > As some might notice [0], we are working with Alex Fiestas on new display > management for KDE. I'm now working on new KCM. Aaron suggested in comments > below the blog post that it would be nice to discuss design of the KCM with > you, Plasm

Re: Display Configuration KCM design review

On Tuesday, October 02, 2012 14:29:24 Dan Vrátil wrote: > As some might notice [0], we are working with Alex Fiestas on new display > management for KDE. I'm now working on new KCM. Aaron suggested in comments > below the blog post that it would be nice to discuss design of the KCM with > you, Pl

Display Configuration KCM design review

Hi! As some might notice [0], we are working with Alex Fiestas on new display management for KDE. I'm now working on new KCM. Aaron suggested in comments below the blog post that it would be nice to discuss design of the KCM with you, Plasma guys. As d_ed and few others suggested, I have rewr

Re: Review Request: add preview thumbnail at color wallpaper config dialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106626/#review19744 --- This review has been submitted with commit 6755e7a398dee3279ef

Re: Review Request: add preview thumbnail at color wallpaper config dialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106626/#review19742 --- Ship it! Seems a good improvement. only thing that may be not

Re: Review Request: add preview thumbnail at color wallpaper config dialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106626/ --- (Updated Oct. 2, 2012, 11:48 a.m.) Review request for Plasma and Marco Mar

Review Request: Activities support for Gwenview

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106687/ --- Review request for Gwenview and Plasma. Description --- Gwenview repo

Re: Review Request: Activities support for Okular

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106685/ --- (Updated Oct. 2, 2012, 10:55 a.m.) Review request for Okular, Plasma and A

Re: plasma2 and ToolTipManager

Am 02.10.2012 11:26, schrieb Marco Martin: On Tuesday 02 October 2012, Martin Klapetek wrote: On Tue, Oct 2, 2012 at 1:57 AM, Shaun Reich wrote: > would this stuff be now broken and useless because of us? how would it > get fixed? kind of afraid of the "oh, well it's broken on kde because

Re: plasma2 and ToolTipManager

On Tuesday 02 October 2012, Martin Klapetek wrote: > On Tue, Oct 2, 2012 at 1:57 AM, Shaun Reich wrote: > > > > > would this stuff be now broken and useless because of us? how would it > > get fixed? kind of afraid of the "oh, well it's broken on kde because > > they broke our app". or would th

Review Request: Activities support for Okular

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106685/ --- Review request for Okular, Plasma and Albert Astals Cid. Description -

Re: Re: plasma2 and ToolTipManager

On Tue, Oct 2, 2012 at 1:57 AM, Shaun Reich wrote: > would this stuff be now broken and useless because of us? how would it > get fixed? kind of afraid of the "oh, well it's broken on kde because > they broke our app". or would they require the Cancel/Allow idea of > yours? > Well if that's a