Re: Review Request: Pager QML port

> On Aug. 21, 2012, 5:15 p.m., Marco Martin wrote: > > found a small issue: when there is only one desktop, the pager should show > > nothing and be only few pixels wide (effectively "hidden") > > Marco Martin wrote: > what's the status on this? can it be merged? > > Luis Gabriel Lima wrot

Re: Review Request: Weather Forecast QML port

> On Aug. 26, 2012, 9:36 p.m., David Edmundson wrote: > > applets/weather/CMakeLists.txt, line 15 > > > > > > Where do you use this? Nowhere actually. It was there in the old version and I forgot to remove. Thanks.

Re: Review Request: LCD Weather Station QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/#review18201 --- applets/weatherstation/package/contents/ui/LCDDisplay.qml

Re: Review Request: Fixes for PlasmaCore.SortFilterModel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106248/#review18168 --- This review has been submitted with commit 51f9e2caeb2b1c82530

Re: Review Request: Fixes for PlasmaCore.SortFilterModel

> On Aug. 28, 2012, 4:01 p.m., Marco Martin wrote: > > good catch. > > only thing, may the fixes be done in a separate commit from the testcases > > addition? Sure, they are actually a set of commits here, reviewboard is just not handy to review multiple commits so I posted the whole diff. -

Re: Review Request: Fixes for PlasmaCore.SortFilterModel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106248/#review18166 --- Ship it! good catch. only thing, may the fixes be done in a se

Review Request: Fixes for PlasmaCore.SortFilterModel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106248/ --- Review request for Plasma and Marco Martin. Description --- This patc

Re: Review Request: Dictionary Runner

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106068/#review18164 --- Ship it! Code was generally really good, minor comments below.

Re: Re: move plasma tools to plasmate

On Tuesday 28 August 2012 10:06:54 Sebastian Kügler wrote: > > Also, Plasmate (again afaik) is not done using kdevplatform, I have been > > told since day 1 that it will be at some point but apparently it is not. I > > don't know if kdevplatform is the solution but what I know is that we need > > t

Re: Re: move plasma tools to plasmate

On Tuesday 28 August 2012 10:37:10 Marco Martin wrote: > yeah, but disappointing indeed that all parts of kdesdk are still in svn, > some of the apps still seem to have regular commits, so is not even > "because unmaintained" > in that repo there is something that i would definitely want, and some

Review Request: Fix KRunner's 'spell in foreign language' feature

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106244/ --- Review request for Plasma. Description --- Krunner's spellcheck plugi

Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106242/ --- Review request for kdelibs and Plasma. Description --- Krunner's spel

Re: move plasma tools to plasmate

On Tuesday, August 28, 2012 10:37:10 Marco Martin wrote: > i would like again a repo like that with all needed (did i already > mentioned i'm definitely not a fan of micro git repos?;) > that may include plsmate, plasma tools and some of the tools in kdesdk, > intersection between those that make

Re: move plasma tools to plasmate

On Tuesday 28 August 2012, Sebastian Kügler wrote: > > Plasmate only allows to create plasmoids javascript based afaik and it is > > desgined to do only that (which is cool). Imho it is wy far from > > being an sdk. > > Plasmate is not a complete SDK for everything, sure. The point here is no

Re: move plasma tools to plasmate

Hey, On Monday, August 27, 2012 10:17:21 Alex Fiestas wrote: > > > Since we are adding "yet another" repo, our tools will be segregated > > > across > > > more repositories, making worse the already not ideal situation. > > > > The idea is to consolidate all those development tools into one repo,