----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106068/#review18164 -----------------------------------------------------------
Ship it! Code was generally really good, minor comments below. One somewhat important. runners/dictionary/dictionarymatchengine.h <http://git.reviewboard.kde.org/r/106068/#comment14389> *important* This is not a valid license header. Copy and paste the correct one from somewhere else. runners/dictionary/dictionarymatchengine.cpp <http://git.reviewboard.kde.org/r/106068/#comment14388> License runners/dictionary/dictionaryrunner.h <http://git.reviewboard.kde.org/r/106068/#comment14387> License...etc for all other files. runners/dictionary/dictionaryrunner_config.cpp <http://git.reviewboard.kde.org/r/106068/#comment14386> Use KLineEdit unless there's a good reason not to. runners/dictionary/dictionaryrunner_config.cpp <http://git.reviewboard.kde.org/r/106068/#comment14390> Would be better to get this i18nc appearing only once. (a static method somewhere perhaps) currently if a translator translates it differently in one of the 3 places, it breaks. - David Edmundson On Aug. 18, 2012, 3:57 a.m., Jason A. Donenfeld wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106068/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2012, 3:57 a.m.) > > > Review request for Plasma, Jason A. Donenfeld and Aaron J. Seigo. > > > Description > ------- > > Jason's dictionary runner plugin for krunner. > > > Diffs > ----- > > runners/CMakeLists.txt f487563c58b5bacc5e49b9e1a0f6e306956bbf7f > runners/dictionary/CMakeLists.txt PRE-CREATION > runners/dictionary/Messages.sh PRE-CREATION > runners/dictionary/dictionarymatchengine.h PRE-CREATION > runners/dictionary/dictionarymatchengine.cpp PRE-CREATION > runners/dictionary/dictionaryrunner.h PRE-CREATION > runners/dictionary/dictionaryrunner.cpp PRE-CREATION > runners/dictionary/dictionaryrunner_config.h PRE-CREATION > runners/dictionary/dictionaryrunner_config.cpp PRE-CREATION > runners/dictionary/plasma-runner-dictionary.desktop PRE-CREATION > runners/dictionary/plasma-runner-dictionary_config.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/106068/diff/ > > > Testing > ------- > > Works well under various different loads. > > > Screenshots > ----------- > > The Runner in Action > http://git.reviewboard.kde.org/r/106068/s/679/ > > > Thanks, > > Jason A. Donenfeld > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
