Re: Review Request: Improve ProgressBar display

2012-08-15 Thread Aleix Pol Gonzalez
> On Aug. 15, 2012, 11:34 p.m., David Edmundson wrote: > > plasma/declarativeimports/plasmacomponents/qml/ProgressBar.qml, line 139 > > > > > > You've kept the trigger for width changing, but not height. > > >

Re: Review Request: Improve ProgressBar display

2012-08-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105966/#review17497 --- This review has been submitted with commit eb0c23a213cb7782558

Re: Review Request: Improve ProgressBar display

2012-08-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105966/#review17496 --- This review has been submitted with commit a8acf6dc8b9ccd3e949

Re: Review Request: Improve ProgressBar display

2012-08-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105966/#review17495 --- plasma/declarativeimports/plasmacomponents/qml/ProgressBar.qml

Re: Review Request: increase the width of the group items in the popup of the task manager applet

2012-08-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105849/#review17491 --- This review has been submitted with commit 1e64a33e3d64e51de5f

Re: Review Request: increase the width of the group items in the popup of the task manager applet

2012-08-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105849/#review17490 --- This review has been submitted with commit 5d1e8bc806e4230d77e

Re: Review Request: increase the width of the group items in the popup of the task manager applet

2012-08-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105849/#review17475 --- Ship it! Ship It! - Marco Martin On Aug. 15, 2012, 7:06 p.m

Re: Review Request: increase the width of the group items in the popup of the task manager applet

2012-08-15 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105849/ --- (Updated Aug. 15, 2012, 7:06 p.m.) Review request for Plasma and Marco Mar

Re: Review Request: Reduce the memory usage of the fileWatcher plasmoid

2012-08-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105940/#review17445 --- This review has been submitted with commit e0dd48232daa0478a53

Re: Review Request: Reduce the memory usage of the fileWatcher plasmoid

2012-08-15 Thread Sebastian Kügler
> On Aug. 14, 2012, 11:01 a.m., Sebastian Kügler wrote: > > Makes sense. Thanks! > > Simeon Bird wrote: > Cheers! To master, or can I back-port it to 4.9.1 as well? I think committing it to the KDE/4.9 branch is fine as well. Please use the BUG and FIXED-IN keywords in your commit, so it

Re: Translations

2012-08-15 Thread Alexander Potashev
Hi Dmitry, Yes, it seems that the C++ system tray automatically loads the catalog "plasma_applet_systemtray.mo", probably guessing it from the name of the applet's shared library (plasma_applet_systemtray.so). For QML Plasma applets, there must be a similar automatic translation catalog loader. F