> On Aug. 14, 2012, 11:01 a.m., Sebastian Kügler wrote: > > Makes sense. Thanks! > > Simeon Bird wrote: > Cheers! To master, or can I back-port it to 4.9.1 as well?
I think committing it to the KDE/4.9 branch is fine as well. Please use the BUG and FIXED-IN keywords in your commit, so it turns up in the changelog, in case people run into problems. Thanks! - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105940/#review17369 ----------------------------------------------------------- On Aug. 9, 2012, 1:34 a.m., Simeon Bird wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105940/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2012, 1:34 a.m.) > > > Review request for Plasma. > > > Description > ------- > > As noted in bug 256187, the fileWatcher plasmoid can use a lot of memory, > particularly when first reading a file. > This turns out to be because the whole file is added to the textDocument, > instead of just the last few lines. > > As a bonus, fix an (unreported) bug where if a line matched two filters, it > could be printed twice. > > > This addresses bug 256187. > http://bugs.kde.org/show_bug.cgi?id=256187 > > > Diffs > ----- > > applets/fileWatcher/fileWatcher.cpp fdf804c > > Diff: http://git.reviewboard.kde.org/r/105940/diff/ > > > Testing > ------- > > Compiled, watched some (small and large) files, added and deleted lines from > them. > > > Thanks, > > Simeon Bird > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
