Re: Review Request: Plasmate: Add mimetype support into the "executable scripts"

2011-08-17 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102357/#review5785 --- editors/editpage.cpp

Re: Review Request: Plasmate: Add mimetype support into the "executable scripts"

2011-08-17 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102357/#review5784 --- thanks for the patch and noticing this issue. what would probab

Re: Opinion on config dialog for QML plasmoids

2011-08-17 Thread Aaron J. Seigo
On Wednesday, August 17, 2011 22:52:14 Marco Martin wrote: > i would say ship it (well, after is tested :p) ok; i'll try and find the time to test it. shouldn't be too hard to do so. > how does this sound? and does seem feasible enough? i think so; it keeps backwards compatibility with a path fo

Review Request: Plasmate: Add mimetype support into the "executable scripts"

2011-08-17 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102357/ --- Review request for Plasma. Summary --- Hello If you open the "files"

Re: Opinion on config dialog for QML plasmoids

2011-08-17 Thread Marco Martin
On Wednesday 17 August 2011, Aaron J. Seigo wrote: > On Wednesday, August 17, 2011 12:00:13 Marco Martin wrote: > > On Monday 04 July 2011, Viranch Mehta wrote: > > me merged in master is the system kcms missing.an easy way would be > > adding > > in the applet desktop file what kcms it needs, >

Re: Opinion on config dialog for QML plasmoids

2011-08-17 Thread Marco Martin
On Wednesday 17 August 2011, Viranch Mehta wrote: > On Wed, Aug 17, 2011 at 3:30 PM, Marco Martin wrote: > > at the moment the only thing stopping the battery and the device notifier > > to > > me merged in master is the system kcms missing. > > Let me point out here that the battery still someho

Re: Opinion on config dialog for QML plasmoids

2011-08-17 Thread Viranch Mehta
On Wed, Aug 17, 2011 at 3:30 PM, Marco Martin wrote: > at the moment the only thing stopping the battery and the device notifier > to > me merged in master is the system kcms missing. > Let me point out here that the battery still somehow lacks the ability to recognize the QStringStringMap power

Re: Review Request: Fixing massive memory consumption in KWin using the raster graphicssystem.

2011-08-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101385/#review5777 --- This review has been submitted with commit 66b2cc4d31e380e3b2bc

Re: Re: GLES again

2011-08-17 Thread Martin Gräßlin
On Wednesday 17 August 2011 16:56:36 Sebastian Kügler wrote: > Is there a workaround for this, or do hardware or driver simply not allow > using GLES on this machine? try the attached patch - it should disable the check for GLES. Making shaders work for limited GLSL is the top item on my TODO lis

Re: GLES again

2011-08-17 Thread Sebastian Kügler
Hey, Good progress, but no cigar quite yet. On Tuesday, August 16, 2011 11:01:40 Sebastian Kügler wrote: > > > - Linker problem during package build: > > > > > > /usr/lib/libgbm.so.1: undefined reference to `gbm_dri_backend' > > > collect2: ld returned 1 exit status > > > make[2]: *** [kwin/kwin

Re: Opinion on config dialog for QML plasmoids

2011-08-17 Thread Aaron J. Seigo
On Wednesday, August 17, 2011 12:00:13 Marco Martin wrote: > On Monday 04 July 2011, Viranch Mehta wrote: > me merged in master is the system kcms missing.an easy way would be adding in the applet desktop file what kcms it needs, that could be the easy way to do it, but i wouldn't be against addi

Re: Opinion on config dialog for QML plasmoids

2011-08-17 Thread Marco Martin
On Monday 04 July 2011, Viranch Mehta wrote: > Hi, > > Currently the only way QML applets can have customized config dialog is to > put the config.ui file in the main.qml directory which is loaded when > settings are > opened. > > We have reached a use case where we need a number of settings that

Re: QML applet in panel

2011-08-17 Thread Marco Martin
On Wednesday 17 August 2011, Shaun Reich wrote: > How does sizing work for a QML applet in the panel? Are there any > examples of this in action, as I couldn't find any. I'd want something > like what the device notifier has, except for the various > {konsole,konq,kate}session applets -- since they

Re: Review Request: Improve formatting of the events display on the calendar (applet)

2011-08-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102293/#review5762 --- This review has been submitted with commit d84ab98607be9a5cafa3

Re: Review Request: Improve formatting of the events display on the calendar (applet)

2011-08-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102293/#review5761 --- This review has been submitted with commit 51bdd3bcd1cad9662149

Re: Review Request: Improve formatting of the events display on the calendar (applet)

2011-08-17 Thread Lasse Liehu
> On Aug. 16, 2011, 9:03 p.m., Aaron J. Seigo wrote: > > libs/plasmaclock/calendar.cpp, line 433 > > > > > > perhaps this should be in em's instead of px? e.g. 1em or some similar > > good looking amount? sure. it

Re: Review Request: Improve formatting of the events display on the calendar (applet)

2011-08-17 Thread Lasse Liehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102293/ --- (Updated Aug. 17, 2011, 7:03 a.m.) Review request for Plasma. Summary --