Re: can't access methods of data engine output for digital-clock declarative example

2011-08-04 Thread Shaun Reich
On Fri, Jun 3, 2011 at 4:17 AM, Aaron J. Seigo wrote: > it would be getSeconds(), since it is supposed to be using the standard > Javascript object for times ... however, it seems that QTime objects are not > actually being translated into something useful :/ > > a small tweak to the dataengine sh

Re: Review Request: Attempt to fix systemtray's configuration interface layout

2011-08-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102210/#review5406 --- This review has been submitted with commit d43015c14ec4d7426283

Desktop Summit: Plasma and BKO?

2011-08-04 Thread Matthias Fuchs
Proposal: A BOF or something on the matters that follow? Some months ago (in May+) we discussed on this list the issues with BKO we [1] have. [2] At the end there was a wiki page [3] with some ideas. Imo these ideas need discussing now. Especially in the regard to what is doable with bko -- t

Re: Review Request: Qalculate: fix restoring of settings

2011-08-04 Thread Jef Steelant
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102208/ --- (Updated Aug. 4, 2011, 1:28 p.m.) Review request for Plasma. Changes ---

Re: Review Request: Attempt to fix systemtray's configuration interface layout

2011-08-04 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102210/#review5394 --- Ship it! beautiful; please commit! - Aaron J. On Aug. 4, 20

Review Request: Attempt to fix systemtray's configuration interface layout

2011-08-04 Thread Jan Gerrit Marker
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102210/ --- Review request for Plasma and Aaron J. Seigo. Summary --- Fixes the c

Re: Review Request: Qalculate: fix restoring of settings

2011-08-04 Thread Aaron J. Seigo
> On Aug. 4, 2011, 11:28 a.m., Jef Steelant wrote: > > applets/qalculate/qalculate_applet.cpp, line 250 > > > > > > I also removed this call to the parent PopopApplet::configChanged() > > since I did not see it in

Re: Review Request: Qalculate: fix restoring of settings

2011-08-04 Thread Jef Steelant
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102208/#review5386 --- applets/qalculate/qalculate_applet.cpp

Re: Review Request: Qalculate: fix restoring of settings

2011-08-04 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102208/#review5385 --- applets/qalculate/qalculate_applet.cpp

Re: Review Request: Qalculate: fix restoring of settings

2011-08-04 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102208/#review5384 --- adding the readSettings call in configChanged looks correct; how

Re: some simple tasks

2011-08-04 Thread Marco Martin
On Wednesday 03 August 2011, Jan Gerrit Marker wrote: > Hi, > > I took a look at this one: > > Issue: Columns in the system tray dialog config dialog's Entries page > > should be equal > > Reference: https://bugs.kde.org/show_bug.cgi?id=241277 > > > > Suggested Fixes: the columns should be set to

Re: some simple tasks

2011-08-04 Thread Aaron J. Seigo
On Wednesday, August 3, 2011 20:48:52 Jan Gerrit Marker wrote: > shows the result:http://wstaw.org/m/2011/08/03/Systemtray-Config-1.png looks great! can you post the patch for review? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KD

Re: some simple tasks

2011-08-04 Thread Aaron J. Seigo
On Wednesday, August 3, 2011 22:35:23 Giorgos Tsiapaliwkas wrote: > I will take this.But until saturday i will not be able to work on it because > i have to do work in the family business.Can you wait until saturday? absolutely; this is a marathon, not a race :) i look forward to your patches whe

Review Request: Qalculate: fix restoring of settings

2011-08-04 Thread Jef Steelant
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102208/ --- Review request for Plasma. Summary --- If settings were changed in th