----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102208/#review5384 -----------------------------------------------------------
adding the readSettings call in configChanged looks correct; however, moving the rest of the lines to graphicsWidget() means that unless the graphics widget is deleted after configuration, the configuration changes made while qalculate is running will not be picked up! the lines moved into graphicsWidget() should be moved back into configChanged(), and configChanged() should be called from graphicsWidget() as well. - Aaron J. On Aug. 4, 2011, 10:36 a.m., Jef Steelant wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102208/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2011, 10:36 a.m.) > > > Review request for Plasma. > > > Summary > ------- > > If settings were changed in the qalculate plasmoid, these settings were not > restored after the plasmoid was restarted (i.e. a reboot). > The settings are now read in the configChanged() method of the applet and > restored correctly. > > Extra cleanup: the signal of the m_baseDisplaySpin has also been changed to > valueChanged(), since a QSpinBox does not have a toggled() signal. > > > Diffs > ----- > > applets/qalculate/qalculate_applet.cpp > 872e55f091fb8ada98a5623bfd36c54d45b95336 > applets/qalculate/qalculate_settings.cpp > 0cb9e494d3e4d787ed025cb88adee3c2e77626e0 > > Diff: http://git.reviewboard.kde.org/r/102208/diff > > > Testing > ------- > > Changed settings and reloaded qalcultate - no issues > > > Thanks, > > Jef > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
