Re: Review Request: Make akonadi/kdepimlibs fully optional in kdeplasma-addons

2011-04-11 Thread Theo Chatzimichos
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101095/#review2569 --- libs/lancelot-datamodels/MessagesKmail.h

Review Request: Make akonadi/kdepimlibs fully optional in kdeplasma-addons

2011-04-11 Thread Theo Chatzimichos
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101095/ --- Review request for Plasma. Summary --- Added some code in #ifdef bloc

Re: Review Request: DeclarativeImports-DataSource: Add the name of the changed source as parameter to the dataChanged() signal

2011-04-11 Thread Anton Kreuzkamp
> On April 11, 2011, 11:33 a.m., Marco Martin wrote: > > are you sure the property binding still works? > > ime, even if the qt doc about it isn't clear at all, any signal set as > > NOTIFY of some qproperty does seem to work only if doesn't have any > > parameter > > Anton Kreuzkamp wrote: >

Re: Review Request: DeclarativeImports-DataSource: Add the name of the changed source as parameter to the dataChanged() signal

2011-04-11 Thread Marco Martin
> On April 11, 2011, 11:33 a.m., Marco Martin wrote: > > are you sure the property binding still works? > > ime, even if the qt doc about it isn't clear at all, any signal set as > > NOTIFY of some qproperty does seem to work only if doesn't have any > > parameter > > Anton Kreuzkamp wrote: >

Re: Review Request: DeclarativeImports-DataSource: Add the name of the changed source as parameter to the dataChanged() signal

2011-04-11 Thread Anton Kreuzkamp
> On April 11, 2011, 11:33 a.m., Marco Martin wrote: > > are you sure the property binding still works? > > ime, even if the qt doc about it isn't clear at all, any signal set as > > NOTIFY of some qproperty does seem to work only if doesn't have any > > parameter ah, not quite sure, I just kn

Re: Review Request: DeclarativeImports-DataSource: Add the name of the changed source as parameter to the dataChanged() signal

2011-04-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101081/#review2554 --- are you sure the property binding still works? ime, even if the

Review Request: DeclarativeImports-DataSource: Add the name of the changed source as parameter to the dataChanged() signal

2011-04-11 Thread Anton Kreuzkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101081/ --- Review request for Plasma and Marco Martin. Summary --- Add the name