----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101095/#review2569 -----------------------------------------------------------
libs/lancelot-datamodels/MessagesKmail.h <http://git.reviewboard.kde.org/r/101095/#comment2246> Not sure about this part. If I enable them, it fails with the following error: /var/tmp/portage/kde-base/kdeplasma-addons-4.6.9999/work/kdeplasma-addons-4.6.9999_build/libs/lancelot-datamodels/moc_MessagesKmail.cpp:74: undefined reference to `Lancelot::Models::MessagesKmail::updateLater()' /var/tmp/portage/kde-base/kdeplasma-addons-4.6.9999/work/kdeplasma-addons-4.6.9999_build/libs/lancelot-datamodels/moc_MessagesKmail.cpp:75: undefined reference to `Lancelot::Models::MessagesKmail::update()' CMakeFiles/lancelot-datamodels.dir/lancelot-datamodels_automoc.o:(.data.rel.ro._ZTVN8Lancelot6Models13MessagesKmailE[vtable for Lancelot::Models::MessagesKmail]+0xe0): undefined reference to `Lancelot::Models::MessagesKmail::selfShortTitle() const' collect2: ld returned 1 exit status libs/lancelot-datamodels/MessagesKmail.cpp <http://git.reviewboard.kde.org/r/101095/#comment2247> I don't unerstand what are those macros doing here. If I uncomment them, I get errors like the following: /var/tmp/portage/kde-base/kdeplasma-addons-4.6.9999/work/kdeplasma-addons-4.6.9999/libs/lancelot-datamodels/MessagesKmail.cpp:41:1: error: expected unqualified-id before string constant - Theo On April 12, 2011, 1:27 a.m., Theo Chatzimichos wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101095/ > ----------------------------------------------------------- > > (Updated April 12, 2011, 1:27 a.m.) > > > Review request for Plasma. > > > Summary > ------- > > Added some code in #ifdef blocks to make akonadi/kdepimlibs depedencies fully > optional. I am not sure of some parts, please check my inline comments > > > Diffs > ----- > > libs/lancelot-datamodels/MessagesKmail.h 8db2a1c > libs/lancelot-datamodels/MessagesKmail.cpp 8fa89e0 > runners/contacts/contactsrunner.cpp 2b5f3ec > runners/events/events_config.h f73b22b > > Diff: http://git.reviewboard.kde.org/r/101095/diff > > > Testing > ------- > > Seems to build and work fine, either with akonadi/kdepimlibs or without. > > > Thanks, > > Theo > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
