> On 2010-11-28 23:32:29, John Tapsell wrote:
> > Sorry, but this is too much of a hack, and I don't really agree with the
> > idea of the change anyway.
> >
> > If you do a quick poll somewhere and show that other people agree it should
> > be MB by default, then I'll change it. But I don't
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6008/
---
Review request for Plasma.
Summary
---
see: http://www.mail-archive.com
> On 2010-11-28 23:39:49, Aaron Seigo wrote:
> > i think the real problem is in KSysGuardProcessList::loadSettings(const
> > KConfigGroup &cg) where it uses hard coded defaults such as this line:
> >
> > setUnits((ProcessModel::Units) cg.readEntry("units",
> > (int)ProcessModel::UnitsKB))
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6007/#review9030
---
i think the real problem is in KSysGuardProcessList::loadSettings(
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6007/#review9029
---
Sorry, but this is too much of a hack, and I don't really agree wi
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6007/
---
(Updated 2010-11-28 23:31:11.663968)
Review request for Plasma, Aaron Seigo
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6007/
---
Review request for Plasma, Aaron Seigo and John Tapsell.
Summary
---
Th
On Sunday, November 28, 2010, Martin Gräßlin wrote:
> 1. Follow the rules from Plasma concerning coding style (and all other
> development matters - reviews, git, mergin...)
i forgot to make this explicit in my earlier email, but it's worth saying imo:
to me this means that when we make decisions
Hummm... but /I/ _really_ *like* the style as it is now!!!
...
As for the transition, i guess it mostly depends on automated fixing
reliability (i ran that once in kdevelop years ago and _never_ tried it again,
but i guess the tools have meanwhile improved ;-)
Otherwise (ie if automated conve
On Sunday, November 28, 2010, Christoph Feck wrote:
> On Sunday 28 November 2010 20:20:33 Martin Gräßlin wrote:
> > From various discussion on IRC and looking through review requests, it
> > seems that we have a general problem with our coding style.
>
> For kdelibs, we have a policy that only _ne
On Sunday 28 November 2010 22:23:54 Aaron J. Seigo wrote:
> i'm pretty well finished implementing it already
you are just awesome!
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On Sunday, November 28, 2010, Aaron J. Seigo wrote:
> that's very unfortunate, really :(
to fully explain the unfortunateness and why "just set the theme to something
else internally" is quite so straightforward, Svg also needs to maintain the
ability to set the Theme for the object via Svg::set
On Sunday, November 28, 2010, Manuel Mommertz wrote:
> > > If a Plasma::Svg is not themed it stores its pixmaps in the cache of
> > > defaultTheme. For this, it would be a better solution to have a generic
> > > systemTheme or something like that, as there is no need to rerender
> > > this, if the
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6006/#review9024
---
Step 3 probably needs changes in slidingpopups effect.
When the w
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6006/
---
Review request for kwin and Plasma.
Summary
---
Turns the slide effect
On Sunday 28 November 2010 20:20:33 Martin Gräßlin wrote:
> From various discussion on IRC and looking through review requests, it
> seems that we have a general problem with our coding style.
For kdelibs, we have a policy that only _new_ code needs to follow the style
guidelines. Existing code i
On Sunday 28 November 2010 21:18:55 Chani wrote:
> a new branch? two weeks? why?
> isn't there a program for reformatting code, that could just sweep over all
> of it and be one commit? even if it's not perfect, something that could at
> least fix the brace indentation...
let's say I don't trust it
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6005/
---
Review request for Plasma and Stephen Kelly.
Summary
---
Text format of
Just noting that plasma coding style is the same as kdelibs [1]
--
Cheerio,
Ivan
[1] http://techbase.kde.org/Policies/Kdelibs_Coding_Style
--
While you were hanging yourself on someone else's words
Dying to believe in what you heard
I was staring straight into the shining sun
__
Hi,
CC-int Plasma as I would like to get some opinion on it.
From various discussion on IRC and looking through review requests, it seems
that we have a general problem with our coding style.
* The coding style is only used in KWin
* Developers seem to have problems with it, nobody really know
On Sunday 28 November 2010 12:08:12 Aaron J. Seigo wrote:
> looking at some of the new code in Svg and Theme, it's probably time to do
> some more profiling of Svg as well as make sure the caching is working
> properly (e.g. no renderers created on a second run of the app)
agreed. should be on th
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5988/#review9015
---
Ship it!
looks like it also cleans up some dubious memory managem
On Saturday, November 27, 2010, Matthias Fuchs wrote:
> What do you think?
KBookmarkManager should be usable without showing GUI bits; so something like
your #2
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer spons
On Sunday, November 28, 2010, Manuel Mommertz wrote:
> I looked a bit deeper in the code and there are some more things that need
> a bit of work in my eyes:
>
> Currently Plasma::Theme::styleSheet takes its colors always from
> defaultTheme instead of the Theme it is called from. This is very eas
On Saturday, November 27, 2010, Manuel Mommertz wrote:
> Way better then my idea. But we still need the stylesheet from
> Plasma::Theme but with colors from the system. Any idea how to archive
> this?
yes; will require some changes to ThemePrivate::processStyleSheet and
SvgPrivate::createRenderer
I looked a bit deeper in the code and there are some more things that need a
bit of work in my eyes:
Currently Plasma::Theme::styleSheet takes its colors always from defaultTheme
instead of the Theme it is called from. This is very easy to fix.
If a Plasma::Svg is not themed it stores its pixma
In the elevator pitch I miss some mention to the existing support behind the
Plasma platform.
Something along the lines of "In addition to the community work, Plasma
development is supported by $BIG_COMPANY_NAME", where $BIG_COMPANY_NAME
currently could use the names of Nokia, Intel, AMD... for Me
27 matches
Mail list logo
