Re: Review Request: More improvements to the Fifteen puzzle

2010-10-26 Thread Anthony Bryant
> On 2010-10-26 08:12:13, Marco Martin wrote: > > /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp, line 36 > > > > > > shouldn't be 0 The reason I set it to 0 here is that I have to call setSize(size

Re: soft freeze is coming!

2010-10-26 Thread Jeffery MacEachern
What time[zone] does the freeze come into effect?  - Jeffery MacEachern On Mon, Oct 25, 2010 at 04:05, Chani wrote: > it's that time again - october 28th (this thursday) is soft freeze. > make sure you get your work on the feature plan before then! > > http://techbase.kde.org/Schedules/KDE4/4.6

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

2010-10-26 Thread Manuel Mommertz
> On 2010-10-25 20:43:20, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/svg.cpp, line 259 > > > > > > this creates a renderer too often. > > since the purpose of the cache is avoid to create renderers this is

Re: Review Request: Microblog: small patch so that microblog remembers the password even when kwallet is disabled

2010-10-26 Thread Marco Martin
> On 2010-10-21 15:39:47, Marco Martin wrote: > > for me is okay, even if an obscured password directly in the config file > > isn't great... > > some time ago it did already this thing, why was it removed? > > Chani Armitage wrote: > good question. Mohit, you should look in the svn log and

Re: Review Request: Microblog: small patch so that microblog remembers the password even when kwallet is disabled

2010-10-26 Thread Mohit Kothari
> On 2010-10-21 15:39:47, Marco Martin wrote: > > for me is okay, even if an obscured password directly in the config file > > isn't great... > > some time ago it did already this thing, why was it removed? > > Chani Armitage wrote: > good question. Mohit, you should look in the svn log and

Re: Review Request: Microblog: small patch so that microblog remembers the password even when kwallet is disabled

2010-10-26 Thread Mohit Kothari
> On 2010-10-21 15:39:47, Marco Martin wrote: > > for me is okay, even if an obscured password directly in the config file > > isn't great... > > some time ago it did already this thing, why was it removed? > > Chani Armitage wrote: > good question. Mohit, you should look in the svn log and

Re: Review Request: More improvements to the Fifteen puzzle

2010-10-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5617/#review8359 --- Ship it! apart the two comments below it's ok /trunk/KDE/kdepla