> On 2010-10-21 15:39:47, Marco Martin wrote: > > for me is okay, even if an obscured password directly in the config file > > isn't great... > > some time ago it did already this thing, why was it removed? > > Chani Armitage wrote: > good question. Mohit, you should look in the svn log and see if there was > a reason it was removed... > but since it was still *writing* it and just not reading it, my guess > would be that someone wasn't paying attention and removed it accidentally. > > Mohit Kothari wrote: > I went through the log, and it seems that although password was being > written to config file but *never* ever read from it. > > The functionality was *never* implemented nor removed accidentally. > > Mohit Kothari wrote: > Sorry, i published the last comment instead of discarding it.... the > thing is that in configChanged() the password is stored in temporary variable > while to check whether to read or write the password its checked on global > variable m_password which is empty. hence we get the empty password string > whenever we deny the wallet. > > >
ok, i've committed the patch you can close the request ;) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5679/#review8290 ----------------------------------------------------------- On 2010-10-21 18:19:51, Mohit Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5679/ > ----------------------------------------------------------- > > (Updated 2010-10-21 18:19:51) > > > Review request for Plasma. > > > Summary > ------- > > It was a bug posted on bugs.kde.org, > Here is the link: https://bugs.kde.org/show_bug.cgi?id=242377 > Well it did stored the password in config file but never read it. > So i just added the reading feature and reloaded the history. > > > Diffs > ----- > > > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp > 1188219 > > Diff: http://svn.reviewboard.kde.org/r/5679/diff > > > Testing > ------- > > I tested it on kdeplasma-addons revision 1187571 > > > Thanks, > > Mohit > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
