Re: Review Request: Plasma Mediacenter: use new plasma animations, fix some bugs

2010-05-26 Thread Christophe Olinger
Wow, thanks. My 4th accepted patch. Yay! I'll try to commit this evening or latest tomorrow. Concerning the bugs, I can collect them on our techbase page for now. Cheers, Christophe On Wed, May 26, 2010 at 11:15 PM, Alessandro Diaferia wrote: > >

KDE/kdebase/workspace/plasma/design

2010-05-26 Thread Chani Armitage
SVN commit 1131048 by chani: added some explaination of activities and context in case I get hit by a bus :) I hope it makes sense 'cause I'm getting tired. the context stuff is... not 100% coherent, and probably only 80% correct. aaron, could you check that file when you get a moment please? :)

Re: Review Request: Plasma Mediacenter: use new plasma animations, fix some bugs

2010-05-26 Thread Alessandro Diaferia
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4152/#review5876 --- Ship it! This is a good patch: the move to new animator API is a real

Re: Review Request: Embed "Virtual Desktops" KCM into the pager configuration dialog

2010-05-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4154/#review5875 --- Ship it! looks good to me, also doesn't introduce strings that is a g

Review Request: Embed "Virtual Desktops" KCM into the pager configuration dialog

2010-05-26 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4154/ --- Review request for Plasma and Aaron Seigo. Summary --- This patch makes use

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-26 Thread Jacopo De Simoi
> On May 22, 2010, Jacopo De Simoi wrote: > > I'm playing around with that now, and here's what I got so far... > > how do you like it? > > it puts a third size of icon in the dialog, and it isn't really aligned with > anything visually. Yep, I was trying to make it look like an extender in fact

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-26 Thread Jacopo De Simoi
> > Like one more font face > > and not aligned with anything either. > > the font should be the same as the top header, so there shouldn't be another > font face. as for alignment, iirc they are right aligned. You recall correctly, but it has been changed since :) Right aligning with (un)mount

Review Request: Plasma Mediacenter: use new plasma animations, fix some bugs

2010-05-26 Thread Christophe Olinger
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4152/ --- Review request for Plasma and Alessandro Diaferia. Summary --- This patch c