----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4152/ -----------------------------------------------------------
Review request for Plasma and Alessandro Diaferia. Summary ------- This patch covers the following: Features: - Use new plasma animation classes - In floating mode, fade player between pictures (avoids painting artefacts) - Return to browser after showing last picture of a slideshow - Start at first picture again after slideshow has been played and is started again - Background states are handled onExit of each state by checking the currentPlayback state - Renamed layoutZone enum members Bugfixes: - Fixed bug where video player would be fully expanded horizontally, but not vertically - Slideshow now works correctly - Bottom Panel should be correctly placed now at startup Evil bugs: - Video player always remains at 1024 x 600 :-/. Alessandro, could you have a look please? - Qt 4.7 beta 1 does not solve the blue skin bug when playing videos - Layout errors of bottom bar (will fix that in the next days) Diffs ----- trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.cpp 1130736 trunk/playground/base/plasma/MediaCenterComponents/applets/mediainfobar/mediainfobar.cpp 1130736 trunk/playground/base/plasma/MediaCenterComponents/applets/mediaplayer/mediaplayer.h 1130736 trunk/playground/base/plasma/MediaCenterComponents/applets/mediaplayer/mediaplayer.cpp 1130736 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/homestate.cpp 1130736 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenter.h 1130736 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.cpp 1130736 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.h 1130736 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.cpp 1130736 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.cpp 1130736 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.h 1130736 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.cpp 1130736 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/player.h 1130736 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/private/mediahandler.cpp 1130736 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.cpp 1130736 Diff: http://reviewboard.kde.org/r/4152/diff Testing ------- Thanks, Christophe _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
