Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-25 Thread Ignat Semenov
On 5/25/10, Aaron Seigo wrote: > > "so it's not crammed to the left side as before" > > which is how all the other dialogs are. please don't change one dialog to > some random new style without first discussing it with us on > plasma-de...@kde.org. thanks. if we change this one, then they all need

Re: Fwd: Auto-discard notification

2010-05-25 Thread Martin Gräßlin
Am Dienstag 25 Mai 2010, 18:31:55 schrieb Aaron J. Seigo: > On May 24, 2010, Martin Gräßlin wrote: > > Which is also a wontfix. The issue is not related in center text > > alignment, but in the too long window title. We cannot do anything about > > applications which think that they have to put two

Re: Panel icon sizing bug in 4.4

2010-05-25 Thread Aaron J. Seigo
On May 25, 2010, Mike Kasick wrote: > On Tue, May 25, 2010 at 10:20:46AM -0700, Aaron J. Seigo wrote: > > kickoff is a popup applet should be handled by PopupApplet and so > > shouldn't be patched for this. > > The "new-style" kickoff is indeed, I don't think the patches touch > the regular Launch

Re: Panel icon sizing bug in 4.4

2010-05-25 Thread Mike Kasick
On Tue, May 25, 2010 at 10:20:46AM -0700, Aaron J. Seigo wrote: > kickoff is a popup applet should be handled by PopupApplet and so shouldn't > be > patched for this. The "new-style" kickoff is indeed, I don't think the patches touch the regular LauncherApplet. The "old-style" kickoff (better

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-25 Thread Aaron Seigo
> On 2010-05-25 17:28:45, Aaron Seigo wrote: > > what is this patch fixing in the current pager? > > > > the checkbox is precisely how we do them in plasma, and the reasons for > > this is a combination of visual scanability and aesthetics. also, since > > we're in string freeze, we can't chan

Re: Review Request: solid dataengine fires timer for hddtemp every 10 seconds

2010-05-25 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4150/#review5866 --- Ship it! looks good; thanks for the patch :) will commit shortly. -

Review Request: solid dataengine fires timer for hddtemp every 10 seconds

2010-05-25 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4150/ --- Review request for Plasma. Summary --- https://bugs.kde.org/show_bug.cgi?id

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 2: The Default Button

2010-05-25 Thread Marco Martin
> On 2010-05-25 17:44:11, Aaron Seigo wrote: > > i'm fine with the change to the default button, but the separator should > > remain consistent with the defaults of the KDE Dev Platform. so this is a > > "half ship it" ;) please commit the change to the default button, but not > > the separato

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 2: The Default Button

2010-05-25 Thread Ignat Semenov
> On 2010-05-25 17:44:11, Aaron Seigo wrote: > > i'm fine with the change to the default button, but the separator should > > remain consistent with the defaults of the KDE Dev Platform. so this is a > > "half ship it" ;) please commit the change to the default button, but not > > the separato

Re: Compile error 4.4 Branch /kdebase/workspace/krunner/interfaces/quicksand

2010-05-25 Thread Aaron J. Seigo
On May 24, 2010, Knut Morten Johansson wrote: > Hi > > Recent(ok about 2 weeks ago)changes to made in kdebase 4.4 branch makes > compilation fail with: are you sure your sources are up to date and sync'd with svn? because i see the eventFilter method in the header file in the 4.4 branch -- Aar

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 2: The Default Button

2010-05-25 Thread Ignat Semenov
> On 2010-05-25 17:44:11, Aaron Seigo wrote: > > i'm fine with the change to the default button, but the separator should > > remain consistent with the defaults of the KDE Dev Platform. so this is a > > "half ship it" ;) please commit the change to the default button, but not > > the separato

Re: Review Request: Properly hide KConfigDialog page headers when there is no header text set

2010-05-25 Thread Ignat Semenov
> On 2010-05-25 17:41:37, Aaron Seigo wrote: > > having the header there is intentional and desired. the point is to show > > the name of the page there if a replacement string isn't explicitly > > defined. i'm not sure what problem is trying to be solved here, exactly, > > but this changes th

Re: Review Request: Properly hide KConfigDialog page headers when there is no header text set

2010-05-25 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4124/ --- (Updated 2010-05-25 18:07:48.304935) Review request for kdelibs and Plasma. Su

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-25 Thread Ignat Semenov
> On 2010-05-25 17:28:45, Aaron Seigo wrote: > > what is this patch fixing in the current pager? > > > > the checkbox is precisely how we do them in plasma, and the reasons for > > this is a combination of visual scanability and aesthetics. also, since > > we're in string freeze, we can't chan

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-25 Thread Aaron J. Seigo
On May 25, 2010, Ignat Semenov wrote: > And maybe no text at all for the separators? then they are completely random. the point is to offer a hint to the user. > Like one more font face > and not aligned with anything either. the font should be the same as the top header, so there shouldn't be a

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 2: The Default Button

2010-05-25 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4130/#review5860 --- Ship it! i'm fine with the change to the default button, but the sepa

Re: Review Request: Properly hide KConfigDialog page headers when there is no header text set

2010-05-25 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4124/#review5859 --- having the header there is intentional and desired. the point is to sh

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-25 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4119/#review5858 --- what is this patch fixing in the current pager? the checkbox is preci

Re: Panel icon sizing bug in 4.4

2010-05-25 Thread Aaron J. Seigo
On May 24, 2010, Mike Kasick wrote: > On Mon, May 24, 2010 at 10:56:53AM +0200, Marco Martin wrote: > > What should be modified i think is the size hint of the Icon applet, in > > workspace, that is explicitly used here > > and should have a sizehint of Panel in vertical/horizontal formfactors > >

Re: Panel icon sizing bug in 4.4

2010-05-25 Thread Aaron J. Seigo
On May 23, 2010, Rhapsody wrote: > On 23/05/10 18:08, Ivan Čukić wrote: > > As far as I know, it is intentional, that is, it is not a bug. > > > > From my point of view, this is something that we can make configurable > > (there already is a configuration page in system settings> application > >

Re: kbstateapplet: Plasma integration directions

2010-05-25 Thread Aaron J. Seigo
On May 23, 2010, Sandro Giessl wrote: > What's needed to fix those two outstanding points? a rewritten plasmoid. there was a start of one made for the javascript jam competition, but it was a bit overengineered and the drawing/painting never actually got implementated (just coloured blocks). but

Re: Plasma Issues [Was: KDE's Plasma: How not to do lists...]

2010-05-25 Thread Aaron J. Seigo
hi Reinhold .. thanks for the feedback. at the same time we could poll 100 users and get list of 10 "things i like the least" and a list of 10 "things i hate the most". such lists are nearly useless because, while a nice efficient way for the maker of the list to get their issues out in on

Re: Fwd: Auto-discard notification

2010-05-25 Thread Aaron J. Seigo
On May 23, 2010, Chani wrote: > On May 23, 2010 13:59:03 Marco Martin wrote: > > this has been automatically discarded, but was legit, so forwarding here > > please forward inline instead of encapsulated; kmail can't quote that > message. makes it a bit of a PITA to reply to this. actually, it ca

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-25 Thread Ignat Semenov
And maybe no text at all for the separators? Like one more font face and not aligned with anything either. (Yes, I like to remove stuff ;) On Tue, May 25, 2010 at 8:22 PM, Aaron J. Seigo wrote: > On May 22, 2010, Jacopo De Simoi wrote: >> I'm playing around with that now, and here's what I got so

Re: Fwd: Auto-discard notification

2010-05-25 Thread Aaron J. Seigo
On May 24, 2010, Martin Gräßlin wrote: > Which is also a wontfix. The issue is not related in center text alignment, > but in the too long window title. We cannot do anything about applications > which think that they have to put two absolute paths in the title. So with the tab box could always ch

Re: [PATCH] Fix kickof bug 231791 allowing apps dropping in the favorites view

2010-05-25 Thread Aaron J. Seigo
On May 22, 2010, Alessandro Diaferia wrote: > > hmm. no comment on whether it's a feature.. code looks sensible, > > although wouldn't it be more future-proof to iterate over data->urls() > > instead of only > > taking the first? > > you're just right.. so here comes the updated patch :) looks g

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-25 Thread Aaron J. Seigo
On May 22, 2010, Jacopo De Simoi wrote: > I'm playing around with that now, and here's what I got so far... > how do you like it? it puts a third size of icon in the dialog, and it isn't really aligned with anything visually. my recommendation would be to just ditch the icon altogether. it doesn

Re: Panel icon sizing bug in 4.4

2010-05-25 Thread Ivan Čukić
> Seems to do the trick on my end. Your thoughts? p.s. Do you have SVN account? Cheerio, Ivan -- You know, there are many people in the country today who, through no fault of their own, are sane. Some of them were born sane. Some of them became sane later in their lives... -- Monty Python

Re: Panel icon sizing bug in 4.4

2010-05-25 Thread Ivan Čukić
> Seems to do the trick on my end. Your thoughts? popupapplet:866 When on desktop, popup applet is not an icon, so it should return Plasma::Applet::sizeHint(...) Other things seem ok Cheerio, Ivan -- The bleeding hearts and artists, Make their stand. -- Pink Floyd _