> On 2010-05-25 17:44:11, Aaron Seigo wrote: > > i'm fine with the change to the default button, but the separator should > > remain consistent with the defaults of the KDE Dev Platform. so this is a > > "half ship it" ;) please commit the change to the default button, but not > > the separator change. > > Ignat Semenov wrote: > Please, show me a config dialog with a separator in KDE. No offense, but > I really haven't found one. Again, it creates visual noise and again, we > agreed on removing it. > > Ignat Semenov wrote: > And I have no SVN account atm, should I apply for one?
like -all- configuration dialogs of any kde app? - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4130/#review5860 ----------------------------------------------------------- On 2010-05-24 18:57:54, Ignat Semenov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4130/ > ----------------------------------------------------------- > > (Updated 2010-05-24 18:57:54) > > > Review request for Plasma and Marco Martin. > > > Summary > ------- > > This is further prettification of the Plasmoid Configuration Dialogs. As > discussed on IRC, the "Default" button is removed until we port plasmoid > config to KConfigXT and the separator is removed as well. > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/applet.cpp 1130151 > > Diff: http://reviewboard.kde.org/r/4130/diff > > > Testing > ------- > > Builds fine. The dialog has no "Default" button and no separator at the > bottom. > > > Thanks, > > Ignat > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
