Re: Review Request: Move desktop theme kcm out of style kcm and combine desktop-theme-details with it

2010-05-14 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3960/#review5672 --- Ship it! Looks good. - Ben On 2010-05-15 00:51:39, Jeremy Whiting

Re: Review Request: Move desktop theme kcm out of style kcm and combine desktop-theme-details with it

2010-05-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3960/ --- (Updated 2010-05-15 00:51:39.674689) Review request for Plasma. Summary --

Re: Review Request: Move desktop theme kcm out of style kcm and combine desktop-theme-details with it

2010-05-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3960/ --- (Updated 2010-05-15 00:14:03.987668) Review request for Plasma. Changes --

Re: Review Request: Remove confusing destkop-theme-details kcm from system-settings

2010-05-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3960/ --- (Updated 2010-05-15 00:13:02.120883) Review request for Plasma. Changes --

KDE/kdebase/workspace/kcontrol

2010-05-14 Thread Ben Cooksley
SVN commit 1126843 by bcooksley: Seperate workspace style from application style, and place them in the appropriate system settings categories. CCMAIL: plasma-devel@kde.org A desktopstyle (directory) A desktopstyle/CMakeLists.txt style/CMakeLists.txt#1126618 A

KDE Observatory moved to kdeplasma-addons

2010-05-14 Thread Sandro Andrade
KDE Observatory applet and dataengine moved to kdeplasma-addons/applets and kdeplasma-addons/dataengines, respectively. All suggestions from i18n team were done. I got no suggestions from plasma team (I know you guys are busy with higher priorities tasks :) but, because of trunk freeze, Aaron gave

Re: Review Request: Remove confusing destkop-theme-details kcm from system-settings

2010-05-14 Thread Sebastian Kügler
On Thursday 13 May 2010 18:46:17 Aaron Seigo wrote: > > On 2010-05-13 09:01:41, Marco Martin wrote: > > > it could be launched from a button that in turn resides into the theme > > > kcm (that should really be moved from where it now to desktop > > > appearance) but both of those things are quite t

Re: Review Request: bug fixes for the system-monitor applet

2010-05-14 Thread Michel Lafon-Puyo
> On 2010-05-12 22:07:10, Aaron Seigo wrote: > > a few minor coments below. the biggest issue now is that with your patch, > > the icon for the drives in the disk monitor appear _below_ the meters > > rather than beside them. are you seeing this as well? Le jeudi 13 mai 2010 14:00:25, Petri Da

Re: Review Request: bug fixes for the system-monitor applet

2010-05-14 Thread Michel Lafon-Puyo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3950/ --- (Updated 2010-05-14 08:21:03.173916) Review request for Plasma. Changes --