----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3960/ -----------------------------------------------------------
(Updated 2010-05-15 00:51:39.674689) Review request for Plasma. Summary ------- desktop-theme-details kcm is very confusing on first run. Many users expect it to set the global default plasma theme, and most users probably don't even care for the functionality it exposes. So this patch hides it, and it can still be called by kcmshell4 destkopthemedetails. I am willing to write a script that calls kcmshell4 desktopthemedetails but wonder if the users that care to use this probably know that command already anyway. Also, I thought of making this into a standalone app like oxygen-settings, but as a kcm it can be re-introduced into a "TweakUi" like app at a later time if someone wants to write such a thing. :) Diffs (updated) ----- trunk/KDE/kdebase/workspace/kcontrol/CMakeLists.txt 1126845 trunk/KDE/kdebase/workspace/kcontrol/desktoptheme/CMakeLists.txt PRE-CREATION trunk/KDE/kdebase/workspace/kcontrol/desktoptheme/desktopthemedetails.h PRE-CREATION trunk/KDE/kdebase/workspace/kcontrol/desktoptheme/desktopthemedetails.cpp PRE-CREATION trunk/KDE/kdebase/workspace/kcontrol/desktoptheme/kcmdesktoptheme.h PRE-CREATION trunk/KDE/kdebase/workspace/kcontrol/desktoptheme/kcmdesktoptheme.cpp PRE-CREATION trunk/KDE/kdebase/workspace/kcontrol/style/CMakeLists.txt 1126845 trunk/KDE/kdebase/workspace/kcontrol/style/kcmstyle.h 1126845 trunk/KDE/kdebase/workspace/kcontrol/style/kcmstyle.cpp 1126845 trunk/KDE/kdebase/workspace/plasma/tools/CMakeLists.txt 1126845 trunk/KDE/kdebase/workspace/plasma/tools/desktopthemedetails/CMakeLists.txt 1126845 trunk/KDE/kdebase/workspace/plasma/tools/desktopthemedetails/DesktopThemeDetails.ui 1126845 trunk/KDE/kdebase/workspace/plasma/tools/desktopthemedetails/Messages.sh 1126845 trunk/KDE/kdebase/workspace/plasma/tools/desktopthemedetails/desktopthemedetails.h 1126845 trunk/KDE/kdebase/workspace/plasma/tools/desktopthemedetails/desktopthemedetails.cpp 1126845 trunk/KDE/kdebase/workspace/plasma/tools/desktopthemedetails/desktopthemedetails.desktop 1126845 Diff: http://reviewboard.kde.org/r/3960/diff Testing ------- Built and installed with this change, and it works here. kcmshell4 destkopthemedetails still launches it even though it doesn't appear in system-settings any longer. Thanks, Jeremy _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
