Review Request: Add improved 'Add Icon' dialog to quicklaunch applet

2009-11-04 Thread Shafqat Bhuiyan
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2072/ --- Review request for Plasma, Aaron Seigo and Lukas Appelhans. Summary --- Thi

Re: Firefox Bookmark runner

2009-11-04 Thread Aaron J. Seigo
On November 4, 2009, Qwerty Maniac wrote: > kreadconfig --file kdeglobals --group General --key BrowserApplication yes, that works on the command line; in c++: KConfigGroup generalGroup(KGlobal::config(), "General"); const QString browser = generalGroup.readEntry("BrowserApplication", QString())

Re: thinking ahead to 4.5: features or polish?

2009-11-04 Thread Aaron J. Seigo
On November 4, 2009, Shantanu Tushar Jha wrote: > So, This should be done, but it shouldn't be like "No features, stop". > We should just put more emphasis on polish, but still let features to > come in. i can have a great emphasis on polish. maybe a few of the others here can too. but is that en

Re: thinking ahead to 4.5: features or polish?

2009-11-04 Thread Aaron J. Seigo
On November 4, 2009, you wrote: > on the other hand there are spots that are too new, thus needing a big > amount of work, also feature wise, thinking about the netbook, of course, > where now a big amount of work has been put into having something > "shippable", but the work to do is still huge

Re: thinking ahead to 4.5: features or polish?

2009-11-04 Thread Aaron J. Seigo
On November 4, 2009, Sebastian Kügler wrote: > Rather than a moratorium on new features, I'd like to have our culture more > geared towards higher quality. while a good idea in general, this doesn't really address issues we currently have outstanding. it also rather ignores the fact that no mat

Re: Firefox Bookmark runner

2009-11-04 Thread Qwerty Maniac
On Thu, Nov 5, 2009 at 1:21 AM, Jan Gerrit Marker wrote: > Hello, > The next questions: > 1) Where should I copy Firefox's database file? I think somewhere to a cache > directory, but I haven't got any idea, how to get a filepath or how to do this > exactly. > 2) How do I get the default browser?

Re: Firefox Bookmark runner

2009-11-04 Thread Aaron J. Seigo
On November 4, 2009, Jan Gerrit Marker wrote: > 1) Where should I copy Firefox's database file? I think somewhere to a > cache directory, but I haven't got any idea, how to get a filepath or how > to do this exactly. KGlobal::dirs()->locateLocale("cache", filename); or you could use a KTempFile

Re: Firefox Bookmark runner

2009-11-04 Thread Jan Gerrit Marker
Hello, The next questions: 1) Where should I copy Firefox's database file? I think somewhere to a cache directory, but I haven't got any idea, how to get a filepath or how to do this exactly. 2) How do I get the default browser? Thanks, Jan ___ Plasma-

Re: Review Request: wetter.com Weather Ion

2009-11-04 Thread Shawn Starr
> On 2009-11-03 17:31:01, Will Stephenson wrote: > > You could work out the "Current Conditions" and "Condition Icon" data on > > each update using the current system time and the UTC time in the forecast > > periods, and set these on the data source. This would AFAICS get rid of > > the 'mis

Re: Review Request: wetter.com Weather Ion

2009-11-04 Thread Thilo-Alexander Ginkel
> On 2009-11-03 17:31:01, Will Stephenson wrote: > > You could work out the "Current Conditions" and "Condition Icon" data on > > each update using the current system time and the UTC time in the forecast > > periods, and set these on the data source. This would AFAICS get rid of > > the 'mis

Re: QWebFrame and baseUrl

2009-11-04 Thread Aaron J. Seigo
On November 4, 2009, Marco Martin wrote: > anyways, the patch looks good yes, please commit (and grrr! to the trolls for changing behaviour like this) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt

Re: Kickoff's search and Recent Applications list

2009-11-04 Thread Ivan Čukić
On Wednesday 04 November 2009 15:09:15 Sebastian Kügler wrote: > On Wednesday 04 November 2009 14:24:48 Qwerty Maniac wrote: > > I've already written a patch to cover this 'issue' and will submit it > > to the reviewboard if this isn't a design decision. Waiting for > > answers :) > > Please submi

Re: thinking ahead to 4.5: features or polish?

2009-11-04 Thread Artur Souza (MoRpHeUz)
On Tuesday 03 November 2009, 20:41 Aaron J. Seigo wrote: > i spent some time today thinking about challenges as well as opportunities > that exist for our little Plasma baby who is growing up at an amazing pace. > [all the mail.] Well, everybody else already pointed out a lot of useful th

Re: Review Request: Add searched applications to the Recent list in Kickoff.

2009-11-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2059/#review2924 --- Ship it! looks good to me - Marco On 2009-11-04 14:19:21, Harsh J

Re: Kickoff's search and Recent Applications list

2009-11-04 Thread Qwerty Maniac
Thank you for the clarification, I've submitted the patch for review here: http://reviewboard.kde.org/r/2059/ On Wed, Nov 4, 2009 at 7:39 PM, Sebastian Kügler wrote: > On Wednesday 04 November 2009 14:24:48 Qwerty Maniac wrote: >> I've already written a patch to cover this 'issue' and will submi

Review Request: Add searched applications to the Recent list in Kickoff.

2009-11-04 Thread Harsh J
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2059/ --- Review request for Plasma. Summary --- I use Kickoff's search bar to quickl

Re: Kickoff's search and Recent Applications list

2009-11-04 Thread Sebastian Kügler
On Wednesday 04 November 2009 14:24:48 Qwerty Maniac wrote: > I've already written a patch to cover this 'issue' and will submit it > to the reviewboard if this isn't a design decision. Waiting for > answers :) Please submit the patch, it sounds like an oversight. -- sebas http://www.kde.org | h

Kickoff's search and Recent Applications list

2009-11-04 Thread Qwerty Maniac
Hello, This is more of a clarify-things-before-patch mail. I noticed that the applications (services) launched from the search results of Kickoff do not register into the Recent Applications list. I felt this need cause it saves me from typing the query again (doable with mouse entirely) when I

Re: thinking ahead to 4.5: features or polish?

2009-11-04 Thread Shantanu Tushar Jha
On Wed, Nov 4, 2009 at 5:11 AM, Aaron J. Seigo wrote: > hi all .. > > i spent some time today thinking about challenges as well as opportunities > that exist for our little Plasma baby who is growing up at an amazing pace. > > just to give you an idea of where we're at in terms of raw code product

Re: QWebFrame and baseUrl

2009-11-04 Thread Marco Martin
On Wednesday 04 November 2009, Petri Damstén wrote: > Hi, > > Seems that after update to 4.6 webkit scriptengine stopped working. Problem > is that now baseUrl has to have scheme in it to work. Is this intentional > feature in 4.6? Could be for security? not permitting local urls in some situat

Re: thinking ahead to 4.5: features or polish?

2009-11-04 Thread Marco Martin
On Wednesday 04 November 2009, Aaron J. Seigo wrote: > hi all .. > > i spent some time today thinking about challenges as well as opportunities > that exist for our little Plasma baby who is growing up at an amazing pace. > > just to give you an idea of where we're at in terms of raw code product

Re: thinking ahead to 4.5: features or polish?

2009-11-04 Thread Sebastian Kügler
On Wednesday 04 November 2009 00:41:48 Aaron J. Seigo wrote: [...] > if we decide that this is something we would like to take on, we would need > to make it fun and cool to do this hard work. i'd be sure to share bug > count stats, performance measurements and track our goals on a regular > bas

QWebFrame and baseUrl

2009-11-04 Thread Petri Damstén
Hi, Seems that after update to 4.6 webkit scriptengine stopped working. Problem is that now baseUrl has to have scheme in it to work. Is this intentional feature in 4.6? Petri Index: webapplet.cpp === --- webapplet.cpp (revi

Re: Review Request: wetter.com Weather Ion

2009-11-04 Thread Will Stephenson
> On 2009-11-03 17:31:01, Will Stephenson wrote: > > You could work out the "Current Conditions" and "Condition Icon" data on > > each update using the current system time and the UTC time in the forecast > > periods, and set these on the data source. This would AFAICS get rid of > > the 'mis

Re: thinking ahead to 4.5: features or polish?

2009-11-04 Thread Asraniel
sounds reasonable. a little sad that ubuntu 10.04 LTS will release kde 4.4, but on the same time a more fix orientated 4.5 will mean more backports to 4.4, and ubuntu will probably ship 4.4.2 (or 3). so that sounds nice. it also means a polished kde 4.5 will compete with gnome 3.0 which now has

Re: Review Request: Add missing functions to RunnerScript

2009-11-04 Thread Petri Damstén
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2054/ --- (Updated 2009-11-04 08:02:34.755273) Review request for Plasma. Changes --