Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread igorto
> On 2009-10-29 21:23:59, Marco Martin wrote: > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h, > > line 9 > > > > > > QGraphicsLayoutItem should be more than enough done > On 2009-10-29

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread igorto
> On 2009-10-29 18:45:38, Artur de Souza (MoRpHeUz) wrote: > > The commit itself seems nice. Just worried if we want to start using this > > all around. *Maybe* we have animated layouts in Qt *4.7* that would be more > > generic than this. But if we just want something specific it seems fine fo

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread igorto
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/ --- (Updated 2009-10-30 03:40:42.598111) Review request for Plasma, Aaron Seigo, Mar

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread Marco Martin
On Thursday 29 October 2009, Artur Souza (MoRpHeUz) wrote: > On Thursday 29 October 2009, 18:23 Marco Martin wrote: > > there seems to be some issues with size hints, since the only way to have > > a proper hint is to have the final size the widget will have seems hard > > to fix, how do you guys d

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread Artur Souza (MoRpHeUz)
On Thursday 29 October 2009, 18:23 Marco Martin wrote: > there seems to be some issues with size hints, since the only way to have a > proper hint is to have the final size the widget will have seems hard to > fix, how do you guys did with the real qt ones? I need to take a look at our branch. B

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/#review2856 --- i generally like it, apart of the couple of code issues below i think

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread Marco Martin
> On 2009-10-29 18:45:38, Artur de Souza (MoRpHeUz) wrote: > > The commit itself seems nice. Just worried if we want to start using this > > all around. *Maybe* we have animated layouts in Qt *4.7* that would be more > > generic than this. But if we just want something specific it seems fine fo

Re: Review Request: Add a tooltip to battery monitor applet

2009-10-29 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2010/#review2854 --- a few bits of clean up, but a tooltip is a good idea here. trunk/KDE

Re: Review Request: plasmapkg & wallpaper

2009-10-29 Thread Aaron J. Seigo
On October 29, 2009, Thomas Olsen wrote: > On 29/10-2009 19:56 "Aaron J. Seigo" wrote: > > On October 29, 2009, Thomas Olsen wrote: > > > On 29/10-2009 18:49 "Aaron J. Seigo" wrote: > > > > On October 29, 2009, Thomas Olsen wrote: > > > > > maybe add a "--force-overwrite" option or something lik

Review Request: Add a tooltip to battery monitor applet

2009-10-29 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2010/ --- Review request for Plasma. Summary --- This path adds a tool-tip for the ba

Re: Review Request: plasmapkg & wallpaper

2009-10-29 Thread Thomas Olsen
On 29/10-2009 19:56 "Aaron J. Seigo" wrote: > On October 29, 2009, Thomas Olsen wrote: > > On 29/10-2009 18:49 "Aaron J. Seigo" wrote: > > > On October 29, 2009, Thomas Olsen wrote: > > > > maybe add a "--force-overwrite" option or something like that. > > > > > > it already has one: "--upgrade"

Re: Review Request: plasmapkg & wallpaper

2009-10-29 Thread Aaron J. Seigo
On October 29, 2009, Thomas Olsen wrote: > On 29/10-2009 18:49 "Aaron J. Seigo" wrote: > > On October 29, 2009, Thomas Olsen wrote: > > > maybe add a "--force-overwrite" option or something like that. > > > > it already has one: "--upgrade". > > Which isn't enough at it's current state. See belo

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread igorto
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/ --- (Updated 2009-10-29 18:45:58.421256) Review request for Plasma, Aaron Seigo, Mar

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread Artur de Souza (MoRpHeUz)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/#review2853 --- The commit itself seems nice. Just worried if we want to start using t

Re: Review Request: plasmapkg & wallpaper

2009-10-29 Thread Thomas Olsen
On 29/10-2009 18:49 "Aaron J. Seigo" wrote: > On October 29, 2009, Thomas Olsen wrote: > > maybe add a "--force-overwrite" option or something like that. > > it already has one: "--upgrade". Which isn't enough at it's current state. See below. > > I don't know if Plasma::PackageStructure->unin

Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread igorto
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/ --- Review request for Plasma, Aaron Seigo, Marco Martin, Artur de Souza (MoRpHeUz),

Re: Review Request: plasmapkg & wallpaper

2009-10-29 Thread Aaron J. Seigo
On October 29, 2009, Thomas Olsen wrote: > maybe add a "--force-overwrite" option or something like that. it already has one: "--upgrade". > I don't know if Plasma::PackageStructure->uninstallPackage() has any error > checking some but not enough, really. > (couldn't find it on websvn) but it

Re: Review Request: plasmapkg & wallpaper

2009-10-29 Thread Thomas Olsen
On 29/10-2009 17:09 "Aaron Seigo" wrote: > > /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp > > > with this there really is no point in having "upgrade". the idea is > that install should always be safe and not silently obliterate

Re: Review Request: plasmapkg & wallpaper

2009-10-29 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2006/#review2852 --- /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp

Re: Activities service in KDEreview

2009-10-29 Thread Will Stephenson
On Thursday 29 October 2009 10:41:01 Ivan Čukić wrote: > > As I understand the code, current activity is globally modal? > > Yes. Although plasma will be the main manager of activities, other > applications can be as well. That's interesting, but I am interested in the UI implications of having a

Re: Activities service in KDEreview

2009-10-29 Thread Ivan Čukić
> As I understand the code, current activity is globally modal? Yes. Although plasma will be the main manager of activities, other applications can be as well. I'm currently preparing a bit of nepomukification of the storage (as per Sebastian's instructions) - will be committed very soon. Che

Re: Activities service in KDEreview

2009-10-29 Thread Will Stephenson
On Wednesday 21 October 2009 21:46:39 Ivan Čukić wrote: > After some time I spent "on the ice" due to problems with compiling Qt 4.6, > I've finally been able to polish the activities service. > > It is now in kdereview/nepomuk-activities-service As I understand the code, current activity is glob

Review Request: plasmapkg & wallpaper

2009-10-29 Thread Petri Damstén
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2006/ --- Review request for Plasma. Summary --- * install wallpaper plasma packages