Re: Review Request: Density unit conversion

2009-06-02 Thread Petri Damstén
On Tuesday 02 June 2009 20:34:01 Aaron J. Seigo wrote: > On Tuesday 02 June 2009, Petri Damstén wrote: > > I have plans to make translation better in 4.4. I guess singular, plural > > strings should be a one KLocalizedString but I'm not sure if it can be > > used that way? > > afaik, yes. and it's

Re: Current Animations Poll for QT Kinetic + Plasma

2009-06-02 Thread Aaron J. Seigo
On Tuesday 02 June 2009, Alexis Ménard wrote: > On Tue, Jun 2, 2009 at 11:31 PM, Akmanalp, Mehmet A wrote: > > Hello, > > As a result of the previous discussion [0], I set out to see what all > > the current plasma apps (in svn) were doing in regards to animation so > > I gathered some data simply

Re: Current Animations Poll for QT Kinetic + Plasma

2009-06-02 Thread Alexis Ménard
On Tue, Jun 2, 2009 at 11:31 PM, Akmanalp, Mehmet A wrote: > Hello, > As a result of the previous discussion [0], I set out to see what all > the current plasma apps (in svn) were doing in regards to animation so > I gathered some data simply by grepping for customAnimation through > their sources

Current Animations Poll for QT Kinetic + Plasma

2009-06-02 Thread Akmanalp, Mehmet A
Hello, As a result of the previous discussion [0], I set out to see what all the current plasma apps (in svn) were doing in regards to animation so I gathered some data simply by grepping for customAnimation through their sources [1], then checking out what they were doing. In short: 7 fades 2 sli

Re: Review Request: Density unit conversion

2009-06-02 Thread Aaron J. Seigo
On Tuesday 02 June 2009, Petri Damstén wrote: > I have plans to make translation better in 4.4. I guess singular, plural > strings should be a one KLocalizedString but I'm not sure if it can be used > that way? afaik, yes. and it's in fact necessary to do translations correctly at all since some

Re: Review Request: Density unit conversion

2009-06-02 Thread Petri Damstén
On Tuesday 02 June 2009 18:44:31 Aaron Seigo wrote: > in the meantime, the i18n here looks very wrong. shouldn't it be: > > i18np("density unit", "ounce per cubic foot", "ounces per cubit foot", ..)? No, currently unit takes arguments as (singular, plural, symbol, ... > i seem to recall the trans

Re: PlasMate previewer

2009-06-02 Thread Aaron J. Seigo
On Tuesday 02 June 2009, Yuen Hoe Lim wrote: > it =/ Can anyone give me some directions? :P well, there are a number of things that can be done with it... * the two large +s should probably be made a lot smaller and moved into the corners * when the previewer is quite small, the nice overlay do

Re: Review Request: Progress Widget in krunner

2009-06-02 Thread Jacopo De Simoi
> On 2009-06-02 08:23:55, Aaron Seigo wrote: > > i like the idea ... but i think we should consider how this is all being > > done a bit more. Jacopo has already talked a bit about the technical side > > of things, though i'm sure those are surmountable. > > > > first, since we have a QGraphic

Re: Review Request: Density unit conversion

2009-06-02 Thread kashyap puranik
Ah thats a typo, I ll fix it. I don't really know about the translation part. I just copied from some other file. I needed the density part in Kalzium. Thanks for the advice :). I will try creating the branch and fixing the translation. Thank you :) ___

PlasMate previewer

2009-06-02 Thread Yuen Hoe Lim
Hi, >From the last plasmate irc meeting I was supposed to work on the previewer, but embarassingly I've been playing and staring at the code for some time now and I'm still not sure what I should be doing with it =/ Can anyone give me some directions? :P Thanks, -- Lim Yuen Hoe http://yuen

Re: Review Request: Keyboard shortcuts to move krunner

2009-06-02 Thread jgoday
> On 2009-06-02 08:46:21, Aaron Seigo wrote: > > i'm not sure what the use case for this is? my concern is that it will make > > up/down movement through the results list a bit odd since sometimes up/down > > will move the selection between items in the results list and sometimes > > move the

Re: Review Request: Progress Widget in krunner

2009-06-02 Thread Aaron Seigo
> On 2009-06-02 08:23:55, Aaron Seigo wrote: > > i like the idea ... but i think we should consider how this is all being > > done a bit more. Jacopo has already talked a bit about the technical side > > of things, though i'm sure those are surmountable. > > > > first, since we have a QGraphic

Re: Review Request: Keyboard shortcuts to move krunner

2009-06-02 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/785/#review1263 --- i'm not sure what the use case for this is? my concern is that it will

Re: Review Request: Density unit conversion

2009-06-02 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/779/#review1262 --- as this introduces new strings (and arguably a new feature :) it will h

Re: Review Request: Progress Widget in krunner

2009-06-02 Thread jgoday
> On 2009-06-02 08:23:55, Aaron Seigo wrote: > > i like the idea ... but i think we should consider how this is all being > > done a bit more. Jacopo has already talked a bit about the technical side > > of things, though i'm sure those are surmountable. > > > > first, since we have a QGraphic

Re: Review Request: Prettify system-monitor cpu tooltip

2009-06-02 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/788/#review1260 --- Ship it! - Aaron On 2009-06-02 02:02:25, Aurélien Gâteau wrote: > >

Re: Review Request: Progress Widget in krunner

2009-06-02 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/789/#review1259 --- i like the idea ... but i think we should consider how this is all bein

reviewboard: clean up after yourself :)

2009-06-02 Thread Aaron J. Seigo
hi... if you have a patch on reviewboard and it's either been committed or been retracted for submission, _please_ be sure to mark it as such. there's a huge list of patches there right now and i really don't know which are needing attention and grooming without looking through svn for each one

Re: Review Request: Progress Widget in krunner

2009-06-02 Thread Jacopo De Simoi
> On 2009-06-02 03:43:16, Jacopo De Simoi wrote: > > The idea is quite nice, however I see a problem here: > > > >connect(runnerManager, SIGNAL(matchesChanged(const > > QList &)), SLOT(stopProgressWidget())); > > > > in fact matchesChanged might be called several times during a query, > >

Re: Review Request: Progress Widget in krunner

2009-06-02 Thread jgoday
> On 2009-06-02 03:43:16, Jacopo De Simoi wrote: > > The idea is quite nice, however I see a problem here: > > > >connect(runnerManager, SIGNAL(matchesChanged(const > > QList &)), SLOT(stopProgressWidget())); > > > > in fact matchesChanged might be called several times during a query, > >

Re: Review Request: Progress Widget in krunner

2009-06-02 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/789/#review1255 --- The idea is quite nice, however I see a problem here: connect(runne

Review Request: Progress Widget in krunner

2009-06-02 Thread jgoday
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/789/ --- Review request for Plasma. Summary --- Display a progress widget in krunner

Review Request: Prettify system-monitor cpu tooltip

2009-06-02 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/788/ --- Review request for Plasma. Summary --- CPU monitor tooltips are too precise: