Re: Review Request: Add keyboard navigation to plasma applet Folder View

2009-04-08 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/ --- (Updated 2009-04-08 21:33:17.329268) Review request for Plasma. Changes ---

Re: Review Request: Some reworking of the job widget used for the systemtray.

2009-04-08 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/539/#review880 --- Ship it! the magic numbers scare me slightly, but that's easily fixed :

Review Request: Some reworking of the job widget used for the systemtray.

2009-04-08 Thread Rob Scheepmaker
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/539/ --- Review request for Plasma. Summary --- There are some problems with the curr

Re: Usability questions for Mandelbrot

2009-04-08 Thread Benoit Jacob
2009/4/9 Sebastian Kügler : > Make the mouse pointer a hand only when the left button is pressed, this way > you get visual feedback without the distraction of the always hand. good idea! Benoit ___ Plasma-devel mailing list Plasma-devel@kde.org https:/

Re: Usability questions for Mandelbrot

2009-04-08 Thread Sebastian Kügler
On Wednesday 08 April 2009 18:42:37 Benoit Jacob wrote: > Question 2. > > In unlocked mode, should the mouse pointer become a little hand (or > something like that) to indicate that the view can be dragged? Or > should we keep the default pointer? > Argument in favor of default pointer: it might be

Re: Mandelbrot, continued (and plasma bug reports)

2009-04-08 Thread Benoit Jacob
2009/4/8 Aaron J. Seigo : > On Wednesday 08 April 2009, Benoit Jacob wrote: >> (**) >> Ideally, the main Mandelbrot instance should save its config before >> the Desktop Settings embedded instance reads the config. Is that >> possible? > > this is now done in svn .. the wallpaper doesn'

Re: Mandelbrot, continued (and plasma bug reports)

2009-04-08 Thread Aaron J. Seigo
On Wednesday 08 April 2009, Benoit Jacob wrote: > (**) > Ideally, the main Mandelbrot instance should save its config before > the Desktop Settings embedded instance reads the config. Is that > possible? this is now done in svn .. the wallpaper doesn't need to care about it. -- Aaro

Re: Review Request: Add a "Windows should cover" option to plasma panels.

2009-04-08 Thread Aaron J. Seigo
On Wednesday 08 April 2009, Chris Reeves wrote: > For what it's worth, as a user I would find this behavior preferable to > both "autohide" and "windows can cover". I also have a large 16:9 screen > that is short on the vertical space. hm. ok... let's try Lucas' suggestion and modify "windows

Re: Mandelbrot, continued (and plasma bug reports)

2009-04-08 Thread Benoit Jacob
Hi, Long email but if you're in a hurry skip down to where I put stars (). 2009/4/8 Aaron J. Seigo : > On Wednesday 08 April 2009, Benoit Jacob wrote: >> Could you please tell me how to do that cleanly, or add such a method >> in the Wallpaper class? > > is would just go into Plasma::Wall

Re: Review Request: Add a "Windows should cover" option to plasma panels.

2009-04-08 Thread Chris Reeves
For what it's worth, as a user I would find this behavior preferable to both "autohide" and "windows can cover". I also have a large 16:9 screen that is short on the vertical space. KDE 4.2.2 is awesome, both in general and as a desktop workspace. I can't wait to see what you guys and gals have

Re: Usability questions for Mandelbrot

2009-04-08 Thread Benoit Jacob
2009/4/8 Aaron J. Seigo : > On Wednesday 08 April 2009, Benoit Jacob wrote: >> In locked mode, should mouse wheel do nothing? Or should it have the >> default effect which is, cycle through virtual desktops? > > if the mouse event is not used by the wallpaper, you should not call > accepted() on th

Review Request: QTimer and Event compression

2009-04-08 Thread Sujith H
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/538/ --- Review request for Plasma and Aaron Seigo. Summary --- Hi Aron, This review

Re: Usability questions for Mandelbrot

2009-04-08 Thread Aaron J. Seigo
On Wednesday 08 April 2009, Benoit Jacob wrote: > Hi, > > I have a couple usability questions. > The Mandelbrot wallpaper has 2 modes: "locked" and "unlocked". > In locked mode, it behaves like an ordinary wallpaper. In unlocked > mode, the view can be moved by mouse d&d and mouse wheel. > > Questi

Re: Mandelbrot, continued (and plasma bug reports)

2009-04-08 Thread Aaron J. Seigo
On Wednesday 08 April 2009, Benoit Jacob wrote: > Could you please tell me how to do that cleanly, or add such a method > in the Wallpaper class? is would just go into Plasma::Wallpaper, but it feels "dirty"; the Wallpaper shouldn't care. > The reason why I need it, is that the 2 instances modif

Re: Review Request: Add a "Windows should cover" option to plasma panels.

2009-04-08 Thread Aaron J. Seigo
On Wednesday 08 April 2009, Lucas Murray wrote: > Is there any reason why the panel doesn't automatically hide again when in > "windows can cover" mode? If there isn't a reason then this new mode can > just replace it completely (Keeping the old name) as a bug fix. this could be tried, but be prep

Re: Systray jobs and notifications

2009-04-08 Thread Rob Scheepmaker
On Tuesday 07 April 2009 14:23:49 Rob Scheepmaker wrote: > Yeah, it contains notifications (both 'normal' and file completed), and > jobs, so indeed it may not be entirely optimal. However, both the in > progress jobs and the completed jobs belong to an ExtenderGroup. The thing > that might help is

Usability questions for Mandelbrot

2009-04-08 Thread Benoit Jacob
Hi, I have a couple usability questions. The Mandelbrot wallpaper has 2 modes: "locked" and "unlocked". In locked mode, it behaves like an ordinary wallpaper. In unlocked mode, the view can be moved by mouse d&d and mouse wheel. Question 1. In locked mode, should mouse wheel do nothing? Or shoul

Re: Review Request: Add keyboard navigation to plasma applet Folder View

2009-04-08 Thread Shantanu Tushar Jha
> On 2009-04-02 13:56:47, Fredrik Höglund wrote: > > I think in general the code looks good, but there are still numerous coding > > style issues, especially with the way the code is indented. > > Shantanu Tushar Jha wrote: > Oh, I apologise for that, but I'm unable to figure out where I've

Re: Review Request: Add a "Windows should cover" option to plasma panels.

2009-04-08 Thread Lucas Murray
On Wed, Apr 8, 2009 at 10:00 PM, Stefanos Harhalakis wrote: "Autohide" is good when you don't want the panel to fill your screen, but it is bad when your screen is empty. "Windows can cover" is very annoying when for example you only want to see the time, then you have to click back the applic

Mandelbrot, continued (and plasma bug reports)

2009-04-08 Thread Benoit Jacob
Hi, First of all, many thanks to Aaron and Andrew for your help. SVN now has an updated version taking it into account. Finally, I found that what I really need is to be able to distinguish between the "main instance" of the wallpaper, that is the one that is actually used as desktop background,

Re: Review Request: Add a "Windows should cover" option to plasma panels.

2009-04-08 Thread Stefanos Harhalakis
> On 2009-04-07 20:48:49, Aaron Seigo wrote: > > what's the benefit over "Windows can cover"? that you don't have to click > > on a window to hide the panel beneath it? or versus autohide, where the > > only difference is when you don't have any windows obscuring the screen > > edge the panel

Re: Review Request: The option Date for plasmoid Notes.

2009-04-08 Thread Sylvain Jolivet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/415/ --- (Updated 2009-04-08 05:21:21.263754) Review request for Plasma. Changes ---

Re: Review Request: Solar position calculation to time dataengine

2009-04-08 Thread Aaron J. Seigo
On Wednesday 08 April 2009, Petri Damstén wrote: > On Tuesday 07 April 2009 19:44:08 Aaron Seigo wrote: > > as for the I18N_NOOPs, the idea was that users of DataEngines > > could then just show the key/value pairs directly in a user interface and > > get them translated without having to know the