Re: Review Request: Enable System Monitor - Network to respond to newly connected network interfaces.

2009-03-10 Thread Shantanu Tushar Jha
> whenever a new source is added in the engine, the sourceAdded signal will be > emitted; likewise, the sourceRemoved signal will be emitted whenever a source > is removed. the applet should listen to those signals and manage its > connections that way. All is fine with sourceAdded, but somehow

Re: Review Request: Enable System Monitor - Network to respond to newly connected network interfaces.

2009-03-10 Thread Shantanu Tushar Jha
After applying the above patch to kdebase/workspace/plasma/dataengines/systemmonitor, and updating sm_net with the latest svn revision, I started the applet, connecting to my dial-up, and it detects and refreshes the list :) Still, there is a small problem that if I disconnect my dial-up, it still

Re: Notifications Theming

2009-03-10 Thread Aaron J. Seigo
On Tuesday 10 March 2009, Trever Fischer wrote: > On Tuesday 10 March 2009 12:15:53 pm Aaron J. Seigo wrote: > > On Friday 06 March 2009, Trever Fischer wrote: > > > Are there any plans to, erm, extend the Extender class and provide some > > > custom SVG elements for notifications? > > > > Rob's al

Re: Review Request: Enable System Monitor - Network to respond to newly connected network interfaces.

2009-03-10 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/246/#review452 --- whenever a new source is added in the engine, the sourceAdded signal wil

Re: Review Request: Move dragEnter and dragMove events showing of drop zone from panelview to containment.

2009-03-10 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/261/#review451 --- Ship it! my concern was that this isn't appropriate for all Containment

Re: Review Request: Addition to UI for Config page "Filter" in FolderView applet to make behavior clear.

2009-03-10 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/262/#review450 --- i think this addition is worth while; but i think we could also make the

Re: Review Request: Adds support for tabs to the comic applet

2009-03-10 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/251/#review449 --- Ship it! i'm sure a number of people will enjoy the tabs :) - Aaron

Re: Review Request: Tasks applet: group popup with real task items

2009-03-10 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/256/#review448 --- Ship it! - Aaron On 2009-03-08 15:22:38, Christian Mollekopf wrote: >

Re: Review Request: Use mouse-poll-timer for auto-hide, even if no popup is open

2009-03-10 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/267/#review439 --- Ship it! probably sensible enough :) - Aaron On 2009-03-09 09:50:43,

Re: Review Request: Add fade effect to wallpaper plugin.

2009-03-10 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/195/#review447 --- Ship it! we might need to make this configurable due to processing and

Re: Review Request: a thinghiesimilar to the toolbox on zoomed out view

2009-03-10 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/265/#review446 --- Ship it! i like the idea; let's try it out! :) /trunk/KDE/kdebase/wor

Re: Review Request: a thinghiesimilar to the toolbox on zoomed out view

2009-03-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/265/ --- (Updated 2009-03-10 14:11:50.513272) Review request for Plasma. Changes ---

Re: Review Request: Enable System Monitor - Network to respond to newly connected network interfaces.

2009-03-10 Thread Petri Damstén
On Tuesday 10 March 2009 20:37:27 you wrote: > The problem is that the dataengine doesn't send a request to KSGRD for > new monitors when those signals are emitted. So I had to add this to > the dataengine- > > KSGRD::SensorMgr->sendRequest("localhost", > "monitors",(KSGRD::SensorClient*)this,

Re: krunner

2009-03-10 Thread David Baron
On Tuesday 10 March 2009 20:30:01 Aaron J. Seigo wrote: > On Monday 09 March 2009, David Baron wrote: > > Alternative display ideas? Sort/scroll by plugin results? Etc. > > you are more likely to receive responses if you provide mockups, patches > and/or other forms of concrete suggestions. Yeah.

Re: Notifications Theming

2009-03-10 Thread Trever Fischer
On Tuesday 10 March 2009 12:15:53 pm Aaron J. Seigo wrote: > On Friday 06 March 2009, Trever Fischer wrote: > > Are there any plans to, erm, extend the Extender class and provide some > > custom SVG elements for notifications? > > Rob's already commented on the animations and current theming system

Re: Microblogging using 100% cpu

2009-03-10 Thread Marco Martin
On Tuesday 10 March 2009, Aaron J. Seigo wrote: > On Tuesday 10 March 2009, Artur Souza (MoRpHeUz) wrote: > > Hi guys, > > > > I'm in the middle of bossa conference so sorry for not providing a > > nice backtrace and debug information. > > I was using microblogging applet and sometimes my plasm

Re: Review of KDE 4.2

2009-03-10 Thread Matthias Fuchs
On Dienstag 10 März 2009 19:47:31 Nicolas Lécureuil wrote: > Le Tuesday 10 March 2009 19:28:24 Aaron J. Seigo, vous avez écrit : > > On Sunday 08 March 2009, Nicolas Lécureuil wrote: > > > I won't spend time on all the good points > > > > that's nice. > > First i am not a dev i don't so code ( not

Re: Review Request: add action collection to the corona

2009-03-10 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/268/#review445 --- Ship it! - Aaron On 2009-03-10 12:12:56, Chani wrote: > > --

Re: Review Request: add action collection to the corona

2009-03-10 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/268/ --- (Updated 2009-03-10 12:12:56.043881) Review request for Plasma and Marco Martin.

Re: Microblogging using 100% cpu

2009-03-10 Thread Zack Rusin
On Tuesday 10 March 2009 14:30:57 Aaron J. Seigo wrote: > On Tuesday 10 March 2009, Artur Souza (MoRpHeUz) wrote: > > Hi guys, > > > > I'm in the middle of bossa conference so sorry for not providing a > > nice backtrace and debug information. > > I was using microblogging applet and sometimes

Re: Review of KDE 4.2

2009-03-10 Thread Nicolas Lécureuil
Le Tuesday 10 March 2009 19:28:24 Aaron J. Seigo, vous avez écrit : > On Sunday 08 March 2009, Nicolas Lécureuil wrote: > > I won't spend time on all the good points > > that's nice. First i am not a dev i don't so code ( not that i wouldn't liked but i can't ) i try to submit patches but i can't

Re: Review Request: Enable System Monitor - Network to respond to newly connected network interfaces.

2009-03-10 Thread Shantanu Tushar Jha
The problem is that the dataengine doesn't send a request to KSGRD for new monitors when those signals are emitted. So I had to add this to the dataengine- KSGRD::SensorMgr->sendRequest("localhost", "monitors",(KSGRD::SensorClient*)this, -1); This refreshes the monitors list, which, thankfull

Re: Review Request: Enable System Monitor - Network to respond to newly connected network interfaces.

2009-03-10 Thread Shantanu Tushar Jha
> On 2009-03-10 10:51:03, Chani wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/system-monitor/net.cpp, line 58 > > > > > > this... feels wrong. like there should be a way to do it without adding > > signals to the da

Re: Microblogging using 100% cpu

2009-03-10 Thread Aaron J. Seigo
On Tuesday 10 March 2009, Artur Souza (MoRpHeUz) wrote: > Hi guys, > > I'm in the middle of bossa conference so sorry for not providing a > nice backtrace and debug information. > I was using microblogging applet and sometimes my plasma was eating > 100% of the cpu...after removing it from desk

Re: krunner

2009-03-10 Thread Aaron J. Seigo
On Monday 09 March 2009, David Baron wrote: > Alternative display ideas? Sort/scroll by plugin results? Etc. you are more likely to receive responses if you provide mockups, patches and/or other forms of concrete suggestions. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0

Re: Review of KDE 4.2

2009-03-10 Thread Aaron J. Seigo
On Sunday 08 March 2009, Nicolas Lécureuil wrote: > I won't spend time on all the good points that's nice. > but i would like to speak about > some blocker issues ( i will do bugreports later but i prefer to do this > mail first) > > -1- If user use the folderview ( to have a desktop which looks

Re: Review Request: Enable System Monitor - Network to respond to newly connected network interfaces.

2009-03-10 Thread Petri Damstén
On Tuesday 10 March 2009 19:51:02 Chani wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/246/#review442 > --- > > > > /trunk/KDE/k

Re: Ideas on improving the manual grouping and sorting in the tasks applet

2009-03-10 Thread Aaron J. Seigo
On Sunday 08 March 2009, Christian Mollekopf wrote: > Tell me if you have any better ideas. i like it :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is

Re: How to check if window really was closed?

2009-03-10 Thread Aaron J. Seigo
On Sunday 08 March 2009, Christian Mollekopf wrote: > I was wondering if i should do it with a timeout, so the window gets > activated if not closed within 200ms or so or if there is any better way to > do it. a timer is a bit of a hack, so should only be used in this case as a last resort. prob

Re: Review Request: Comic applet using Plasma::Widgets

2009-03-10 Thread Aaron J. Seigo
On Tuesday 10 March 2009, Matthias Fuchs wrote: > On Dienstag 10 März 2009 16:47:08 Aaron J. Seigo wrote: > > On Friday 06 March 2009, you wrote: > > > > On 2009-03-02 11:46:24, Aaron Seigo wrote: > > > > > looks good... > > > > > > > > > > on a semi-related note, i really think offering a configur

Re: Review Request: add action collection to the corona

2009-03-10 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/268/#review443 --- if I add a function for getting the whole collection... should I expose

Re: Review Request: add action collection to the corona

2009-03-10 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/268/#review441 --- needs some clean ups here and there, but the general direction seems cor

Re: Review Request: Enable System Monitor - Network to respond to newly connected network interfaces.

2009-03-10 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/246/#review442 --- /trunk/KDE/kdebase/workspace/plasma/applets/system-monitor/net.cpp

Re: Review Request: Enable System Monitor - Network to respond to newly connected network interfaces.

2009-03-10 Thread Shantanu Tushar Jha
> On 2009-03-07 09:49:34, Chani wrote: > > Error: The file '/trunk/KDE/kdebase/plasma/applets/system-monitor/net.h' > > (r935835) could not be found in the repository: File not found: revision > > 935835, path '/trunk/KDE/kdebase/plasma/applets/system-monitor/net.h' > > > > it should be kdebas

Re: Microblogging using 100% cpu

2009-03-10 Thread Chani
On March 10, 2009 10:05:51 Artur Souza (MoRpHeUz) wrote: > Hi guys, > > I'm in the middle of bossa conference so sorry for not providing a > nice backtrace and debug information. > I was using microblogging applet and sometimes my plasma was eating > 100% of the cpu...after removing it from des

Re: Notifications Theming

2009-03-10 Thread Aaron J. Seigo
On Friday 06 March 2009, Trever Fischer wrote: > Are there any plans to, erm, extend the Extender class and provide some > custom SVG elements for notifications? Rob's already commented on the animations and current theming system, so i'll skip that bit, but... ... why do we want notifications (

Re: Review of KDE 4.2

2009-03-10 Thread Nicolas Lécureuil
Le Monday 09 March 2009 01:04:36 Nicolas Lécureuil, vous avez écrit : > Hi panel/plasma team, > > Some of our users have done some reviews about kde 4 and i think this can > be usefull to share it with you. > > I won't spend time on all the good points but i would like to speak about > some blocker

Re: Review Request: Comic applet using Plasma::Widgets

2009-03-10 Thread Matthias Fuchs
On Dienstag 10 März 2009 16:47:08 Aaron J. Seigo wrote: > On Friday 06 March 2009, you wrote: > > > On 2009-03-02 11:46:24, Aaron Seigo wrote: > > > > looks good... > > > > > > > > on a semi-related note, i really think offering a configuration > > > > option for the style of arrows is a mistake. t

Re: Review Request: add action collection to the corona

2009-03-10 Thread Chani
> On 2009-03-10 01:54:53, Marco Martin wrote: > > trunk/KDE/kdelibs/plasma/corona.h, line 167 > > > > > > perhaps would be useful an accessor for the whole action collection? > > now from the ui i can call them by name,

Microblogging using 100% cpu

2009-03-10 Thread Artur Souza (MoRpHeUz)
Hi guys, I'm in the middle of bossa conference so sorry for not providing a nice backtrace and debug information. I was using microblogging applet and sometimes my plasma was eating 100% of the cpu...after removing it from desktop, plasma started to behave well again and no "100% eating cpu si

Re: Review Request: add action collection to the corona

2009-03-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/268/#review432 --- trunk/KDE/kdelibs/plasma/corona.h