-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/267/#review439
-----------------------------------------------------------

Ship it!


probably sensible enough :)

- Aaron


On 2009-03-09 09:50:43, Aike J Sommer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/267/
> -----------------------------------------------------------
> 
> (Updated 2009-03-09 09:50:43)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch makes use of the mouse-poll-timer for auto-hide even if no popup 
> is present.
> The reason for this is that on panels that are not on the edge of the whole 
> framebuffer, but have some "dark area" below/above/... them it's almost 
> impossible to exactly hit the trigger-area. With a little app i wrote its 
> possible to "bounce" the mouse-pointer back out of the "dark area", but this 
> creates mouse-leave events in plasma first before the pointer comes back 
> after a few ms.
> The patch also makes sure new panels actually get the size for the screen 
> they are created for.
> 
> 
> This addresses bug 178066.
>     https://bugs.kde.org/show_bug.cgi?id=178066
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.cpp 937003 
> 
> Diff: http://reviewboard.kde.org/r/267/diff
> 
> 
> Testing
> -------
> 
> Tried with multiple auto-hide (and normal) panels on different locations and 
> they all hide/unhide as they should.
> Also created and removed a couple panels on both screens, all get the right 
> size.
> 
> 
> Thanks,
> 
> Aike J
> 
>

_______________________________________________
Plasma-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to