Re: unitconverter applet moved to kdereview

2009-02-25 Thread Petri Damstén
On Friday 06 February 2009 13:46:02 Petri Damstén wrote: > Hi, > > I moved unitconverter applet to kdereview. It now uses the same conversion > lib that converter runner does, but some might like to do their conversions > in an applet. unitconverter has now been in kdereview for two weeks. ok to m

Re: [patch] fix crasher in applethandle

2009-02-25 Thread Sebastian Kügler
On Monday 23 February 2009 01:59:39 Sebastian Kügler wrote: > Can somebody quickly review this patch? > > I'm dragging data from an applet (emailmessage in this case) onto the > desktop, a note is created, clicking on its applet handle makes > plasmoidviewer crash (bt attached). I've played around

Re: Review Request: Comic applet using Plasma::Widgets

2009-02-25 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/145/ --- (Updated 2009-02-25 13:30:49.350947) Review request for Plasma. Changes ---

Review Request: qwidget for monitor previews

2009-02-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/187/ --- Review request for Plasma. Summary --- it's a qwidget that rapresent the mon

Re: Plasma themed tabbox

2009-02-25 Thread Marco Martin
On Tuesday 24 February 2009, Martin Gräßlin wrote: > I worked on Plasma themeing the normal tabbox (without effects). So far > everything seems to work ;-) > > As this is my first work on anything related to QGraphicsView/Plasma I > cc-ed Plasma devs. Please have a look at the patch and tell me wha

Re: Plasma themed tabbox

2009-02-25 Thread Sebastian Kügler
On Tuesday 24 February 2009 12:20:06 Martin Gräßlin wrote: > I worked on Plasma themeing the normal tabbox (without effects). So far > everything seems to work ;-) > > As this is my first work on anything related to QGraphicsView/Plasma I > cc-ed Plasma devs. Please have a look at the patch and tel

Re: plasma-desktop not automatically started in trunk

2009-02-25 Thread Andreas Pakulat
On 25.02.09 17:37:04, Andreas Pakulat wrote: > Hi, > > it seems that recent trunk doesn't auto start plasma-desktop anymore, at > least here it doesn't. My build is probably about 2 days old, so if I just > need to svn up ignore this mail as I'm going to do that later tonight. > > In the case I'm

plasma-desktop not automatically started in trunk

2009-02-25 Thread Andreas Pakulat
Hi, it seems that recent trunk doesn't auto start plasma-desktop anymore, at least here it doesn't. My build is probably about 2 days old, so if I just need to svn up ignore this mail as I'm going to do that later tonight. In the case I'm not alone with this: How should I debug whats going wrong?

Re: Fun with Akonadi Dataeng

2009-02-25 Thread David Baron
Any progress on the akonadi engine? (I have been offline a few days because I l lost my geforce). Last svn I took crashed the engine-explorer and my applet so I doubt it is my code. Could it be that dataUpdated() was being exercised with invalid or null data? Since the receives Plasma::DataEngi

Re: Review Request: Comic applet using Plasma::Widgets

2009-02-25 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/145/ --- (Updated 2009-02-25 04:36:47.924343) Review request for Plasma. Summary ---

Re: Review Request: Comic applet using Plasma::Widgets

2009-02-25 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/145/ --- (Updated 2009-02-25 04:34:58.634432) Review request for Plasma. Changes ---

Re: Review Request: Comic applet using Plasma::Widgets

2009-02-25 Thread Matthias Fuchs
> On 2009-02-21 08:43:04, Aaron Seigo wrote: > > KDE/kdeplasma-addons/applets/comic/imagewidget.cpp, line 29 > > > > > > this should probably have setCacheMode(DeviceCoordinateCache) set on it > > for performance purposes. So

Re: How to adjust applet size according to its child QGraphicsWidget?

2009-02-25 Thread Alexis Ménard
Ok, I found the problem. Nowhere you set the size of MyGraphicsWidget, so the layout can't know about its size, and more you never set the preferredSize so it use the default which is arbitrary small. Take a look on the doc for setPreferredSize, setMinimumSize, setMaximumSize and the overload of s

Re: How to adjust applet size according to its child QGraphicsWidget?

2009-02-25 Thread Petri Damstén
On Wednesday 25 February 2009 12:05:52 Dong Tiger wrote: > 2008/12/30 Alexis Ménard > > > Unfortunately you can't it is a bug in Qt. > > > > You can take a look to the task tracker of Qt Number 231114 and 211500. I > > guess it is what you try to solve. The fix is in 4.4 branch (so scheduled > > f

Re: Review Request: Let PopupApplet show BusyWidget in popup

2009-02-25 Thread Artur de Souza (MoRpHeUz)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/177/#review263 --- /trunk/KDE/kdelibs/plasma/applet.cpp

Re: How to adjust applet size according to its child QGraphicsWidget?

2009-02-25 Thread Dong Tiger
2008/12/30 Alexis Ménard > Unfortunately you can't it is a bug in Qt. > > You can take a look to the task tracker of Qt Number 231114 and 211500. I > guess it is what you try to solve. The fix is in 4.4 branch (so scheduled > for 4.4.4) and in 4.5. I still can't get this work even with latest Q

Re: Review Request: Let PopupApplet show BusyWidget in popup

2009-02-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/177/#review260 --- that's a god thing. however, does it react to applet resize when is in a