Re: Plasma Applet Direction

2009-01-24 Thread Riccardo Iaconelli
On Friday 16 January 2009 16:56:30 Aaron J. Seigo wrote: > anything else? Maybe we can add screensaver config? That's not really plasma, but I tend to see most users looking at the desktop config when looking for it... Bye, -Riccardo -- GPG key: 3D0F6376 When encrypting, please encrypt also fo

Re: Review Request: Unhide Panel when TaskManager's Task requests attention

2009-01-24 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/342/#review342 --- i don't like emitActivate either as it says what the code does rat

Re: Review Request: Plasma::IconWidget::removeIconAction(QAction*) method add request.

2009-01-24 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/343/#review341 --- Ship it! looks fine; btw, you can also just delete the QAction, t

Re: Making paths case insensitive in krunner

2009-01-24 Thread Aaron J. Seigo
On Saturday 24 January 2009, Diaa Sami wrote: > Any comments about the patch? sorry; i tend to lose patches like that in mailing list. which is why we have the review board (http://reviewboard.vidsolbach.de/) ... anyways ... the patch looks alright. there are probably some opportunities for some

Re: Review Request: ConstrainedSquare aspect for Notes in the panel

2009-01-24 Thread Artur Souza (MoRpHeUz)
On Sat, Jan 24, 2009 at 4:18 PM, Alessandro Diaferia wrote: > I feel the Notes applet is way nicer in the panel with this little change.. > anyway i wait for your thoughts about this :) > Yeah, this makes the applet looks much nicer inside a panel =) Cheers! -- ---

Review Request: ConstrainedSquare aspect for Notes in the panel

2009-01-24 Thread Alessandro Diaferia
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/344/ --- Review request for Plasma. Summary --- I feel the Notes applet is way

Re: Review Request: Plasma::IconWidget::removeIconAction(QAction*) method add request.

2009-01-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/343/#review340 --- to me a method like this seems sensible, since it's an api change

Re: Review Request: Unhide Panel when TaskManager's Task requests attention

2009-01-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/342/#review339 --- Ship it! seems straightforward, maybe i would call emitActivate()

Review Request: Plasma::IconWidget::removeIconAction(QAction*) method add request.

2009-01-24 Thread Alessandro Diaferia
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/343/ --- Review request for Plasma. Summary --- Yo guys, it's been a looong tim

Review Request: Unhide Panel when TaskManager's Task requests attention

2009-01-24 Thread Diaa Sami
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/342/ --- Review request for Plasma. Summary --- Unhides Panel(s) containing a T

Re: Making paths case insensitive in krunner

2009-01-24 Thread Diaa Sami
Any comments about the patch? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Auto unhide panel when stuff in it gets activated

2009-01-24 Thread Marco Martin
> On 2009-01-23 08:24:52, Aaron Seigo wrote: > > > > Diaa Sami wrote: > May be I'm missing something but there are some problems with this code, > The major problem for me is that Containment doesn't have an activate() > signal, so when I emit applet->activate() nothing happens ... > O