----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/342/ -----------------------------------------------------------
Review request for Plasma. Summary ------- Unhides Panel(s) containing a TaskManager when a task requests attention, this was done by emitting the Applet's activate() signal(and since AbstractTaskItem is not a friend, I had to make the public method emitActivate()). I noticed that AbstractTaskItem::setTaskFlags(TaskWantsAttention) is called twice, is there a reason for this? it's not likely to cause problems but I'm just curious. Diffs ----- /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp /trunk/KDE/kdelibs/plasma/applet.h /trunk/KDE/kdelibs/plasma/applet.cpp Diff: http://reviewboard.vidsolbach.de/r/342/diff Testing ------- basic testing only to make sure it works as intended Thanks, Diaa _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
