Re: [PATCH] fix for 8 krazy2 issues

On Thursday 15 January 2009, Bruno Bigras wrote: > Alex Merry a écrit : > > These all look fine. Have you visually checked the results of the > > changes in 6_qclasses.diff? > > > > Do you have an SVN account in order to commit these? > > I only tested with the viewer and compiled. > > I don't hav

Re: FrameSvg corruption [a bit urgent]

On Thursday 15 January 2009, Ivan Čukić wrote: > The patch hasn't made any changes for me (not for better, nor worse) ok.. on the one hand, too bad. on the other hand, it's more correct so it not breaking it more is a good thing. > > which would result in checking the svg on every invalid entry,

Re: FrameSvg corruption [a bit urgent]

The patch hasn't made any changes for me (not for better, nor worse) > which would result in checking the svg on every invalid entry, which would > in turn cause the creation of the QSvgRenderer. that would completely ruin Yes it would, but I can not find where is the problem with caching. (althou

Re: FrameSvg corruption [a bit urgent]

On Thursday 15 January 2009, Ivan Čukić wrote: > Which doesn't describe its behavior. With the proposed change, it would. > 1. Check cache, if we have valid cached element, then the element exists > 2. If we don't have it in the cache, then we check the Svg directly which would result in checking

Re: FrameSvg corruption [a bit urgent]

On Thursday 15 January 2009, Ivan Čukić wrote: > > ah, so either we need to special case non-existing elements a bit better > > or just require that svg's don't have 0x0 elements in them. > > The problem is that the element in question is *not* 0x0. > > As I said, the first time the setElementPrefi

Re: FrameSvg corruption [a bit urgent]

> because if it is found, then we don't want to re-look it up in the svg. no? But the problem is that it is not loaded from the cache properly, but exists in the file, and hasElement() returns false, because it thinks that the cache holds the element, and if it has it at all, it is corrupted. T

Re: FrameSvg corruption [a bit urgent]

> ah, so either we need to special case non-existing elements a bit better or > just require that svg's don't have 0x0 elements in them. The problem is that the element in question is *not* 0x0. As I said, the first time the setElementPrefix (and thus the hasElement) is called, it works ok, but

Re: [PATCH] fix for 8 krazy2 issues

Alex Merry a écrit : > > These all look fine. Have you visually checked the results of the changes in > 6_qclasses.diff? > > Do you have an SVN account in order to commit these? > I only tested with the viewer and compiled. I don't have an SVN account, it would be nice if you could commit it

Re: Plasma Applet Direction

On Thursday 15 January 2009, Jud Craft wrote: > Well, true. I suppose the only reservation is that such solutions > like the Google Gadget/iPhone software stores require the development > of a supported software delivery system, that I think should not be > outsourced to a third party website. t

Re: [PATCH] fix for 8 krazy2 issues

On Thursday 15 January 2009, Alex Merry wrote: > These all look fine. Have you visually checked the results of the changes > in 6_qclasses.diff? should all be safe enough; all those classes are just the Q* classes with some extra sugar on top. -- Aaron J. Seigo humru othro a kohnu se GPG Finge

Re: Plasma Applet Direction

Well, true. I suppose the only reservation is that such solutions like the Google Gadget/iPhone software stores require the development of a supported software delivery system, that I think should not be outsourced to a third party website. And that takes a lot of planning and resources - KDE can

Re: [PATCH] fix for 8 krazy2 issues

On Thursday 15 January 2009 22:25:51 Bruno Bigras wrote: > Have a special look at 6_qclasses.diff, I tested everything I could with > plasmoidviewer but some changes may be in code not used (yet). > > Fix issues with the same name as the patch (without the number). > http://englishbreakfastnetwork.

Re: [Kourse 3] Fixing krazy2 issues

On Thursday 15 January 2009, Philipp Klaffert wrote: > I've now swapped all the Strings with constants and so, just 3 objects an > no more krazy complaining for at least these issues. great; ready to commit! =)) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA

[PATCH] fix for 8 krazy2 issues

Have a special look at 6_qclasses.diff, I tested everything I could with plasmoidviewer but some changes may be in code not used (yet). Fix issues with the same name as the patch (without the number). http://englishbreakfastnetwork.org/krazy/reports/kde-4.x/kdeplasma-addons/applets/index.html app

Re: FrameSvg corruption [a bit urgent]

On Thursday 15 January 2009, Alexis Ménard wrote: > I noticed some artifacts too in my case on the task manager. I will try > lancelot. > > The problem appears quite recently since the big move with the caching big > work. I guess it was my Nvidia driver that were crap(as usually) but not > sure no

Re: FrameSvg corruption [a bit urgent]

On Thursday 15 January 2009, Ivan Čukić wrote: > The line > > bool found = Theme::defaultTheme()->findInRectsCache(d->path, id, > elementRect); > > returns true, but the elementRect is invalid 0x0, so the hasElement returns > false. aaah, yeah, that function when returns true and the rect is inval

Re: FrameSvg corruption [a bit urgent]

I noticed some artifacts too in my case on the task manager. I will try lancelot. The problem appears quite recently since the big move with the caching big work. I guess it was my Nvidia driver that were crap(as usually) but not sure now. On my laptop everything works fine so... 2009/1/15 Aaron

Re: FrameSvg corruption [a bit urgent]

On Thursday 15 January 2009, Ivan Čukić wrote: > The line > > bool found = Theme::defaultTheme()->findInRectsCache(d->path, id, > elementRect); > > returns true, but the elementRect is invalid 0x0, so the hasElement returns > false. ah, so either we need to special case non-existing elements a bit

Re: FrameSvg corruption [a bit urgent]

On Thursday 15 January 2009, Ivan Čukić wrote: > p.s. Why don't we call the /not found/ branch when the rectangle is not > valid? > > Something like: > if (found && elementRect.isValid()) { > return true; > } else { > d->findAndCacheElementRect(elementId); > return d

Re: Plasma Applet Direction

On Thursday 15 January 2009, Jud Craft wrote: > I do really like the platform-independence and compilation-free > packages! I had neglected those; that's awesome, so the picture is > much less depressing than my post says. > > Plasma themes themselves are also independent, correct? (Assumption >

Re: FrameSvg corruption [a bit urgent]

p.s. Why don't we call the /not found/ branch when the rectangle is not valid? Something like: if (found && elementRect.isValid()) { return true; } else { d->findAndCacheElementRect(elementId); return d->renderer->elementExists(elementId); } -- Those people w

Re: FrameSvg corruption [a bit urgent]

The line bool found = Theme::defaultTheme()->findInRectsCache(d->path, id, elementRect); returns true, but the elementRect is invalid 0x0, so the hasElement returns false. When I change found to be false always, everything works as it used before - no problems... Cheerio -- A positive atti

Re: [Kourse 3] Fixing krazy2 issues

Am 15. Januar 2009 17:39 schrieb Aaron J. Seigo : > On Thursday 15 January 2009, Philipp Klaffert wrote: > > thanks for your reply and for the link. For fixing the krazy2 issues > > correctly I changed QString to QLatin1String. I understand your point of > > view with "readability" but I won't dec

Review Request: a messagebox for applets

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/327/ --- Review request for Plasma. Summary --- this adds Applet::setMessage("i

Re: Tokamak Meeting II

A Thursday 15 January 2009 19:25:29, Artur Souza(MoRpHeUz) escreveu: > On Thursday 15 January 2009 17:03:26 Anne-Marie Mahfouf wrote: > > > fristly confirmation for the people coming. > > I'm all in =P > > > Kévin (ervin) and me will be arriving at 9:05 am at OPO the 6th. What > > time are these p

Re: Tokamak Meeting II

A Thursday 15 January 2009 20:03:26, Anne-Marie Mahfouf escreveu: > Le jeudi 15 janvier 2009 17:47:30, Nuno Pinheiro a écrit : > > hey everybody > > > > IM planing the tokamak meeting details. > > So I need some infos from everyone coming to the meeting... > > So We can produce a schedule for the d

Re: Tokamak Meeting II

On Thursday 15 January 2009 17:03:26 Anne-Marie Mahfouf wrote: > > fristly confirmation for the people coming. I'm all in =P > Kévin (ervin) and me will be arriving at 9:05 am at OPO the 6th. What time > are these presentations scheduled ? How long do we need to get from the > airport to the mee

Re: FrameSvg corruption [a bit urgent]

On Thursday 15 January 2009, Ivan Čukić wrote: > More strange things. > > I've added a couple of debug lines to framesvg.cpp, and I'm receiving this > in setElementPrefix: > > First call of setElementPrefix on the same FrameSvg object: > > ### setElementPrefix: /opt/kde4trunk/kde/share/apps/desktop

Re: Tokamak Meeting II

Le jeudi 15 janvier 2009 17:47:30, Nuno Pinheiro a écrit : > hey everybody > > IM planing the tokamak meeting details. > So I need some infos from everyone coming to the meeting... > So We can produce a schedule for the days we will be there, sort out all > details for credentials and stuf. > > fri

Re: Plasma Applet Direction

I do really like the platform-independence and compilation-free packages! I had neglected those; that's awesome, so the picture is much less depressing than my post says. Plasma themes themselves are also independent, correct? (Assumption based on hearing efforts to port Plasma to Windows). Wha

Re: Tokamak Meeting II

On Thursday 15 January 2009, Nuno Pinheiro wrote: > hey everybody > > IM planing the tokamak meeting details. > So I need some infos from everyone coming to the meeting... > So We can produce a schedule for the days we will be there, sort out all > details for credentials and stuf. > > fristly conf

Re: My progress

On Wednesday 14 January 2009, Aaron J. Seigo wrote: > On Wednesday 14 January 2009, Marco Martin wrote: > > On Wednesday 14 January 2009, Aaron J. Seigo wrote: > > > On Wednesday 14 January 2009, Marco Martin wrote: > > > > On Tuesday 13 January 2009, Aaron J. Seigo wrote: > > > > > this would prob

Re: Plasma Applet Direction

On Thursday 15 January 2009, Jud Craft wrote: > "we (plasma team) don't actually control that =)" > > There really does need to be a pervasive integration of all aspects of > the user-experience with plasma. Get Hot New Stuff is an interesting > compromise, but at the moment it seems a strange klu

Re: Tokamak Meeting II

A Thursday 15 January 2009 17:07:26, Aaron J. Seigo escreveu: > On Thursday 15 January 2009, Nuno Pinheiro wrote: > > fristly confirmation for the people coming. > > shockingly, i'll be there ;) > > > Secondly I asked several people already to prepare a litle presentation > > to give on the 6. (ca

Re: Plasma Applet Direction

"we (plasma team) don't actually control that =)" There really does need to be a pervasive integration of all aspects of the user-experience with plasma. Get Hot New Stuff is an interesting compromise, but at the moment it seems a strange klutch, which stands in the way of implementing a much mor

Re: Tokamak Meeting II

On Thursday 15 January 2009, Nuno Pinheiro wrote: > fristly confirmation for the people coming. shockingly, i'll be there ;) > Secondly I asked several people already to prepare a litle presentation to > give on the 6. (can be about anything as long as its plasma related, i > think a small prese

Tokamak Meeting II

hey everybody IM planing the tokamak meeting details. So I need some infos from everyone coming to the meeting... So We can produce a schedule for the days we will be there, sort out all details for credentials and stuf. fristly confirmation for the people coming. Secondly I asked several peop

Re: [Kourse 3] Fixing krazy2 issues

On Thursday 15 January 2009, Philipp Klaffert wrote: > thanks for your reply and for the link. For fixing the krazy2 issues > correctly I changed QString to QLatin1String. I understand your point of > view with "readability" but I won't decide which way is better. I think the > explicit conversion

Re: FrameSvg corruption [a bit urgent]

More strange things. I've added a couple of debug lines to framesvg.cpp, and I'm receiving this in setElementPrefix: First call of setElementPrefix on the same FrameSvg object: ### setElementPrefix: /opt/kde4trunk/kde/share/apps/desktoptheme/slim- glow/lancelot/section-buttons.svgz prefix: 'che

Re: [Kourse 3] Fixing krazy2 issues

Hi Dominik, thanks for your reply and for the link. For fixing the krazy2 issues correctly I changed QString to QLatin1String. I understand your point of view with "readability" but I won't decide which way is better. I think the explicit conversion of these Strings makes the understanding of the

Re: [Kourse 3] Fixing krazy2 issues

Hi Philipp, On Thursday 15 January 2009, Philipp Klaffert wrote: > @@ -54,7 +53,7 @@ > return true; > } > > -if (!name.startsWith("Timeline:") && > !name.startsWith("TimelineWithFriends:") && > !name.startsWith("Profile:")) { > +if > (!name.startsWith(QString("Timeline:"))

RE: [Kourse 3] Fixing krazy2 issues

> Hey > 2009/1/15 Philipp Klaffert >: >*> license and copyright issues and you can find the patch in the attachement *>*> of this Mail. * > I think you forgot to attach the patch hehe =) > Cheers and I think you are right... :) Index: dataengi

[PATCH] fixing krazy2 issues in "dataengines"

Hi, according to the Kourse on kde.org [1] I fixed some of the issues in "kdeplasma-addons/dataengines" found on EBN. The only issues left are the license and copyright issues and you can find the patch in the attachement of this Mail. Regards Philipp Klaffert [1] http://forum.kde.org/-kourse-3-

Re: [PATCH] fixing krazy2 issues in "dataengines"

Hey 2009/1/15 Philipp Klaffert : > license and copyright issues and you can find the patch in the attachement > of this Mail. I think you forgot to attach the patch hehe =) Cheers -- --- Artur Duque de Souza OpenBossa Research Labs INdT - Ins

FrameSvg corruption [a bit urgent]

Hi guys, I have a problem affecting both 4.2 branch and the trunk. I'm getting corrupted painting of FrameSvgs in Lancelot and have absolutely no idea why. I became aware of the problem thanks to the forum post [1] and the screenshot [2]. It all worked well for me until I cleared the plasma-sv