tasks-refactor issues

2008-09-22 Thread Aaron J. Seigo
hi ... so i've been playing with tasks-refactor now for a bit and here's a list of issues i've come across: smaller things that can be fixed easier: * the config dialog is .. well .. reversed =) the labels are on the right and the controls on the left. the dialog must be reworked to be HIG com

Re: libtaskmanager

2008-09-22 Thread Aaron J. Seigo
On Sunday 21 September 2008, Christian Mollekopf wrote: > I would say we should really take the new widget since i don't think we can > just shortly add some grouping functions to the old widget. it really wouldn't be that much work if we keep it simple and e.g. mimic what we had in kicker (colla

Re: playground/base/plasma/applets/systray-refactor/protocols/plasmoid

2008-09-22 Thread Aaron J. Seigo
On Monday 22 September 2008, Jason Stubbs wrote: > Hmm.. Actually, asking the Task object for a widget of a certain > orientation should be enough. eg. task->widget(Qt::Horizontal) or Plasma::Horizontal =) > > personally, i think it makes more sense to have each tray simply have > > it's own coll

Re: playground/base/plasma/applets/systray-refactor/protocols/plasmoid

2008-09-22 Thread Jason Stubbs
Aaron J. Seigo wrote: > On Saturday 20 September 2008, Sebastian Kügler wrote: The applets should also be told about the formfactor by the systray applet >>> > (I think horizontal makes sense in almost all cases). >>> >>> This will require SystemTray::Task to return something other

RE: libtaskmanager

2008-09-22 Thread christian mollekopf
sorry, i forgot to upload the changes. it should compile now.Regards> From: [EMAIL PROTECTED]> To: plasma-devel@kde.org> Subject: Re: libtaskmanager> Date: Mon, 22 Sep 2008 22:24:43 +0200> > On Sunday 21 September 2008, Christian Mollekopf wrote:> > Hi,> >> > I would say we should really take th

Re: libtaskmanager

2008-09-22 Thread Marco Martin
On Sunday 21 September 2008, Christian Mollekopf wrote: > Hi, > > I would say we should really take the new widget since i don't think we can > just shortly add some grouping functions to the old widget. The new widget > actually worked quite well, but now i introduced some new problemes while > tu

Re: Code defects in Plasma

2008-09-22 Thread Aaron J. Seigo
On Monday 22 September 2008, Ivan Čukić wrote: > > - amarok/src/context/plasma/animator.cpp:291 > > Division by 0 if frames < 3 > > issue1.diff attached hm.. i'm not even sure that '/ 3' is really needed anymore at all. or the '/ 5' elsewhere as well.. i think it actually should be: qMax(1, fram

Re: Code defects in Plasma

2008-09-22 Thread Alex Merry
On Monday 22 September 2008 11:40:14 Ivan Čukić wrote: > > - amarok/src/context/plasma/animator.cpp:291 > > Division by 0 if frames < 3 > > issue1.diff attached No-brainer. > > > - amarok/src/context/plasma/containment.cpp:991 > > Line 986 indicates that focusedApplet can be NULL. But focusedAppl

Re: Wanted: Name for current KRunner Interface

2008-09-22 Thread Aaron J. Seigo
On Sunday 21 September 2008, Ryan P. Bitanga wrote: > I was thinking of beginning QuickSand integration with KRunner within > the week and I think it would be great if someone came up with a name > for the current KRunner interface. Any ideas? :) erm .. KRunner? =) if you're looking for use visibl

Re: painting suggestions

2008-09-22 Thread Aaron J. Seigo
On Sunday 21 September 2008, Riccardo Iaconelli wrote: > On Monday 22 September 2008 02:04:04 Robert Knight wrote: > > Fredrik has answered this one on techbase: > > > > http://techbase.kde.org/Development/Tutorials/Graphics/Performance#QPaint > >er > > > >::setOpacity.28.29 > > This changes the op

Re: playground/base/plasma/applets/systray-refactor/protocols/plasmoid

2008-09-22 Thread Aaron J. Seigo
On Saturday 20 September 2008, Sebastian Kügler wrote: > > > The applets should also be told about the formfactor by the systray > > > applet > > > > > > (I think horizontal makes sense in almost all cases). > > > > This will require SystemTray::Task to return something other than a > > QGraphicsW

Re: webkit plasmoids

2008-09-22 Thread Aaron J. Seigo
On Saturday 20 September 2008, Petri Damstén wrote: > On Saturday 20 September 2008 17:51:31 Petri Damstén wrote: > > On Friday 19 September 2008 16:16:16 Aaron J. Seigo wrote: > > > > (or perhaps some other solution)? > > > > > > let me look at kconfigskeleton today... > > > > Would this be too bi

Re: Review Request: Multiple action support for KRunner

2008-09-22 Thread Aaron J. Seigo
On Sunday 21 September 2008, Ryan P. Bitanga wrote: > 2008/9/20 Aaron J. Seigo <[EMAIL PROTECTED]>: > > On Thursday 18 September 2008, you wrote: > >> > On 2008-09-17 08:34:10, Aaron Seigo wrote: > >> Well, QueryActionPool provides an easy means to determine whether or not > >> an action was create

RE: SIGSEGV on exiting Plasma app

2008-09-22 Thread Ambrus, Oszkar
Thanks! It's working quite well now. Oszkar -Original Message- From: Alex Merry [mailto:[EMAIL PROTECTED] Sent: Sun 9/21/2008 8:09 PM To: plasma-devel@kde.org Subject: Re: SIGSEGV on exiting Plasma app Not necessarily. Any QGraphicsItem on the scene is deleted by ~QGraphicScene. I

Re: Code defects in Plasma

2008-09-22 Thread Ivan Čukić
> - amarok/src/context/plasma/animator.cpp:291 > Division by 0 if frames < 3 issue1.diff attached > - amarok/src/context/plasma/containment.cpp:991 > Line 986 indicates that focusedApplet can be NULL. But focusedApplet is > equal to applet. Therefore applet can be NULL here. This is in Containmen

Code defects in Plasma

2008-09-22 Thread Mark Kretschmann
Hey guys, a friendly person sent us a code defect analysis for Amarok (created by an internal IBM tool). As we also import libplasma in Amarok 2, these two defects were revealed: - amarok/src/context/plasma/animator.cpp:291 Division by 0 if frames < 3 - amarok/src/context/plasma/containment.cpp:

Re: Weather plasmoid development

2008-09-22 Thread Shawn Starr
On Tuesday 16 September 2008 20:05:53 Edwin de Jong wrote: > Hi everyone, (cross-posting to plasma-devel and kde-artists) >> > In the coming days I'll be busy with the weather plasmoid. I already > overhauled quite a lot of the code, recreated the configuration GUI, made > it dockable in the panels