Re: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/#review929 --- Ship it! - Boroondas On July 25, 2011, 1:51 p.m., Vadim Product

Re: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/ --- (Updated July 25, 2011, 1:51 p.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

> On July 25, 2011, 10:44 a.m., Boroondas Gupte wrote: > > indra/newview/llviewerregion.h, line 195 > > > > > > Can (and maybe should) be made private now. I don't think any other > > class has a valid reason to use t

Re: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

> On July 25, 2011, 10:44 a.m., Boroondas Gupte wrote: > > indra/newview/llfloaterland.cpp, lines 2885-2886 > > > > > > Is it save to remove this NULL-check? AFAIK getChild<...>() can fail. Yes. getChild() never retu

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

> On July 25, 2011, 10:04 a.m., Boroondas Gupte wrote: > > > It's up to the translation team to remove obsolete translations. > > > > In that case, no further concerns. Should we file a jira issue to make the > > translation team aware of the obsolete elements? Not sure whether it makes sense.

Re: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/#review925 --- indra/newview/llfloaterland.cpp

Re: [opensource-dev] Review Request: STORM-1233 Untranslated Profile button in the Places panel

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/415/#review924 --- Ship it! - Boroondas On July 25, 2011, 9:54 a.m., Vadim Product

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/#review923 --- Ship it! > It's up to the translation team to remove obsolete tra

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

> On July 25, 2011, 9:59 a.m., Boroondas Gupte wrote: > > indra/newview/skins/minimal/xui/da/panel_people.xml, lines 75-77 > > > > > > share_btn doesn't occur (yet?/anymore?) in the English original, so I > > think it

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/#review920 --- indra/newview/skins/minimal/xui/da/panel_people.xml

Re: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane

> On July 25, 2011, 7:50 a.m., Vadim ProductEngine wrote: > > indra/newview/skins/minimal/xui/da/panel_people.xml, line 69 > > > > > > Missing rename here. > > Boroondas Gupte wrote: > For some reason I thought STO

[opensource-dev] Review Request: STORM-1233 Untranslated Profile button in the Places panel

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/415/ --- Review request for Viewer. Summary --- Made the button translatable by

Re: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane

> On July 25, 2011, 7:50 a.m., Vadim ProductEngine wrote: > > indra/newview/skins/minimal/xui/da/panel_people.xml, line 69 > > > > > > Missing rename here. For some reason I thought STORM-1403 was only about the "My Fr

Re: [opensource-dev] Review Request: STORM-1311 Place Profile only shows 2 lines and users have to click More link to see full description

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/409/#review918 --- Ship it! Looks good to me. - Seth On July 22, 2011, 7:42 a.m.,

Re: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/#review917 --- Rejecting this fix in favor of a duplicate (but I think better) on

[opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/ --- Review request for Viewer. Summary --- Localized sim product name (e.g

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/#review916 --- Ship it! Looks like a duplicate of https://codereview.secondlife.

[opensource-dev] Review Request: STORM-565 llGiveInventory window is suppressed if avatar in Busy mode

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/413/ --- Review request for Viewer. Summary --- Allow inventory offers from obj