> On July 25, 2011, 10:44 a.m., Boroondas Gupte wrote: > > indra/newview/llfloaterland.cpp, lines 2885-2886 > > <http://codereview.secondlife.com/r/414/diff/2/?file=6756#file6756line2885> > > > > Is it save to remove this NULL-check? AFAIK getChild<...>() can fail.
Yes. getChild() never returns NULL: if the view is not found, a dummy widget is created and returned. > On July 25, 2011, 10:44 a.m., Boroondas Gupte wrote: > > indra/newview/llviewerregion.h, line 195 > > <http://codereview.secondlife.com/r/414/diff/2/?file=6759#file6759line195> > > > > Can (and maybe should) be made private now. I don't think any other > > class has a valid reason to use the unlocalized name. > > > > Or just remove it, and use directly use mProductName in > > getLocalizedSimProductName(). I can do it if you insist. However, I'm not sure that the sim product name is completely useless without translation. There is lots of stuff in the viewer not directly related to UI. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/#review925 ----------------------------------------------------------- On July 25, 2011, 7:36 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/414/ > ----------------------------------------------------------- > > (Updated July 25, 2011, 7:36 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Localized sim product name (e.g. "Estate / Full Region") everywhere. > > > This addresses bug STORM-1220. > http://jira.secondlife.com/browse/STORM-1220 > > > Diffs > ----- > > indra/newview/llfloaterbuyland.cpp UNKNOWN > indra/newview/llfloaterland.cpp UNKNOWN > indra/newview/llfloaterregioninfo.cpp UNKNOWN > indra/newview/llpanelplaceprofile.cpp UNKNOWN > indra/newview/llviewerregion.h UNKNOWN > indra/newview/llviewerregion.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/414/diff > > > Testing > ------- > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
