Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-22 Thread via GitHub
Chealer commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1609789697 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,52 @@ = Manual -== Welcome to Log4j! - -Almost every large application includ

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1609795346 ## src/site/antora/modules/ROOT/examples/manual/markers/log4j2.xml: ## @@ -15,25 +15,29 @@ ~ See the License for the specific language governing permissions

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-22 Thread via GitHub
Chealer commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1609800039 ## src/site/antora/modules/ROOT/partials/log4j-features.adoc: ## @@ -0,0 +1,47 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-22 Thread via GitHub
Chealer commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1609806030 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,52 @@ = Manual -== Welcome to Log4j! - -Almost every large application includ

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-22 Thread via GitHub
Chealer commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1609806030 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,52 @@ = Manual -== Welcome to Log4j! - -Almost every large application includ

Re: [PR] Bump log4j-docgen.version from 0.8.0 to 0.9.0 (logging-log4j2)

2024-05-22 Thread via GitHub
github-actions[bot] merged PR #2579: URL: https://github.com/apache/logging-log4j2/pull/2579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] Improve `api.adoc` et al. (logging-log4j2)

2024-05-22 Thread via GitHub
vy opened a new pull request, #2604: URL: https://github.com/apache/logging-log4j2/pull/2604 Fixes following tickets: - #2535 - #1460 - #1918 ### Reviewer notes * Reviewers are recommended to checkout the branch locally, build, and view it. * Except trivial typo/gr

Re: [PR] Improve `api.adoc` et al. (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz commented on code in PR #2604: URL: https://github.com/apache/logging-log4j2/pull/2604#discussion_r1610040517 ## src/site/antora/modules/ROOT/partials/manual/api-intro.adoc: ## @@ -0,0 +1,72 @@ + +Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-22 Thread via GitHub
rgoers commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2124969306 Question: With the changes I recently made are these alternative implementations really of value to anything? The primary motivation for them seemed to be to reduce the number of g

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-22 Thread via GitHub
jengebr commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2125135528 > Question: With the changes I recently made are these alternative implementations really of value to anything? The primary motivation for them seemed to be to reduce the number of

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-22 Thread via GitHub
rgoers commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-212514 @jengebr ThreadContextDataInjector was doing all the copying into the LogEvent by making a copy of the current ThreadContextMap and then passing that copy so the fields could be inc

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-22 Thread via GitHub
jengebr commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2125164934 @rgoers thank you for explaining. Unfortunately I support several applications that rely on CloseableThreadContext to track short-lived context, and those operations trigger copie

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-22 Thread via GitHub
rgoers commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2125235668 @jengebr I would suggest you look at ScopedContext that I recently added to Log4j-API. It is a much better way to manage a short-lived context. -- This is an automated message fro

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-22 Thread via GitHub
jengebr commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2125341002 I agree that it looks good, but the current api meets our needs, especially once perf improves via `StringArrayThreadContextMap`. There's no upside to modifying our existing appli

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-22 Thread via GitHub
grobmeier merged PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-22 Thread via GitHub
rgoers commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2125395381 @jengebr Thanks. I personally would love your feedback on ScopedContext and if there is anything it might be missing that would make it easier to support your use case. I would gen

Re: [I] Revamp the manual introduction (logging-log4j2)

2024-05-22 Thread via GitHub
grobmeier commented on issue #1468: URL: https://github.com/apache/logging-log4j2/issues/1468#issuecomment-2125447811 Port to 3.x: ca978bfcc71ee8303bd7c0e32ce44257a22515dc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-22 Thread via GitHub
grobmeier commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1610609691 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,52 @@ = Manual -== Welcome to Log4j! - -Almost every large application incl

Re: [PR] Bump org.springframework:spring-framework-bom from 6.1.7 to 6.1.8 [logging-log4j-jakarta]

2024-05-22 Thread via GitHub
github-actions[bot] merged PR #32: URL: https://github.com/apache/logging-log4j-jakarta/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.15 to 1.14.16 [logging-log4j-samples]

2024-05-22 Thread via GitHub
github-actions[bot] merged PR #142: URL: https://github.com/apache/logging-log4j-samples/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-23 Thread via GitHub
ppkarwasz commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2126401153 > Question: With the changes I recently made are these alternative implementations really of value to anything? The primary motivation for them seemed to be to reduce the number

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-23 Thread via GitHub
vy commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1611152274 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,52 @@ = Manual -== Welcome to Log4j! - -Almost every large application includes it

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-23 Thread via GitHub
vy commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1611152274 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,52 @@ = Manual -== Welcome to Log4j! - -Almost every large application includes it

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-23 Thread via GitHub
vy commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1611160769 ## src/site/antora/modules/ROOT/partials/log4j-features.adoc: ## @@ -0,0 +1,47 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more +c

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-23 Thread via GitHub
ppkarwasz commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1611219014 ## src/site/antora/modules/ROOT/partials/log4j-features.adoc: ## @@ -0,0 +1,47 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-23 Thread via GitHub
vy commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1611226939 ## src/site/antora/modules/ROOT/partials/log4j-features.adoc: ## @@ -0,0 +1,47 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more +c

Re: [PR] Improve `api.adoc` et al. (logging-log4j2)

2024-05-23 Thread via GitHub
ppkarwasz commented on code in PR #2604: URL: https://github.com/apache/logging-log4j2/pull/2604#discussion_r1611430265 ## src/site/antora/modules/ROOT/pages/manual/customloglevels.adoc: ## @@ -14,7 +14,7 @@ See the License for the specific language governing permissions an

Re: [PR] Rewrote Messages (logging-log4j2)

2024-05-23 Thread via GitHub
ppkarwasz commented on code in PR #2591: URL: https://github.com/apache/logging-log4j2/pull/2591#discussion_r1611235544 ## src/site/antora/modules/ROOT/pages/manual/messages.adoc: ## @@ -16,311 +16,361 @@ = Messages -Although Log4j 2 provides Logger methods that accept

Re: [PR] Improve `api.adoc` et al. (logging-log4j2)

2024-05-23 Thread via GitHub
ppkarwasz commented on code in PR #2604: URL: https://github.com/apache/logging-log4j2/pull/2604#discussion_r1611469363 ## src/site/antora/modules/ROOT/pages/manual/api.adoc: ## @@ -14,187 +14,366 @@ See the License for the specific language governing permissions and l

[PR] Bump org.springframework:spring-framework-bom from 5.3.35 to 5.3.36 [logging-log4j-audit-sample]

2024-05-23 Thread via GitHub
dependabot[bot] opened a new pull request, #49: URL: https://github.com/apache/logging-log4j-audit-sample/pull/49 Bumps [org.springframework:spring-framework-bom](https://github.com/spring-projects/spring-framework) from 5.3.35 to 5.3.36. Release notes Sourced from https://github.

Re: [PR] Bump spring-framework.version from 6.1.6 to 6.1.8 (logging-log4j2)

2024-05-23 Thread via GitHub
github-actions[bot] merged PR #2606: URL: https://github.com/apache/logging-log4j2/pull/2606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.springframework:spring-framework-bom from 5.3.35 to 5.3.36 [logging-log4j-audit-sample]

2024-05-23 Thread via GitHub
github-actions[bot] merged PR #49: URL: https://github.com/apache/logging-log4j-audit-sample/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

Re: [PR] Improve `api.adoc` et al. (logging-log4j2)

2024-05-23 Thread via GitHub
vy commented on code in PR #2604: URL: https://github.com/apache/logging-log4j2/pull/2604#discussion_r1610148488 ## src/site/antora/modules/ROOT/partials/manual/api-best-practice-exception-as-last-argument.adoc: ## @@ -0,0 +1,30 @@ + +Licensed to the Apache Software Foun

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-23 Thread via GitHub
Chealer commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1611575204 ## src/site/antora/modules/ROOT/partials/log4j-features.adoc: ## @@ -0,0 +1,47 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-23 Thread via GitHub
rgoers commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2127136770 @ppkarwasz In general I agree with this proposal. If StringArrayThreadContextMap performs the best the I would be in favor of making it the default implementation. I am not sure

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-23 Thread via GitHub
jengebr commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2127237324 Responding to a few details: > As far as making log4j-api lighter goes Using the size of the jar file is meaningless. It could be 1TB but if you are only using 1 class fr

Re: [PR] Improve `api.adoc` et al. (logging-log4j2)

2024-05-23 Thread via GitHub
vy commented on code in PR #2604: URL: https://github.com/apache/logging-log4j2/pull/2604#discussion_r1611790633 ## src/site/antora/modules/ROOT/pages/manual/customloglevels.adoc: ## @@ -14,7 +14,7 @@ See the License for the specific language governing permissions and

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-23 Thread via GitHub
rgoers commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2127358496 No - SLF4J's "fix" introduces a new class, MDCAmbit, that you would use instead of MDC. As far as I can tell all it really does is add a close method. In contrast, ScopedContext do

[PR] Update empty string handling for TruncatingBufferedWriter (logging-log4j2)

2024-05-23 Thread via GitHub
bayne opened a new pull request, #2609: URL: https://github.com/apache/logging-log4j2/pull/2609 ``` ERROR StatusConsoleListener An exception occurred processing Appender console java.lang.IndexOutOfBoundsException: invalid offset: 0 at org.apache.logging.log4j.layout.template.

Re: [PR] Rewrote Messages (logging-log4j2)

2024-05-23 Thread via GitHub
ppkarwasz commented on code in PR #2591: URL: https://github.com/apache/logging-log4j2/pull/2591#discussion_r1612316217 ## src/site/antora/modules/ROOT/pages/manual/messages.adoc: ## @@ -16,311 +16,361 @@ = Messages -Although Log4j 2 provides Logger methods that accept

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-23 Thread via GitHub
ppkarwasz commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2128057825 > @ppkarwasz In general I agree with this proposal. If StringArrayThreadContextMap performs the best the I would be in favor of making it the default implementation. I am not sur

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-23 Thread via GitHub
rgoers commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2128274817 Yes, I assumed that is what you meant. However, nowhere in https://logging.apache.org/log4j/2.x/manual/garbagefree.html or https://logging.apache.org/log4j/2.x/manual/thread-context

Re: [PR] Update empty string handling for TruncatingBufferedWriter (logging-log4j2)

2024-05-24 Thread via GitHub
vy commented on code in PR #2609: URL: https://github.com/apache/logging-log4j2/pull/2609#discussion_r1612975875 ## log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/util/TruncatingBufferedWriter.java: ## @@ -168,6 +178,14 @@ public Writer ap

Re: [PR] rewrote logbuilder (logging-log4j2)

2024-05-24 Thread via GitHub
vy commented on PR #2595: URL: https://github.com/apache/logging-log4j2/pull/2595#issuecomment-2128791544 [As agreed with @grobmeier](https://the-asf.slack.com/archives/D02TQ7SQ9CY/p1716534032649039), merging this to wrap up the work on API docs. -- This is an automated message from the

Re: [PR] rewrote logbuilder (logging-log4j2)

2024-05-24 Thread via GitHub
vy merged PR #2595: URL: https://github.com/apache/logging-log4j2/pull/2595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Rewrote Messages (logging-log4j2)

2024-05-24 Thread via GitHub
vy commented on PR #2591: URL: https://github.com/apache/logging-log4j2/pull/2591#issuecomment-2128793585 [As agreed with @grobmeier](https://the-asf.slack.com/archives/D02TQ7SQ9CY/p1716534032649039), merging this to wrap up the work on API docs. -- This is an automated message from the

Re: [PR] Rewrote Messages (logging-log4j2)

2024-05-24 Thread via GitHub
vy merged PR #2591: URL: https://github.com/apache/logging-log4j2/pull/2591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Improve `api.adoc` et al. (logging-log4j2)

2024-05-24 Thread via GitHub
vy merged PR #2604: URL: https://github.com/apache/logging-log4j2/pull/2604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [I] Support aot? (logging-log4net)

2024-05-24 Thread via GitHub
FreeAndNil closed issue #147: Support aot? URL: https://github.com/apache/logging-log4net/issues/147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

Re: [I] Support aot? (logging-log4net)

2024-05-24 Thread via GitHub
FreeAndNil commented on issue #147: URL: https://github.com/apache/logging-log4net/issues/147#issuecomment-2129076033 @YahuiWong please reopen when you have feedback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] .NET8.0 XML Exception Problem (logging-log4net)

2024-05-24 Thread via GitHub
FreeAndNil closed issue #142: .NET8.0 XML Exception Problem URL: https://github.com/apache/logging-log4net/issues/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [I] .NET8.0 XML Exception Problem (logging-log4net)

2024-05-24 Thread via GitHub
FreeAndNil commented on issue #142: URL: https://github.com/apache/logging-log4net/issues/142#issuecomment-2129076847 @SwEngine please reopen when you have feedback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Bump spring-boot.version from 3.2.5 to 3.3.0 (logging-log4j2)

2024-05-24 Thread via GitHub
github-actions[bot] merged PR #2610: URL: https://github.com/apache/logging-log4j2/pull/2610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2 (logging-log4j2)

2024-05-24 Thread via GitHub
github-actions[bot] merged PR #2611: URL: https://github.com/apache/logging-log4j2/pull/2611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] #146 add installation page (logging-log4net)

2024-05-24 Thread via GitHub
FreeAndNil opened a new pull request, #148: URL: https://github.com/apache/logging-log4net/pull/148 #146 add installation page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2 (logging-log4j2)

2024-05-24 Thread via GitHub
github-actions[bot] merged PR #2612: URL: https://github.com/apache/logging-log4j2/pull/2612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] #146 add installation page (logging-log4net)

2024-05-24 Thread via GitHub
FreeAndNil merged PR #148: URL: https://github.com/apache/logging-log4net/pull/148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Website: API Separation - "Using Log4j2 as an SLF4J Implementation" is outdated/misleading (SLF4J particularly) (logging-log4j2)

2024-05-24 Thread via GitHub
vy closed issue #1460: Website: API Separation - "Using Log4j2 as an SLF4J Implementation" is outdated/misleading (SLF4J particularly) URL: https://github.com/apache/logging-log4j2/issues/1460 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [I] Website: API Separation - "Using Log4j2 as an SLF4J Implementation" is outdated/misleading (SLF4J particularly) (logging-log4j2)

2024-05-24 Thread via GitHub
vy commented on issue #1460: URL: https://github.com/apache/logging-log4j2/issues/1460#issuecomment-2129362921 Fixed by several changes implemented for #2535. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] Website: Manual should be more prominent in left sidebar (logging-log4j2)

2024-05-24 Thread via GitHub
vy closed issue #1469: Website: Manual should be more prominent in left sidebar URL: https://github.com/apache/logging-log4j2/issues/1469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Website: Manual should be more prominent in left sidebar (logging-log4j2)

2024-05-24 Thread via GitHub
vy commented on issue #1469: URL: https://github.com/apache/logging-log4j2/issues/1469#issuecomment-2129363373 Fixed by several changes implemented for #2535. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] (doc) Clarify the usage of parameterized logging in `Log4j 2 API` page (logging-log4j2)

2024-05-24 Thread via GitHub
vy closed issue #1918: (doc) Clarify the usage of parameterized logging in `Log4j 2 API` page URL: https://github.com/apache/logging-log4j2/issues/1918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [I] (doc) Clarify the usage of parameterized logging in `Log4j 2 API` page (logging-log4j2)

2024-05-24 Thread via GitHub
vy commented on issue #1918: URL: https://github.com/apache/logging-log4j2/issues/1918#issuecomment-2129363734 Fixed by several changes implemented for #2535. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-24 Thread via GitHub
jengebr commented on code in PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#discussion_r1613588442 ## log4j-api/src/main/java/org/apache/logging/log4j/ThreadContext.java: ## @@ -316,17 +303,7 @@ public static void remove(final String key) { * @since 2.8

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-24 Thread via GitHub
jengebr commented on code in PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#discussion_r1613587486 ## log4j-api/src/main/java/org/apache/logging/log4j/ThreadContext.java: ## @@ -268,21 +265,11 @@ public static void putIfNull(final String key, final String val

Re: [I] Website: Manual should be more prominent in left sidebar (logging-log4j2)

2024-05-24 Thread via GitHub
Chealer commented on issue #1469: URL: https://github.com/apache/logging-log4j2/issues/1469#issuecomment-2130671968 I (still) think that the manual should be sorted before the _Support_ and _Articles and Tutorials_ pages, but I agree that this is mostly solved. Thanks @vy -- This is

Re: [I] (doc) Clarify the usage of parameterized logging in `Log4j 2 API` page (logging-log4j2)

2024-05-24 Thread via GitHub
Chealer commented on issue #1918: URL: https://github.com/apache/logging-log4j2/issues/1918#issuecomment-2130693638 As far as I can see this fully persists, but I assume @vy meant that a fix is underway in the staging area. The new _Don’t use string concatenation_ section does improve, but

Re: [PR] Bump apache/logging-parent from rel/11.0.0 to 11.1.0 [logging-log4j-samples]

2024-05-26 Thread via GitHub
github-actions[bot] merged PR #144: URL: https://github.com/apache/logging-log4j-samples/pull/144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Bump org.assertj:assertj-bom from 3.25.3 to 3.26.0 [logging-log4j-samples]

2024-05-26 Thread via GitHub
github-actions[bot] merged PR #145: URL: https://github.com/apache/logging-log4j-samples/pull/145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Bump apache/logging-parent from rel/11.0.0 to 11.1.0 [logging-log4j-scala]

2024-05-26 Thread via GitHub
github-actions[bot] merged PR #57: URL: https://github.com/apache/logging-log4j-scala/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[I] When obtaining the LogContext through LogManager.getContext(getClass().getClassLoader(), false, uri), the shutdownHook in the XML configuration does not take effect. (logging-log4j2)

2024-05-26 Thread via GitHub
Pluto-syd opened a new issue, #2614: URL: https://github.com/apache/logging-log4j2/issues/2614 ## Description When obtaining the LogContext through LogManager.getContext(getClass().getClassLoader(), false, uri), the shutdownHook in the XML configuration does not take effect. #

Re: [I] When obtaining the LogContext through LogManager.getContext(getClass().getClassLoader(), false, uri), the shutdownHook in the XML configuration does not take effect. (logging-log4j2)

2024-05-26 Thread via GitHub
Pluto-syd commented on issue #2614: URL: https://github.com/apache/logging-log4j2/issues/2614#issuecomment-2132553835 https://github.com/apache/logging-log4j2/assets/47741121/e314fe33-e273-4a43-a179-da82cc7f6047";> -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Fix empty string handling for `TruncatingBufferedWriter` (logging-log4j2)

2024-05-26 Thread via GitHub
vy commented on code in PR #2609: URL: https://github.com/apache/logging-log4j2/pull/2609#discussion_r1615560088 ## src/changelog/.2.x.x/fix-TruncatingBufferedWriter-empty-input-handling.xml: ## @@ -0,0 +1,11 @@ + +http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https

Re: [PR] Fix empty string handling for `TruncatingBufferedWriter` (logging-log4j2)

2024-05-26 Thread via GitHub
vy merged PR #2609: URL: https://github.com/apache/logging-log4j2/pull/2609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Bump flapdoodle-embed.version from 4.9.0 to 4.11.0 (logging-log4j2)

2024-05-26 Thread via GitHub
ppkarwasz merged PR #2553: URL: https://github.com/apache/logging-log4j2/pull/2553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Bump flapdoodle-embed.version from 4.8.1 to 4.11.0 (logging-log4j2)

2024-05-27 Thread via GitHub
ppkarwasz merged PR #2555: URL: https://github.com/apache/logging-log4j2/pull/2555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Bump org.assertj:assertj-core from 3.25.3 to 3.26.0 [logging-log4j-tools]

2024-05-27 Thread via GitHub
github-actions[bot] merged PR #125: URL: https://github.com/apache/logging-log4j-tools/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Bump org.apache.tomcat:tomcat-juli from 10.1.23 to 10.1.24 (logging-log4j2)

2024-05-27 Thread via GitHub
github-actions[bot] merged PR #2580: URL: https://github.com/apache/logging-log4j2/pull/2580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump apache/logging-parent from rel/11.0.0 to 11.1.0 [logging-log4j-tools]

2024-05-27 Thread via GitHub
github-actions[bot] merged PR #126: URL: https://github.com/apache/logging-log4j-tools/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Bump commons-logging:commons-logging from 1.3.1 to 1.3.2 (logging-log4j2)

2024-05-27 Thread via GitHub
ppkarwasz commented on PR #2586: URL: https://github.com/apache/logging-log4j2/pull/2586#issuecomment-2132909394 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump io.netty:netty-bom from 4.1.109.Final to 4.1.110.Final (logging-log4j2)

2024-05-27 Thread via GitHub
ppkarwasz commented on PR #2601: URL: https://github.com/apache/logging-log4j2/pull/2601#issuecomment-2132912833 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump io.netty:netty-bom from 4.1.109.Final to 4.1.110.Final (logging-log4j2)

2024-05-27 Thread via GitHub
ppkarwasz commented on PR #2603: URL: https://github.com/apache/logging-log4j2/pull/2603#issuecomment-2132913584 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump spring-framework.version from 5.3.35 to 5.3.36 (logging-log4j2)

2024-05-27 Thread via GitHub
ppkarwasz commented on PR #2605: URL: https://github.com/apache/logging-log4j2/pull/2605#issuecomment-2132914532 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump org.apache.logging:logging-parent from 11.0.0 to 11.1.0 (logging-log4j2)

2024-05-27 Thread via GitHub
github-actions[bot] merged PR #2600: URL: https://github.com/apache/logging-log4j2/pull/2600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.15 to 1.14.16 (logging-log4j2)

2024-05-27 Thread via GitHub
github-actions[bot] merged PR #2608: URL: https://github.com/apache/logging-log4j2/pull/2608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump io.netty:netty-bom from 4.1.109.Final to 4.1.110.Final (logging-log4j2)

2024-05-27 Thread via GitHub
github-actions[bot] merged PR #2601: URL: https://github.com/apache/logging-log4j2/pull/2601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump spring-framework.version from 5.3.35 to 5.3.36 (logging-log4j2)

2024-05-27 Thread via GitHub
github-actions[bot] merged PR #2605: URL: https://github.com/apache/logging-log4j2/pull/2605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump apache/logging-parent from rel/11.0.0 to 11.1.0 [logging-log4j-kotlin]

2024-05-27 Thread via GitHub
github-actions[bot] merged PR #76: URL: https://github.com/apache/logging-log4j-kotlin/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

Re: [PR] Bump commons-logging:commons-logging from 1.3.1 to 1.3.2 (logging-log4j2)

2024-05-27 Thread via GitHub
github-actions[bot] merged PR #2586: URL: https://github.com/apache/logging-log4j2/pull/2586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump io.netty:netty-bom from 4.1.109.Final to 4.1.110.Final (logging-log4j2)

2024-05-27 Thread via GitHub
github-actions[bot] merged PR #2603: URL: https://github.com/apache/logging-log4j2/pull/2603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump maven.version from 3.9.6 to 3.9.7 (logging-log4j2)

2024-05-27 Thread via GitHub
github-actions[bot] merged PR #2616: URL: https://github.com/apache/logging-log4j2/pull/2616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.assertj:assertj-core from 3.25.3 to 3.26.0 (logging-log4j2)

2024-05-27 Thread via GitHub
github-actions[bot] merged PR #2618: URL: https://github.com/apache/logging-log4j2/pull/2618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump maven.version from 3.9.6 to 3.9.7 (logging-log4j2)

2024-05-27 Thread via GitHub
github-actions[bot] merged PR #2615: URL: https://github.com/apache/logging-log4j2/pull/2615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.assertj:assertj-core from 3.25.3 to 3.26.0 (logging-log4j2)

2024-05-27 Thread via GitHub
github-actions[bot] merged PR #2617: URL: https://github.com/apache/logging-log4j2/pull/2617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] Add Simple Logger and Status Logger pages (logging-log4j2)

2024-05-27 Thread via GitHub
vy opened a new pull request, #2619: URL: https://github.com/apache/logging-log4j2/pull/2619 This PR addresses `StatusLogger` and `SimpleLogger` tasks of #2540. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Add Simple Logger and Status Logger pages (logging-log4j2)

2024-05-27 Thread via GitHub
ppkarwasz commented on code in PR #2619: URL: https://github.com/apache/logging-log4j2/pull/2619#discussion_r1615917938 ## src/site/antora/modules/ROOT/pages/manual/simple-logger.adoc: ## @@ -0,0 +1,29 @@ + +Licensed to the Apache Software Foundation (ASF) under one or m

[I] I am not using TimeEvaluator! (logging-log4net)

2024-05-27 Thread via GitHub
aknaldemir opened a new issue, #149: URL: https://github.com/apache/logging-log4net/issues/149 Hi Everyone. I am using log4net in my .net framework 4.7.2 console project and I want to use BufferingForwardingAppender which is related ADONetAppender. When I use bufferSize and evaluator

Re: [I] I cannot use TimeEvaluator! (logging-log4net)

2024-05-27 Thread via GitHub
FreeAndNil commented on issue #149: URL: https://github.com/apache/logging-log4net/issues/149#issuecomment-2133529245 @aknaldemir Can you please post the complete log4net config section? Did I understand correctly, that you want to buffer the log messages for 10 seconds and write them af

Re: [I] I cannot use TimeEvaluator! (logging-log4net)

2024-05-27 Thread via GitHub
aknaldemir commented on issue #149: URL: https://github.com/apache/logging-log4net/issues/149#issuecomment-2133563419 yes you understood correct. But not just 10 seconds. If buffersize is 23 then I need log again. My code is like that; `

Re: [PR] Add Simple Logger and Status Logger pages (logging-log4j2)

2024-05-27 Thread via GitHub
vy commented on code in PR #2619: URL: https://github.com/apache/logging-log4j2/pull/2619#discussion_r1616303058 ## src/site/antora/modules/ROOT/pages/manual/api.adoc: ## @@ -220,7 +221,25 @@ link:../javadoc/log4j-api/org/apache/logging/log4j/LogManager.html[`EventLogger` xr

<    11   12   13   14   15   16   17   18   19   20   >