Re: [PR] Bump org.scala-lang:scala3-library_3 from 3.3.1 to 3.4.0 [logging-log4j-scala]

2024-05-14 Thread via GitHub
rgoers commented on PR #46: URL: https://github.com/apache/logging-log4j-scala/pull/46#issuecomment-2110426350 I am seriously asking when we agreed to let dependabot merge a PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600175070 ## src/site/antora/modules/ROOT/examples/configuration/arbiters-select.json: ## @@ -0,0 +1,29 @@ +{ + "Configuration": { +"Appenders": { + "File": {

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600175396 ## src/site/antora/modules/ROOT/examples/configuration/arbiters.json: ## @@ -0,0 +1,33 @@ +{ + "Configuration": { +"Appenders": { + "File": { +

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600175785 ## src/site/antora/modules/ROOT/examples/configuration/filters.xml: ## @@ -0,0 +1,40 @@ + + +https://logging.apache.org/xml/ns"; + xmlns:xsi="htt

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600176341 ## src/site/antora/modules/ROOT/examples/configuration/main-elements.json: ## @@ -0,0 +1,48 @@ +{ + "Configuration": { +"Appenders": { + "Console": {

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600176614 ## src/site/antora/modules/ROOT/examples/configuration/main-elements.json: ## @@ -0,0 +1,48 @@ +{ + "Configuration": { +"Appenders": { + "Console": {

Re: [PR] Bump github/codeql-action from 3.25.4 to 3.25.5 [logging-parent]

2024-05-14 Thread via GitHub
github-actions[bot] merged PR #179: URL: https://github.com/apache/logging-parent/pull/179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600175070 ## src/site/antora/modules/ROOT/examples/configuration/arbiters-select.json: ## @@ -0,0 +1,29 @@ +{ + "Configuration": { +"Appenders": { + "File": {

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600175396 ## src/site/antora/modules/ROOT/examples/configuration/arbiters.json: ## @@ -0,0 +1,33 @@ +{ + "Configuration": { +"Appenders": { + "File": { +

Re: [PR] Bump org.scala-lang:scala3-library_3 from 3.3.1 to 3.4.0 [logging-log4j-scala]

2024-05-14 Thread via GitHub
vy commented on PR #46: URL: https://github.com/apache/logging-log4j-scala/pull/46#issuecomment-2110470791 I don't know what you mean by agreement. There was no vote since this is a technical change. I am shocked with your question, since I discussed this several times with you, how `log4j

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600209404 ## src/site/antora/modules/ROOT/examples/configuration/main-elements.json: ## @@ -0,0 +1,48 @@ +{ + "Configuration": { +"Appenders": { + "Console": {

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600219429 ## src/site/antora/modules/ROOT/examples/configuration/xinclude-appenders.xml: ## @@ -0,0 +1,25 @@ + + + + Review Comment: Fixed in 01ef75c7a139c1d9bf8e9

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600219030 ## src/site/antora/modules/ROOT/examples/configuration/scripts.yaml: ## @@ -0,0 +1,70 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600226250 ## src/site/antora/modules/ROOT/pages/log4j-jul.adoc: ## @@ -35,15 +35,28 @@ This must be done either through the command line (i.e., using the `-Djava.util.

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600232996 ## src/site/antora/modules/ROOT/pages/plugin-reference.adoc: ## Review Comment: It's populate exactly to remove the not-found errors in the IDE. Th

Re: [PR] Bump org.scala-lang:scala3-library_3 from 3.3.1 to 3.4.0 [logging-log4j-scala]

2024-05-14 Thread via GitHub
rgoers commented on PR #46: URL: https://github.com/apache/logging-log4j-scala/pull/46#issuecomment-2110518224 I was aware that dependabot was integrated and making changelog entries. I was not aware the PRs were automatically being merged. That is the ONLY aspect of this I am questioning.

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600241446 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600243908 ## src/site/antora/modules/ROOT/examples/configuration/scripts.yaml: ## @@ -0,0 +1,70 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600244556 ## src/site/antora/modules/ROOT/examples/configuration/xinclude-appenders.xml: ## @@ -0,0 +1,25 @@ + + + + + + + Review Comment: Fixed in 01ef75c

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600245123 ## src/site/antora/modules/ROOT/pages/manual/appenders.adoc: ## @@ -120,7 +120,7 @@ There are also a few system properties that can be used to maintain appli

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600247729 ## src/site/antora/modules/ROOT/nav.adoc: ## @@ -40,20 +40,23 @@ ** xref:manual/thread-context.adoc[] ** xref:manual/scoped-context.adoc[] ** xref:manual/re

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600246173 ## src/site/antora/modules/ROOT/examples/configuration/filters.xml: ## @@ -0,0 +1,40 @@ + + +https://logging.apache.org/xml/ns"; + xmlns:xsi="htt

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600253681 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600259077 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600259809 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600265563 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Bump org.apache.logging.log4j:log4j-changelog-maven-plugin from 0.8.0 to 0.9.0 [logging-parent]

2024-05-14 Thread via GitHub
github-actions[bot] merged PR #181: URL: https://github.com/apache/logging-parent/pull/181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
vy commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600519741 ## src/site/antora/modules/ROOT/nav.adoc: ## @@ -40,20 +40,23 @@ ** xref:manual/thread-context.adoc[] ** xref:manual/scoped-context.adoc[] ** xref:manual/resource-

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
vy commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600520980 ## src/site/antora/modules/ROOT/pages/plugin-reference.adoc: ## Review Comment: Could you please document (in comments) the fact that these links are there only

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-14 Thread via GitHub
vy commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1600531047 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permissions and

[PR] Rewrote manual intro (logging-log4j2)

2024-05-14 Thread via GitHub
grobmeier opened a new pull request, #2581: URL: https://github.com/apache/logging-log4j2/pull/2581 Rewriting of the manual intro. Please comment if you see any missing "fantastic" features that need to be included in the intro or if anything should be removed. closes #1468

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-14 Thread via GitHub
swebb2066 commented on PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#issuecomment-2111425573 > Please comment if you see any missing "fantastic" features that need to be included What about being able to activate additional logging output or disable some output fo

[PR] Condition internal debug logging on its enabled state [logging-log4cxx]

2024-05-14 Thread via GitHub
swebb2066 opened a new pull request, #384: URL: https://github.com/apache/logging-log4cxx/pull/384 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[PR] Warn about each instance of a mis-configured appender [logging-log4cxx]

2024-05-14 Thread via GitHub
swebb2066 opened a new pull request, #385: URL: https://github.com/apache/logging-log4cxx/pull/385 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[PR] Update XML configuration test case [logging-log4cxx]

2024-05-14 Thread via GitHub
swebb2066 opened a new pull request, #386: URL: https://github.com/apache/logging-log4cxx/pull/386 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] Update XML configuration test case [logging-log4cxx]

2024-05-14 Thread via GitHub
swebb2066 merged PR #386: URL: https://github.com/apache/logging-log4cxx/pull/386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

[I] A problem with an abnormal log output location. (logging-log4j2)

2024-05-14 Thread via GitHub
FrankCy opened a new issue, #2582: URL: https://github.com/apache/logging-log4j2/issues/2582 ## Description The rocketmq-client.log outputs lettuce logs and the rocketmq log level is ERROR and the output lettuce log is DEBUG. ## Configuration **Version:** Log4j:2.18.

Re: [I] A problem with an abnormal log output location. (logging-log4j2)

2024-05-15 Thread via GitHub
rgoers commented on issue #2582: URL: https://github.com/apache/logging-log4j2/issues/2582#issuecomment-2111774035 I don't actually see a problem being stated anywhere here. What exactly is wrong? -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [I] A problem with an abnormal log output location. (logging-log4j2)

2024-05-15 Thread via GitHub
FrankCy commented on issue #2582: URL: https://github.com/apache/logging-log4j2/issues/2582#issuecomment-2111876623 > I don't actually see a problem being stated anywhere here. What exactly is wrong? Hello, the program uses both rocketmq and redis and uses the topology refresh featu

Re: [I] A problem with an abnormal log output location. (logging-log4j2)

2024-05-15 Thread via GitHub
FrankCy commented on issue #2582: URL: https://github.com/apache/logging-log4j2/issues/2582#issuecomment-2111877281 > I don't actually see a problem being stated anywhere here. What exactly is wrong? Hello, the program uses both rocketmq and redis and uses the topology refresh featu

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601200792 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -14,32 +14,77 @@ See the License for the specific language governing permissions and

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601201351 ## src/site/antora/modules/ROOT/pages/plugin-reference.adoc: ## Review Comment: Fixed in be54ca2aefd708b8159548277d99e12aea948980 -- This is an automa

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601206149 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601211217 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601228881 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601228881 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601229931 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601230226 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601230751 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601231254 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601231573 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601232409 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601231948 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601233671 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601234095 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601234847 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601235226 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601238891 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1024 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601340498 ## src/site/antora/modules/ROOT/examples/configuration/filters.xml: ## Review Comment: Let's refactor the example in #2529 -- This is an automated mes

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601341439 ## src/site/antora/modules/ROOT/examples/configuration/arbiters-select.json: ## Review Comment: Done -- This is an automated message from the Apache G

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601353425 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1601435368 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1019 @@ See the License for the specific language governing permission

Re: [I] A problem with an abnormal log output location. (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on issue #2582: URL: https://github.com/apache/logging-log4j2/issues/2582#issuecomment-2112337463 @FrankCy, Can you check if your application is using Log4j for **all** logging: many RocketMQ artifacts have a dependency on `logback-classic`, which smuggles Logbac

Re: [PR] Condition internal debug logging on its enabled state [logging-log4cxx]

2024-05-15 Thread via GitHub
rm5248 commented on code in PR #384: URL: https://github.com/apache/logging-log4cxx/pull/384#discussion_r1601563608 ## src/main/cpp/domconfigurator.cpp: ## @@ -524,7 +538,9 @@ void DOMConfigurator::parseChildrenOfLoggerElement( AppenderPtr appender = find

Re: [PR] Condition internal debug logging on its enabled state [logging-log4cxx]

2024-05-15 Thread via GitHub
rm5248 commented on PR #384: URL: https://github.com/apache/logging-log4cxx/pull/384#issuecomment-2112418740 Since we have a lot of internal log messages that only log strings, would it make sense to make a vararg or [parameter packed](https://en.cppreference.com/w/cpp/language/parameter_pa

Re: [PR] Temporary MacOS fixup [logging-parent]

2024-05-15 Thread via GitHub
vy closed pull request #169: Temporary MacOS fixup URL: https://github.com/apache/logging-parent/pull/169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] Temporary MacOS fixup [logging-parent]

2024-05-15 Thread via GitHub
vy commented on PR #169: URL: https://github.com/apache/logging-parent/pull/169#issuecomment-2112449810 Fixed in 321af9e27d892eb6cfeaa7f97301adb50a718a21 by replacing Temurin with Zulu everywhere. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [I] The `log4j2.messageFactory` property is ignored since 2.23.0 (logging-log4j2)

2024-05-15 Thread via GitHub
lizongbo commented on issue #2379: URL: https://github.com/apache/logging-log4j2/issues/2379#issuecomment-2113035308 This new code doesn't make the log4j2.messageFactory configuration work.Please roll back the logic that read the proeprties configuration file earlier. -- This is an auto

Re: [I] The `log4j2.messageFactory` property is ignored since 2.23.0 (logging-log4j2)

2024-05-15 Thread via GitHub
lizongbo commented on issue #2379: URL: https://github.com/apache/logging-log4j2/issues/2379#issuecomment-2113041818 My project with version log4j2 2.23.1 almost caused a serious problem The following code is the correct implementation for the previous one ``` public

Re: [I] The `log4j2.messageFactory` property is ignored since 2.23.0 (logging-log4j2)

2024-05-15 Thread via GitHub
lizongbo commented on issue #2379: URL: https://github.com/apache/logging-log4j2/issues/2379#issuecomment-2113044021 @vy need open this Issue again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] The `log4j2.messageFactory` property is ignored since 2.23.0 (logging-log4j2)

2024-05-15 Thread via GitHub
ppkarwasz commented on issue #2379: URL: https://github.com/apache/logging-log4j2/issues/2379#issuecomment-2113094077 @lizongbo, Did you check the `2.24.0-SNAPSHOT`? Volkan's patch is not contained in version 2.23.1. -- This is an automated message from the Apache Git Serv

Re: [PR] Bump commons-logging:commons-logging from 1.3.1 to 1.3.2 [logging-log4j-transform]

2024-05-15 Thread via GitHub
github-actions[bot] merged PR #102: URL: https://github.com/apache/logging-log4j-transform/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

Re: [PR] Bump commons-logging:commons-logging from 1.3.1 to 1.3.2 [logging-log4j-jakarta]

2024-05-15 Thread via GitHub
github-actions[bot] merged PR #29: URL: https://github.com/apache/logging-log4j-jakarta/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[PR] rewrote Markers (logging-log4j2)

2024-05-15 Thread via GitHub
grobmeier opened a new pull request, #2584: URL: https://github.com/apache/logging-log4j2/pull/2584 Rewrite of the Markers description, adding more information but also making the code example smaller #2535 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Condition internal debug logging on its enabled state [logging-log4cxx]

2024-05-15 Thread via GitHub
swebb2066 commented on code in PR #384: URL: https://github.com/apache/logging-log4cxx/pull/384#discussion_r1602415483 ## src/main/cpp/domconfigurator.cpp: ## @@ -524,7 +538,9 @@ void DOMConfigurator::parseChildrenOfLoggerElement( AppenderPtr appender = f

Re: [PR] Condition internal debug logging on its enabled state [logging-log4cxx]

2024-05-15 Thread via GitHub
swebb2066 commented on PR #384: URL: https://github.com/apache/logging-log4cxx/pull/384#issuecomment-2113726435 > would it make sense to make a vararg or [parameter packed](https://en.cppreference.com/w/cpp/language/parameter_pack) version of LogLog::debug()? I do not know how to use

Re: [I] A problem with an abnormal log output location. (logging-log4j2)

2024-05-15 Thread via GitHub
FrankCy commented on issue #2582: URL: https://github.com/apache/logging-log4j2/issues/2582#issuecomment-2113870858 > @FrankCy, > > Can you check if your application is using Log4j for **all** logging: many RocketMQ artifacts have a dependency on `logback-classic`, which smuggles Lo

Re: [PR] Warn about each instance of a mis-configured appender [logging-log4cxx]

2024-05-15 Thread via GitHub
swebb2066 merged PR #385: URL: https://github.com/apache/logging-log4cxx/pull/385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-16 Thread via GitHub
vy commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1602715319 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,57 @@ = Manual -== Welcome to Log4j! - -Almost every large application includes it

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-16 Thread via GitHub
ppkarwasz merged PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Revamp the `Configuration` page (logging-log4j2)

2024-05-16 Thread via GitHub
ppkarwasz closed issue #2525: Revamp the `Configuration` page URL: https://github.com/apache/logging-log4j2/issues/2525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-16 Thread via GitHub
grobmeier commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1603124193 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## Review Comment: I tried it, but it is a horrible mess and extremely hard for the author to wr

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-16 Thread via GitHub
grobmeier commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1603126942 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,57 @@ = Manual -== Welcome to Log4j! - -Almost every large application incl

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-16 Thread via GitHub
vy commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1603176421 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,57 @@ = Manual -== Welcome to Log4j! - -Almost every large application includes it

Re: [PR] Bump spring-framework.version from 5.3.34 to 5.3.35 (logging-log4j2)

2024-05-16 Thread via GitHub
github-actions[bot] merged PR #2588: URL: https://github.com/apache/logging-log4j2/pull/2588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump commons-logging:commons-logging from 1.3.1 to 1.3.2 (logging-log4j2)

2024-05-16 Thread via GitHub
github-actions[bot] merged PR #2589: URL: https://github.com/apache/logging-log4j2/pull/2589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] Bump org.springframework:spring-framework-bom from 5.3.34 to 5.3.35 [logging-log4j-audit-sample]

2024-05-16 Thread via GitHub
dependabot[bot] opened a new pull request, #47: URL: https://github.com/apache/logging-log4j-audit-sample/pull/47 Bumps [org.springframework:spring-framework-bom](https://github.com/spring-projects/spring-framework) from 5.3.34 to 5.3.35. Release notes Sourced from https://github.

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-16 Thread via GitHub
vy commented on PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#issuecomment-2115010393 @grobmeier, I reused common content between `/index.adoc` and `manual/index.adoc` in 8d47758e5c3de70dc46b83dd2f2ee16e84eaaae0. I don't prefer pushing commits to other people's PR branch

Re: [PR] Bump org.springframework:spring-framework-bom from 5.3.34 to 5.3.35 [logging-log4j-audit-sample]

2024-05-16 Thread via GitHub
github-actions[bot] closed pull request #47: Bump org.springframework:spring-framework-bom from 5.3.34 to 5.3.35 URL: https://github.com/apache/logging-log4j-audit-sample/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-16 Thread via GitHub
vy commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1603263563 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,111 @@ = Markers -One of the primary purpose of a logging framework is to provide

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-16 Thread via GitHub
vy commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1603281548 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,111 @@ = Markers -One of the primary purpose of a logging framework is to provide

Re: [PR] Revamp the `Asynchronous logging` page (logging-log4j2)

2024-05-16 Thread via GitHub
ppkarwasz commented on code in PR #2577: URL: https://github.com/apache/logging-log4j2/pull/2577#discussion_r1603624102 ## src/site/antora/modules/ROOT/pages/manual/async.adoc: ## @@ -14,525 +14,375 @@ See the License for the specific language governing permissions and

Re: [I] The `log4j2.messageFactory` property is ignored since 2.23.0 (logging-log4j2)

2024-05-16 Thread via GitHub
lizongbo commented on issue #2379: URL: https://github.com/apache/logging-log4j2/issues/2379#issuecomment-2115798857 > @lizongbo, > > Did you check the `2.24.0-SNAPSHOT`? Volkan's patch is not contained in version 2.23.1. Thank fo your reply, When I use 2.24.0-SNAPSHOT from h

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-16 Thread via GitHub
grobmeier commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1603808549 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,111 @@ = Markers -One of the primary purpose of a logging framework is to

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-16 Thread via GitHub
grobmeier commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1603815471 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,111 @@ = Markers -One of the primary purpose of a logging framework is to

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-16 Thread via GitHub
vy commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1603860707 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,111 @@ = Markers -One of the primary purpose of a logging framework is to provide

[PR] Port system properties documentation to `main` (logging-log4j2)

2024-05-16 Thread via GitHub
ppkarwasz opened a new pull request, #2590: URL: https://github.com/apache/logging-log4j2/pull/2590 Ports to `main` the changes introduced in #2552 . Part of #2525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Port system properties documentation to `main` (logging-log4j2)

2024-05-16 Thread via GitHub
ppkarwasz commented on code in PR #2590: URL: https://github.com/apache/logging-log4j2/pull/2590#discussion_r1603916609 ## src/site/antora/modules/ROOT/pages/manual/systemproperties.adoc: ## @@ -14,895 +14,272 @@ See the License for the specific language governing permissio

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-16 Thread via GitHub
ppkarwasz commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1603928334 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,111 @@ = Markers -One of the primary purpose of a logging framework is to

Re: [PR] Bump org.springframework:spring-framework-bom from 6.1.5 to 6.1.7 [logging-log4j-jakarta]

2024-05-16 Thread via GitHub
github-actions[bot] merged PR #30: URL: https://github.com/apache/logging-log4j-jakarta/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

<    9   10   11   12   13   14   15   16   17   18   >