swebb2066 commented on code in PR #384:
URL: https://github.com/apache/logging-log4cxx/pull/384#discussion_r1602415483
##########
src/main/cpp/domconfigurator.cpp:
##########
@@ -524,7 +538,9 @@ void DOMConfigurator::parseChildrenOfLoggerElement(
AppenderPtr appender = findAppenderByReference(p,
utf8Decoder, currentElement, doc, appenders);
LogString refName = subst(getAttribute(utf8Decoder,
currentElement, REF_ATTR));
- if (appender != 0)
+ if (!LogLog::isDebugEnabled())
+ ;
+ else if (appender != 0)
Review Comment:
The empty `if` avoids extra indentation and guards the `else` case which is
also a `LogLog::debug` statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
