carterkozak commented on issue #331: Fixed check for
RollingFileManager,directWrite
URL: https://github.com/apache/logging-log4j2/pull/331#issuecomment-573773269
It looks like we have five occurrences of `instanceof
DirectWriteRolloverStrategy` across `RollingFileManager` and
`RollingRand
ChristophKaser commented on issue #331: Fixed check for
RollingFileManager,directWrite
URL: https://github.com/apache/logging-log4j2/pull/331#issuecomment-574099415
I only count three:
- The one I replaced
-
[Two](https://github.com/apache/logging-log4j2/blob/231f669df3f16c03e35
ChristophKaser opened a new pull request #332: LOG4J2-2760: Fixes
RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout
URL: https://github.com/apache/logging-log4j2/pull/332
This PR consist of a regression test showcasing the problem(s) and a fix.
See https://issues.ap
ChristophKaser opened a new pull request #333: Fixes travis build
URL: https://github.com/apache/logging-log4j2/pull/333
by skipping the install phase and using openjdk8
This is an automated message from the Apache Git Service
jvz commented on issue #333: Fixes travis build
URL: https://github.com/apache/logging-log4j2/pull/333#issuecomment-57473
We need two JDKs available to compile right now (8 and 9+). Not sure if this
would work.
This is an
ChristophKaser commented on issue #333: Fixes travis build
URL: https://github.com/apache/logging-log4j2/pull/333#issuecomment-574732219
For some reason, it did for me (see
https://travis-ci.org/ChristophKaser/logging-log4j2/builds/637479679). I guess
openjdk11 is installed by default.
--
ChristophKaser commented on issue #333: Fixes travis build
URL: https://github.com/apache/logging-log4j2/pull/333#issuecomment-574734303
That being said, it looks like the after_success script does not work. But I
think this is an unrelated problem.
```
Exception in thread "main"
jvz commented on issue #333: Fixes travis build
URL: https://github.com/apache/logging-log4j2/pull/333#issuecomment-574760214
Oh that's great news! Let's see if this builds now.
This is an automated message from the Apache Git
jvz merged pull request #333: Fixes travis build
URL: https://github.com/apache/logging-log4j2/pull/333
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jvz commented on issue #333: Fixes travis build
URL: https://github.com/apache/logging-log4j2/pull/333#issuecomment-574767850
Build passed. Thanks so much for figuring this out!
This is an automated message from the Apache Git
reebow opened a new pull request #334: (doc) fix typos
URL: https://github.com/apache/logging-log4j2/pull/334
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
ErtugrulKra opened a new pull request #55: Feature/rest appender
URL: https://github.com/apache/logging-log4net/pull/55
Hello,
I created a rest service log4net appender for appending log events to rest
api.
This is an
ErtugrulKra closed pull request #55: Feature/rest appender
URL: https://github.com/apache/logging-log4net/pull/55
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
ErtugrulKra opened a new pull request #55: Feature/rest appender
URL: https://github.com/apache/logging-log4net/pull/55
Hello,
I created a rest service log4net appender for appending log events to rest
api.
This is an
vy opened a new pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335
This is the very first draft of my work on contributing
[log4j2-logstash-layout](/vy/log4j2-logstash-layout) into Log4j core. Please
note that this is s
vy commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372016555
##
File path:
log4j-layout-jackson-json-template/src/main/resources/JsonLayout.json
##
@@ -0,0 +1,27
vy commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372025989
##
File path:
log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/template/l
vy commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372026508
##
File path:
log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/template/l
vy commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372025989
##
File path:
log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/template/l
carterkozak commented on a change in pull request #335: Import of
LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372026814
##
File path:
log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/t
jvz commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372090887
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/util/Throwables.java
##
@@ -40,
jvz commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372096836
##
File path:
log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/template/
jvz commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372096836
##
File path:
log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/template/
jvz commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-579506548
> I chose `JsonTemplateLayout` as the new module name, which clearly
communicates the intent. I am not totally convinced with the package
vy commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372341467
##
File path:
log4j-layout-jackson-json-template/src/main/resources/JsonLayout.json
##
@@ -0,0 +1,27
vy commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372341591
##
File path:
log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/template/l
vy commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372341908
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/util/Throwables.java
##
@@ -40,1
vy commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372344182
##
File path:
log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/template/l
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-579728012
> > I chose `JsonTemplateLayout` as the new module name, which clearly
communicates the intent. I am not totally convinced with the packag
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-579835151
@remkop, please note the revamp in ed1dda4. The results on my machine are as
follows:
```
$ uname -a
Linux tahta 4.15.0-70-ge
remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-579841760
I’ll take a look but it will take me some time.
This is an automated
jvz commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-579864331
To add a test jar as a dependency, add `test-jar` to the
`` definition.
jvz edited a comment on issue #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-579864331
To add a test jar as a dependency, add `test-jar` to the
`` definition. See for example
[log4j-core-its/pom.xml](https://github.
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-579866133
> To add a test jar as a dependency, add `test-jar` to the
`` definition. See for example
[log4j-core-its/pom.xml](https://github.com/apa
MariusVolkhart opened a new pull request #336: LOG4J2-2768 Add log(String, ...)
overloads to LogBuilder
URL: https://github.com/apache/logging-log4j2/pull/336
The overloaded methods behave similarly to log(String, Object[]), but reduce
the need for an Object[] allocation in certain code pa
remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580075777
Showing only the average in ns/operation:
```
NoOpsample 27754662 492.377 ± 6.634 ns/op
Thr
remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580077235
If you wonder why the `MpmcArrayQueue` benchmark numbers are higher than
simple allocation, I am not sure either.
My first gues
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580189684
> The NoOp benchmark should be renamed Allocate
Check.
> I don't believe that `MpmcArrayQueue` is lock-free
The defini
vy edited a comment on issue #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580189684
> The NoOp benchmark should be renamed Allocate
Check.
> I don't believe that `MpmcArrayQueue` is lock-free
Th
richardstartin commented on issue #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580196090
To be clear, that’s just a hunch. I haven’t run the benchmarks let alone
profiled them.
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580197240
And the following question still stands open: Given TLA results constitute
the baseline, what is the pool implied maximum performance degr
remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580205695
Well, what is the trade off? What benefits do we gain in return of this
worse performance?
--
remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580215790
> I would be interested to know the marginal cost of G1 in this case. The
most interesting metric is MPMC/G1 vs MPMC/other GC
I
richardstartin commented on issue #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580229964
> I don’t think we’re measuring the cost of GC anywhere, are we?
At this scale, there are so many confounding factors w
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580240386
Triggered by @richardstartin's observation, why don't we allow all 3
co-exist in the code base? After all, the call site doesn't care abou
remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580261245
Not sure I agree... What is the trade-off? What do users gain when they
select something other than ThreadLocal?
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580267355
> Not sure I agree... What is the trade-off? What do users gain when they
select something other than ThreadLocal?
If you'd recall,
remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580583586
@vy Understood. That makes sense to me.
This is an automated message
stephen-webb opened a new pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14
This is an automated message from the Apache Git Service.
To respond to the message, please log o
vy commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r373474960
##
File path:
log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/template/l
jvz commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r373564119
##
File path:
log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/template/
jvz commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r373566976
##
File path:
log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/template/
jvz commented on issue #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-580809182
I ❤️ PRs that have huge negative line counts like this! I'm not super
familiar with the tooling in use, though I'll try this out over the weekend.
jvz commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373572922
##
File path: pom.xml
##
@@ -65,7 +65,7 @@
scm:git:http://gitbox.apache.org/repos/asf/logging-log4cxx.gi
jvz commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373573832
##
File path: pom.xml
##
@@ -65,7 +65,7 @@
scm:git:http://gitbox.apache.org/repos/asf/logging-log4cxx.gi
jvz commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373577696
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,75 @@
+~~ Licensed to the Apache Software Foundation (ASF) un
jvz commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373577204
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,75 @@
+~~ Licensed to the Apache Software Foundation (ASF) un
jvz commented on issue #12: Add support for building and testing with cmake
URL: https://github.com/apache/logging-log4cxx/pull/12#issuecomment-580815431
Can anything from this be combined with #14? I love the simplification if
possible rather than supporting multiple build systems.
--
ams-tschoening commented on issue #12: Add support for building and testing
with cmake
URL: https://github.com/apache/logging-log4cxx/pull/12#issuecomment-580837297
From my understanding this is CMAKE without removing anything, while #14 is
CMAKE with removing at least ANT, because in the
bkuker opened a new pull request #337: Update ConfigurationSource.java
URL: https://github.com/apache/logging-log4j2/pull/337
I think this needs to store the data so that resetInputStream() works.
The jmx function LoggerContextAdmin::getConfigText throws a NPE if you have
previously call
rgoers commented on issue #337: Update ConfigurationSource.java
URL: https://github.com/apache/logging-log4j2/pull/337#issuecomment-580913709
Can you create a Jira issue for this. It would also be great to include a
unit test that fails without this fix.
---
jvz commented on issue #12: Add support for building and testing with cmake
URL: https://github.com/apache/logging-log4cxx/pull/12#issuecomment-580930215
> While we are at it, it should be discussed if CMAKE should replace
Autotools on Linux as well, leaving only the ANT/MAVEN-parts in plac
bkuker commented on issue #337: Update ConfigurationSource.java
URL: https://github.com/apache/logging-log4j2/pull/337#issuecomment-580948242
Thanks, yes I'll do that Monday!
This is an automated message from the Apache Git Se
rm5248 commented on issue #12: Add support for building and testing with cmake
URL: https://github.com/apache/logging-log4cxx/pull/12#issuecomment-580961254
Why use Maven at all at that point? What I do for C++ projects is to just
generate the site with Doxygen; it's possible to then make
rm5248 commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373735482
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
Review comment:
Is it pos
rm5248 commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373735942
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
+include(src/cmake/projectVersi
rm5248 commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373736174
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
+include(src/cmake/projectVersi
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373737584
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
+include(src/cmake/proje
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373738203
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
Review comment:
I
rm5248 commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373739795
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
+include(src/cmake/projectVersi
rm5248 commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373740646
##
File path: src/main/include/CMakeLists.txt
##
@@ -0,0 +1,101 @@
+# Configure
+if(WIN32)
+add_custom_target(configur
rm5248 commented on issue #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-580969003
Also: this doesn't install a pkgconfig file at all; that would be needed for
other non-cmake buildsystems to work with.
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373754082
##
File path: pom.xml
##
@@ -65,7 +65,7 @@
scm:git:http://gitbox.apache.org/repos/asf/logging-
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373754317
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
+include(src/cmake/proje
stephen-webb commented on issue #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-580994002
@rm5248 Can you tell me what I would need to change to install a pkgconfig
file?
-
ams-tschoening commented on issue #12: Add support for building and testing
with cmake
URL: https://github.com/apache/logging-log4cxx/pull/12#issuecomment-581015095
> Why use Maven at all at that point? What I do for C++ projects is to just
generate the site with Doxygen;[...]
Maven
rm5248 commented on issue #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-581035485
@stephen-webb You can configure the [.pc.in
file](https://github.com/rm5248/logging-log4cxx/blob/a3fd5a53aefb297dd4526acd156e11335e484c37/CMakeLists.txt#
jvz merged pull request #3: add support for scala 2.13.0 [LOG4J2-2668]
URL: https://github.com/apache/logging-log4j-scala/pull/3
This is an automated message from the Apache Git Service.
To respond to the message, please log
jvz closed pull request #2: [LOG4J2-2668] Add support for Scala 2.13.0
URL: https://github.com/apache/logging-log4j-scala/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log
jvz commented on issue #2: [LOG4J2-2668] Add support for Scala 2.13.0
URL: https://github.com/apache/logging-log4j-scala/pull/2#issuecomment-581073804
See #3 for updated version of this PR.
This is an automated message from th
turbanoff opened a new pull request #338: use 'final' modifier for fields where
possible
URL: https://github.com/apache/logging-log4j2/pull/338
Also removed 2 unused fields which my IDEA highlights as possible `final`,
but fields were unused (leftovers after refactoring):
1. `DefaultLog
turbanoff commented on issue #338: use 'final' modifier for fields where
possible
URL: https://github.com/apache/logging-log4j2/pull/338#issuecomment-581656719
I didn't touch fields in samples, tests and perf modules.
Field `org.apache.logging.log4j.core.layout.AbstractStringLayout#chars
ErtugrulKra closed pull request #55: Feature/rest appender
URL: https://github.com/apache/logging-log4net/pull/55
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
ErtugrulKra opened a new pull request #56: Feature/LOG4NET-644
URL: https://github.com/apache/logging-log4net/pull/56
I've create a Rest Appender based on Ado.Net Appender.
Unit tests and XML Samples are included the code repository.
Newtonsoft JSON library added as dependency
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376210024
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,75 @@
+~~ Licensed to the Apache Software Foundatio
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376211434
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,75 @@
+~~ Licensed to the Apache Software Foundatio
jvz commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376486473
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,75 @@
+~~ Licensed to the Apache Software Foundation (ASF) un
jvz commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376487230
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,75 @@
+~~ Licensed to the Apache Software Foundation (ASF) un
rgoers commented on a change in pull request #338: use 'final' modifier for
fields where possible
URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r374413039
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMessage.java
#
rgoers commented on a change in pull request #338: use 'final' modifier for
fields where possible
URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r374412481
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java
##
@@ -2
rgoers commented on a change in pull request #338: use 'final' modifier for
fields where possible
URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r374413266
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/message/StringFormattedMessage.java
###
rgoers commented on a change in pull request #338: use 'final' modifier for
fields where possible
URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r374412811
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/message/FormattedMessage.java
##
@
rgoers merged pull request #337: Log4j 2LOG4J2-2770 Fix NPE in JMX
reconfiguration
URL: https://github.com/apache/logging-log4j2/pull/337
This is an automated message from the Apache Git Service.
To respond to the message, p
turbanoff commented on a change in pull request #338: use 'final' modifier for
fields where possible
URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r376738565
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java
##
@@
turbanoff commented on a change in pull request #338: use 'final' modifier for
fields where possible
URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r376738565
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java
##
@@
rgoers merged pull request #336: LOG4J2-2768 Add log(String, ...) overloads to
LogBuilder
URL: https://github.com/apache/logging-log4j2/pull/336
This is an automated message from the Apache Git Service.
To respond to the mes
rgoers commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r376739348
##
File path:
log4j-layout-jackson-json-template/src/main/resources/JsonLayout.json
##
@@ -0,0 +1
remkop commented on issue #338: use 'final' modifier for fields where possible
URL: https://github.com/apache/logging-log4j2/pull/338#issuecomment-583784498
As for why transient fields should not be `final`:
https://stackoverflow.com/questions/2968876/final-transient-fields-and-serializatio
rgoers merged pull request #334: (doc) fix typos
URL: https://github.com/apache/logging-log4j2/pull/334
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376748971
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,75 @@
+~~ Licensed to the Apache Software Foundatio
2501 - 2600 of 7264 matches
Mail list logo
