vy commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372341908
########## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/Throwables.java ########## @@ -40,12 +40,26 @@ private Throwables() { * @return the deepest throwable or the given throwable */ public static Throwable getRootCause(final Throwable throwable) { + Review comment: There was a code typo. Fixed it and added a test to check against causal chains with loops. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services