dependabot[bot] closed pull request #474:
URL: https://github.com/apache/logging-log4j2/pull/474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this se
dependabot[bot] opened a new pull request #483:
URL: https://github.com/apache/logging-log4j2/pull/483
Bumps tomcat-catalina from 8.5.20 to 10.0.5.
[, logging effectively stops. Wi
rm5248 commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-819086870
If we do this for the `GZCompressAction`, a similar thing should also happen
for the `ZipCompressAction`.
@ams-tschoening Any thoughts as to the change? On one hand, I
pm-cfs commented on pull request #61:
URL: https://github.com/apache/logging-log4cxx/pull/61#issuecomment-819107727
Requested changes made; my markdown engine doesn't do a great job with this,
but that's my problem. I understand the semantics request and hopefully this
works better for eve
rmannibucau commented on pull request #473:
URL: https://github.com/apache/logging-log4j2/pull/473#issuecomment-819338565
up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
ams-tschoening commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-819361867
In my opinion, exceptions from the log framework are fine and need to be
handled like in any other cases. One needs to look at the root cause and
fix/deal/live/... wi
vy merged pull request #473:
URL: https://github.com/apache/logging-log4j2/pull/473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
vy commented on pull request #473:
URL: https://github.com/apache/logging-log4j2/pull/473#issuecomment-819366479
Thanks for the contribution @rmannibucau! We had some discussion in the
mailing list regarding the failing tests of this PR, though apparently we
forgot about the ticket itself.
vy commented on pull request #473:
URL: https://github.com/apache/logging-log4j2/pull/473#issuecomment-819368263
One last remark, a JIRA ticket is always handy. It helps us to link changes
with tickets. I will create one for you.
--
This is an automated message from the Apache Git Servic
vy commented on pull request #473:
URL: https://github.com/apache/logging-log4j2/pull/473#issuecomment-819370081
> since Json appender required 3rd party libs which are often undesired
`JsonTemplateLayout` doesn't require any 3rd party libs, FYI.
--
This is an automated message
franz1981 commented on pull request #485:
URL: https://github.com/apache/logging-log4j2/pull/485#issuecomment-819442403
@carterkozak do we have some benchmark to run this PR vs the baseline and
see if it worths?
Sorry to ask directly, but I don't have any decent HW but my laptop at hand
pm-cfs commented on pull request #61:
URL: https://github.com/apache/logging-log4cxx/pull/61#issuecomment-819621433
I'm ok with these; I would note that the tabs are a visibility thing for
non-markdown and/or compatibility for some renderers that use them.
I didn't notice that my editor
rm5248 commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-819902131
>The root cause in this example was a memory look and is pretty interesting,
because in this special case one can't guarantee that any subsequent log
statements or whatever w
rm5248 merged pull request #61:
URL: https://github.com/apache/logging-log4cxx/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
carterkozak commented on pull request #485:
URL: https://github.com/apache/logging-log4j2/pull/485#issuecomment-819924009
Of course, I’d be happy to run the benchmarks! Unfortunately I’m not sure
I’ll be able to get to it this week with other things going on.
--
This is an automated mess
ams-tschoening commented on pull request #22:
URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-820215200
A year has passed without further activity, so time to close for now. In
case of new conclusions, feel free to reopen to keep the history of this
concrete discussion
ams-tschoening closed pull request #22:
URL: https://github.com/apache/logging-log4cxx/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this serv
ams-tschoening commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-820354938
When researching about how error handlers can be set+used etc., I found the
following statement and associated question. In this case the author of the
question expec
rm5248 commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-820586011
I've created a JIRA issue to track this:
https://issues.apache.org/jira/browse/LOGCXX-523
I should be able to take a look this weekend. I've also created another
issu
rm5248 opened a new pull request #63:
URL: https://github.com/apache/logging-log4cxx/pull/63
…l cmake file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries abou
ams-tschoening commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-821788124
@nturner How did you configure using compression, programmatically or using
XML configs? In the latter case, please provide your example here or in linke
[JIRA](https
ams-tschoening commented on a change in pull request #63:
URL: https://github.com/apache/logging-log4cxx/pull/63#discussion_r615231666
##
File path: CMakeLists.txt
##
@@ -3,6 +3,11 @@ include(src/cmake/projectVersionDetails.cmake)
project(log4cxx VERSION ${log4cxx_VER} LANGUAG
swebb2066 commented on a change in pull request #63:
URL: https://github.com/apache/logging-log4cxx/pull/63#discussion_r615246571
##
File path: CMakeLists.txt
##
@@ -3,6 +3,11 @@ include(src/cmake/projectVersionDetails.cmake)
project(log4cxx VERSION ${log4cxx_VER} LANGUAGES CX
rm5248 commented on a change in pull request #63:
URL: https://github.com/apache/logging-log4cxx/pull/63#discussion_r615247114
##
File path: CMakeLists.txt
##
@@ -3,6 +3,11 @@ include(src/cmake/projectVersionDetails.cmake)
project(log4cxx VERSION ${log4cxx_VER} LANGUAGES CXX)
swebb2066 commented on a change in pull request #63:
URL: https://github.com/apache/logging-log4cxx/pull/63#discussion_r615247287
##
File path: CMakeLists.txt
##
@@ -3,6 +3,11 @@ include(src/cmake/projectVersionDetails.cmake)
project(log4cxx VERSION ${log4cxx_VER} LANGUAGES CX
ams-tschoening commented on a change in pull request #63:
URL: https://github.com/apache/logging-log4cxx/pull/63#discussion_r615268201
##
File path: CMakeLists.txt
##
@@ -3,6 +3,11 @@ include(src/cmake/projectVersionDetails.cmake)
project(log4cxx VERSION ${log4cxx_VER} LANGUAG
nturner commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-821884724
Here's the minimal test config I used when validating this change (by hand):
$ cat src/examples/cpp/trace-rolling.xml
http://jakarta.apache.org/log4j/";>
nturner commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-821884895
Here's the patch I made to the the "trivial" example test program to
facilitate testing:
diff --git a/src/examples/cpp/trivial.cpp b/src/examples/cpp/trivial.cpp
nturner commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-821885212
Sorry, that was an older patch. Here's the same commit on my local 0.11.0
branch:
diff --git a/src/examples/cpp/trivial.cpp b/src/examples/cpp/trivial.cpp
index 6
ams-tschoening edited a comment on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-821788124
@nturner How did you configure using compression, programmatically or using
XML configs? In the latter case, please provide your example here or in linked
[JIR
rm5248 merged pull request #63:
URL: https://github.com/apache/logging-log4cxx/pull/63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
rm5248 opened a new pull request #64:
URL: https://github.com/apache/logging-log4cxx/pull/64
If the rollover fails, call the specified error handler for
the given appender. This means that you can now replace appenders
with a new appender.
The entire API at this point is not ve
rm5248 commented on pull request #64:
URL: https://github.com/apache/logging-log4cxx/pull/64#issuecomment-822026497
This superceeds PR #62
See the JIRA issue for a few caveats:
https://issues.apache.org/jira/projects/LOGCXX/issues/LOGCXX-523
--
This is an automated message from t
ams-tschoening commented on a change in pull request #64:
URL: https://github.com/apache/logging-log4cxx/pull/64#discussion_r615864606
##
File path: src/main/cpp/rollingfileappender.cpp
##
@@ -308,7 +308,9 @@ bool RollingFileAppenderSkeleton::rolloverInternal(Pool& p)
ams-tschoening commented on a change in pull request #64:
URL: https://github.com/apache/logging-log4cxx/pull/64#discussion_r615864606
##
File path: src/main/cpp/rollingfileappender.cpp
##
@@ -308,7 +308,9 @@ bool RollingFileAppenderSkeleton::rolloverInternal(Pool& p)
ams-tschoening commented on a change in pull request #64:
URL: https://github.com/apache/logging-log4cxx/pull/64#discussion_r615864606
##
File path: src/main/cpp/rollingfileappender.cpp
##
@@ -308,7 +308,9 @@ bool RollingFileAppenderSkeleton::rolloverInternal(Pool& p)
rm5248 commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-822812878
@nturner Can you take a look at #64 and see if that works for you? I've
tested it on my end.
--
This is an automated message from the Apache Git Service.
To respond to the
carterkozak closed pull request #447:
URL: https://github.com/apache/logging-log4j2/pull/447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
carterkozak commented on pull request #447:
URL: https://github.com/apache/logging-log4j2/pull/447#issuecomment-825784280
Closing this reproducer out, the next release of disruptor will no longer
internally initialize loggers upon creation:
https://github.com/LMAX-Exchange/disruptor/issu
rm5248 merged pull request #64:
URL: https://github.com/apache/logging-log4cxx/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
vy commented on a change in pull request #469:
URL: https://github.com/apache/logging-log4j2/pull/469#discussion_r622177048
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java
##
@@ -205,6 +205,32 @@ public void reset() {
clear(
jvz commented on a change in pull request #469:
URL: https://github.com/apache/logging-log4j2/pull/469#discussion_r622303663
##
File path: src/changes/changes.xml
##
@@ -31,6 +31,19 @@
- "remove" - Removed
-->
+
+Cleanly shutdown status logger
perry2of5 commented on a change in pull request #469:
URL: https://github.com/apache/logging-log4j2/pull/469#discussion_r622308281
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java
##
@@ -205,6 +205,32 @@ public void reset() {
perry2of5 commented on a change in pull request #469:
URL: https://github.com/apache/logging-log4j2/pull/469#discussion_r622310395
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java
##
@@ -405,6 +405,7 @@ public boolean stop(final long time
perry2of5 commented on a change in pull request #469:
URL: https://github.com/apache/logging-log4j2/pull/469#discussion_r622310736
##
File path:
log4j-kafka/src/test/java/org/apache/logging/log4j/kafka/builder/ConfigurationBuilderTest.java
##
@@ -106,14 +112,27 @@ private void
perry2of5 commented on a change in pull request #469:
URL: https://github.com/apache/logging-log4j2/pull/469#discussion_r622409154
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java
##
@@ -205,6 +205,32 @@ public void reset() {
nturner commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-828682766
@rm5248 sorry for the delayed reply. I just tried my test case with that
change (I see that it's in master now). No, it does not work for me.
Below are the results fr
perry2of5 commented on a change in pull request #469:
URL: https://github.com/apache/logging-log4j2/pull/469#discussion_r622514218
##
File path: src/changes/changes.xml
##
@@ -31,6 +31,19 @@
- "remove" - Removed
-->
+
+Cleanly shutdown status
rm5248 commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-828823924
Ah, it looks like you haven't updated the config. If you use a config file
similar to [this one on
JIRA,](https://issues.apache.org/jira/browse/LOGCXX-523?focusedCommentId=1
carterkozak opened a new pull request #486:
URL: https://github.com/apache/logging-log4j2/pull/486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
carterkozak commented on a change in pull request #486:
URL: https://github.com/apache/logging-log4j2/pull/486#discussion_r623415612
##
File path: src/changes/changes.xml
##
@@ -75,6 +75,9 @@
Slf4j implementations walk the stack at most once rather than twice t
brunom opened a new pull request #74:
URL: https://github.com/apache/logging-log4net/pull/74
As discussed in https://issues.apache.org/jira/browse/LOG4NET-583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
rm5248 opened a new pull request #65:
URL: https://github.com/apache/logging-log4cxx/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
carterkozak commented on pull request #486:
URL: https://github.com/apache/logging-log4j2/pull/486#issuecomment-830460876
committed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
carterkozak closed pull request #486:
URL: https://github.com/apache/logging-log4j2/pull/486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
rm5248 merged pull request #65:
URL: https://github.com/apache/logging-log4cxx/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
rocketraman opened a new pull request #15:
URL: https://github.com/apache/logging-log4j-kotlin/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about t
rocketraman opened a new pull request #16:
URL: https://github.com/apache/logging-log4j-kotlin/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about t
rocketraman opened a new pull request #17:
URL: https://github.com/apache/logging-log4j-kotlin/pull/17
Following the discussion in
https://github.com/apache/logging-log4j-kotlin/pull/14, I believe the best path
forward is to make the Kotlin dependences "provided" dependencies, which should
rocketraman opened a new pull request #18:
URL: https://github.com/apache/logging-log4j-kotlin/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about t
jvz commented on pull request #17:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-830830676
Seems like a good idea. Are there CI updates needed here, though? Some build
failure.
--
This is an automated message from the Apache Git Service.
To respond to the mess
rocketraman commented on pull request #17:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-830834412
> Seems like a good idea. Are there CI updates needed here, though? Some
build failure.
Weird I'm not seeing any errors in the build logs, just the abort at
jvz commented on pull request #17:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-830836699
If you don't have a "re-run" link on the GitHub Check, then try adding an
empty commit or possibly closing then reopening the PR to retrigger CI.
--
This is an automated
rocketraman merged pull request #15:
URL: https://github.com/apache/logging-log4j-kotlin/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this se
rocketraman merged pull request #16:
URL: https://github.com/apache/logging-log4j-kotlin/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this se
rocketraman merged pull request #18:
URL: https://github.com/apache/logging-log4j-kotlin/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this se
jacobrshields opened a new pull request #487:
URL: https://github.com/apache/logging-log4j2/pull/487
# Problem
If `RingBufferLogEventTranslator#translateTo` throws an exception for any
reason, Disruptor's `RingBuffer#translateAndPublish` will still publish the
sequence in a `finally
jacobrshields commented on pull request #487:
URL: https://github.com/apache/logging-log4j2/pull/487#issuecomment-830869512
CI is failing with this error. Any ideas how to fix this?
```
[ERROR] javac: invalid flag: --release
```
--
This is an automated message from the Apache
garydgregory commented on pull request #487:
URL: https://github.com/apache/logging-log4j2/pull/487#issuecomment-830871192
If you want this fix for the 2.x line, master is the wrong branch as it will
become 3.0.0. The 2.x line is from release-2.x. Check your Maven toolchain XML
file, it mi
1201 - 1300 of 7264 matches
Mail list logo
