Re: [PR] Apply Antora styling to main page [logging-site]

2025-05-20 Thread via GitHub
BaseMax commented on PR #9: URL: https://github.com/apache/logging-site/pull/9#issuecomment-2893610106 Can I work to create new website for logging.apache.org by https://antora.org/? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] Expunge stale entries in `InternalLoggerRegistry` [logging-log4j2]

2025-05-20 Thread via GitHub
jhl221123 commented on issue #3430: URL: https://github.com/apache/logging-log4j2/issues/3430#issuecomment-2894124770 @ppkarwasz, Thanks a lot for the kind and detailed guidance! I'll proceed as you suggested. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-05-20 Thread via GitHub
MichaelMorrisEst commented on PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#issuecomment-2894038014 > Have just seen the invitation in an inbox I wasn't expecting. 😮‍💨 > > Pushed my changes. In short, renamed `MonitorUri` to `MonitorResource`, improved tests, and s

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` [logging-log4j2]

2025-05-20 Thread via GitHub
jesmith17 commented on PR #3322: URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2894176676 Just invited you and gave you access. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Apply Antora styling to main page [logging-site]

2025-05-20 Thread via GitHub
ppkarwasz commented on PR #9: URL: https://github.com/apache/logging-site/pull/9#issuecomment-2893195624 @BaseMax, We are probably going to move the website from Jekyll to [Antora](https://antora.org/), which will make this PR obsolete. -- This is an automated message from the Apac

Re: [I] Expunge stale entries in `InternalLoggerRegistry` [logging-log4j2]

2025-05-20 Thread via GitHub
vy commented on issue #3430: URL: https://github.com/apache/logging-log4j2/issues/3430#issuecomment-2893252791 @jhl221123, please go ahead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Apply Antora styling to main page [logging-site]

2025-05-20 Thread via GitHub
ppkarwasz commented on PR #9: URL: https://github.com/apache/logging-site/pull/9#issuecomment-2894025523 > Can I work to create new website for logging.apache.org by https://antora.org/? We’d really appreciate your help—thank you! Most of the content in this repository is alrea

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-05-20 Thread via GitHub
ppkarwasz commented on code in PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#discussion_r2097865691 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java: ## @@ -347,6 +349,17 @@ public void start() { LOGGER.info

Re: [PR] fix toString() method in configuration implementations (apache#3599) [logging-log4j2]

2025-05-20 Thread via GitHub
garydgregory commented on PR #3658: URL: https://github.com/apache/logging-log4j2/pull/3658#issuecomment-2895675271 I am still -1 here: `toString()` is for debugging. If a call site needs a different view on the object, then it can call another method on that object or build that view (like

[PR] Improve the clarity of AsyncAppender documentation [logging-log4cxx]

2025-05-20 Thread via GitHub
swebb2066 opened a new pull request, #500: URL: https://github.com/apache/logging-log4cxx/pull/500 This PR addresses [this stackoverflow question](https://stackoverflow.com/questions/79266696/how-can-i-use-log4cxx-asyncappender-with-rollingfileappender) -- This is an automated message fro

Re: [PR] Apply Antora styling to main page [logging-site]

2025-05-20 Thread via GitHub
ppkarwasz commented on PR #9: URL: https://github.com/apache/logging-site/pull/9#issuecomment-2893323324 > Currently the website built in Jekyll or Antora? Currently the website is deployed from many repositories as you can see in the [INFRA site checker](https://infra-reports.apache.

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` [logging-log4j2]

2025-05-20 Thread via GitHub
vy commented on PR #3322: URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2893334235 @jesmith17, alternatively you can grant me write-access to your fork, and I can take care of any leftover work. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-05-20 Thread via GitHub
vy commented on PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#issuecomment-2893914869 @MichaelMorrisEst, nope, I haven't gotten it yet. Can you merge (not rebase!) the upstream `2.x` to your local `issue-3074`, and push your changes, please? I will base my work on that t

Re: [PR] Apply Antora styling to main page [logging-site]

2025-05-20 Thread via GitHub
BaseMax commented on PR #9: URL: https://github.com/apache/logging-site/pull/9#issuecomment-2893232578 > We are probably going to move the website from Jekyll to [Antora](https://antora.org/), which will make this PR obsolete. Interesting. I would like to work on this task, if poss

Re: [PR] Apply Antora styling to main page [logging-site]

2025-05-20 Thread via GitHub
BaseMax commented on PR #9: URL: https://github.com/apache/logging-site/pull/9#issuecomment-2893235477 I can see "[migrated to Jekyll](https://github.com/apache/logging-site/commit/eff1c9a6f893d023b8d594a034d3c479262d1fbf)" commits from 2 years ago. -- This is an automated message from t

Re: [PR] Apply Antora styling to main page [logging-site]

2025-05-20 Thread via GitHub
BaseMax commented on PR #9: URL: https://github.com/apache/logging-site/pull/9#issuecomment-2893234228 Currently the website built in Jekyll or Antora? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` [logging-log4j2]

2025-05-20 Thread via GitHub
vy commented on PR #3322: URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2893247766 @jesmith17, could you please [sign your commits](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) and force-push, please? -- This is

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-05-20 Thread via GitHub
vy commented on PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#issuecomment-2893955941 Have just seen the invitation in an inbox I wasn't expecting. :face_exhaling: Pushed my changes. In short, renamed `MonitorUri` to `MonitorResource`, improved tests, and some othe

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-05-20 Thread via GitHub
MichaelMorrisEst commented on PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#issuecomment-2893384920 > @MichaelMorrisEst, would you mind giving me write access to your fork, please? I want to push some changes and get this merged for `2.25.0`, which we will be releasing i

Re: [I] Expunge stale entries in `InternalLoggerRegistry` [logging-log4j2]

2025-05-20 Thread via GitHub
ppkarwasz commented on issue #3430: URL: https://github.com/apache/logging-log4j2/issues/3430#issuecomment-2893396418 @jhl221123, Thanks for your interest in continuing this work! While we can’t grant you direct access to @Suvrat1629’s PR, you can absolutely pick up where he l

[PR] Improve development-related documentation [logging-log4j2]

2025-05-20 Thread via GitHub
vy opened a new pull request, #3677: URL: https://github.com/apache/logging-log4j2/pull/3677 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-05-20 Thread via GitHub
MichaelMorrisEst commented on PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#issuecomment-2893832661 Ive added you there now @vy , you should get notification -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-05-20 Thread via GitHub
vy commented on PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#issuecomment-2893705288 > I think I gave you access a few months ago for another PR, can you check and let me know if there is a problem @MichaelMorrisEst, see the following failure. Am I missing somethi

Re: [I] Unwanted logging by StatusLogger [logging-log4j2]

2025-05-20 Thread via GitHub
garydgregory commented on issue #3100: URL: https://github.com/apache/logging-log4j2/issues/3100#issuecomment-2895669528 This is a classic and recurring issue in logging. The POVs to consider are: - The library developers (in this case, us, Log4j) - The application developers usin

Re: [I] Unwanted logging by StatusLogger [logging-log4j2]

2025-05-20 Thread via GitHub
ppkarwasz commented on issue #3100: URL: https://github.com/apache/logging-log4j2/issues/3100#issuecomment-2895841889 @garydgregory, It seems we're very much aligned on the purpose of log levels: - **`ERROR` and `WARN`** should signal actionable issues. It's well known that no

Re: [I] Unwanted logging by StatusLogger [logging-log4j2]

2025-05-20 Thread via GitHub
garydgregory commented on issue #3100: URL: https://github.com/apache/logging-log4j2/issues/3100#issuecomment-2895897690 > Unlike file-based appenders, network connectivity should never be assumed to “just work,” and an explicit log line can be very helpful. Hm, but what about files

Re: [I] Unwanted logging by StatusLogger [logging-log4j2]

2025-05-20 Thread via GitHub
garydgregory commented on issue #3100: URL: https://github.com/apache/logging-log4j2/issues/3100#issuecomment-2895902852 None of this should hold up 2.25.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL