avrilfanomar commented on PR #312:
URL:
https://github.com/apache/logging-log4j-samples/pull/312#issuecomment-2800051345
Maybe SSH keys are not supported since the one I've used is already there on
my account.
--
This is an automated message from the Apache Git Service.
To respond to the
vy commented on PR #3603:
URL: https://github.com/apache/logging-log4j2/pull/3603#issuecomment-2800065811
@ppkarwasz, please do not proceed with this change – I am DM'ing you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
vy commented on issue #3546:
URL:
https://github.com/apache/logging-log4j2/issues/3546#issuecomment-2800067127
> I am wondering if the `updateLoggers` PropertyChangeEvent should use a
different property-name.
@JWT007, can you elaborate on this suggestion, please?
Would you als
ppkarwasz commented on PR #3603:
URL: https://github.com/apache/logging-log4j2/pull/3603#issuecomment-2800085765
> @ppkarwasz, please do not proceed with this change – I am DM'ing you.
This is the magic of RTC: I can not merge any PR unless you or another
committer agrees.
--
This
github-actions[bot] merged PR #317:
URL: https://github.com/apache/logging-log4j-samples/pull/317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifi
ppkarwasz closed pull request #71: Bump
apache/logging-parent/.github/workflows/build-reusable.yaml@rel/11.3.0 from
11.3.0 to 12.0.0
URL: https://github.com/apache/logging-log4j-scala/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
ppkarwasz closed pull request #74: Bump
apache/logging-parent/.github/workflows/codeql-analysis-reusable.yaml@rel/11.3.0
from 11.3.0 to 12.0.0
URL: https://github.com/apache/logging-log4j-scala/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
ppkarwasz commented on issue #373:
URL: https://github.com/apache/logging-parent/issues/373#issuecomment-2800100901
> > We can activate the profile only in the builds that actually need it
(e.g. `logging-log4j-samples`)
>
> I'd be in favor of this approach. Expose it wherever it is ne
ppkarwasz commented on PR #311:
URL:
https://github.com/apache/logging-log4j-samples/pull/311#issuecomment-2800106471
> Along with this change, can you configure dependabot to group the updates,
please? So that we just need to approve one dependabot PR per week.
Done in
https://gith
ppkarwasz merged PR #3580:
URL: https://github.com/apache/logging-log4j2/pull/3580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
vy commented on code in PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#discussion_r2041192370
##
log4j-tools-parent/pom.xml:
##
@@ -46,6 +46,11 @@
5.12.0
2.1.2
2.10.0
+2.0.0
+
1.1.2
+4.8.6
+1.0.0
+7.0.0
Review Comment:
github-actions[bot] commented on PR #3501:
URL: https://github.com/apache/logging-log4j2/pull/3501#issuecomment-2800111322
Job
Requested goals
Build Tool Version
Build Outcome
Build Scan®
build-
vy commented on issue #373:
URL: https://github.com/apache/logging-parent/issues/373#issuecomment-2800098008
Ugh! This hurts. Thanks for spotting this @ppkarwasz!
> the pom adds the Apache snapshot repository
(https://repository.apache.org/snapshots) This only happens if the
`apache.
ppkarwasz merged PR #312:
URL: https://github.com/apache/logging-log4j-samples/pull/312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
ppkarwasz commented on code in PR #3258:
URL: https://github.com/apache/logging-log4j2/pull/3258#discussion_r2041203562
##
src/changelog/.3.x.x/3151_plugin_processor_bnd_annotations.xml:
##
Review Comment:
In the current status, it will have external effects.
Users w
ppkarwasz commented on PR #3580:
URL: https://github.com/apache/logging-log4j2/pull/3580#issuecomment-2800108229
@vy,
This didn't work as expected. I am getting an error:
> Some errors were encountered when parsing the `FUNDING.yml` file:
>
> - You can specify up to 1 orga
vy commented on code in PR #3501:
URL: https://github.com/apache/logging-log4j2/pull/3501#discussion_r2041190519
##
log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java:
##
@@ -767,6 +785,18 @@ protected void doConfigure() {
setParent
vy commented on code in PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#discussion_r2041191985
##
pom.xml:
##
@@ -31,7 +31,7 @@
org.apache.logging
logging-parent
-11.0.0
+12.1.0-SNAPSHOT
Review Comment:
@ppkarwasz, thanks for your
vy commented on issue #3593:
URL:
https://github.com/apache/logging-log4j2/issues/3593#issuecomment-2800096836
@roytmana, I am reluctant to push a fix for an OpenJDK bug that will
probably be addressed by either the OpenJDK or Azure in the future. Would it be
possible for you to repeat the
ppkarwasz merged PR #3584:
URL: https://github.com/apache/logging-log4j2/pull/3584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
ppkarwasz merged PR #304:
URL: https://github.com/apache/logging-log4j-samples/pull/304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
ppkarwasz closed pull request #73: Bump
apache/logging-parent/.github/workflows/merge-dependabot-reusable.yaml@rel/11.3.0
from 11.3.0 to 12.0.0
URL: https://github.com/apache/logging-log4j-scala/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, p
ppkarwasz closed pull request #72: Bump
apache/logging-parent/.github/workflows/deploy-site-reusable.yaml@rel/11.3.0
from 11.3.0 to 12.0.0
URL: https://github.com/apache/logging-log4j-scala/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ppkarwasz merged PR #318:
URL: https://github.com/apache/logging-log4j-samples/pull/318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
vy commented on code in PR #3258:
URL: https://github.com/apache/logging-log4j2/pull/3258#discussion_r2041195036
##
src/changelog/.3.x.x/3151_plugin_processor_bnd_annotations.xml:
##
Review Comment:
Since this is an internal change and not intended for public consumption, I
github-actions[bot] commented on PR #3568:
URL: https://github.com/apache/logging-log4j2/pull/3568#issuecomment-2800091324
Job
Requested goals
Build Tool Version
Build Outcome
Build Scan®
build-
ppkarwasz commented on PR #312:
URL:
https://github.com/apache/logging-log4j-samples/pull/312#issuecomment-2800093867
@avrilfanomar,
SSH signatures are probably not supported. I resigned the commits with my
GPG key.
Thanks for your contribution!
--
This is an automated message
ppkarwasz commented on code in PR #3228:
URL: https://github.com/apache/logging-log4j2/pull/3228#discussion_r2041080025
##
log4j-api/pom.xml:
##
@@ -63,16 +63,19 @@
- org.jspecify
- jspecify
+ org.osgi
+ org.osgi.core
provided
+
ppkarwasz commented on PR #3228:
URL: https://github.com/apache/logging-log4j2/pull/3228#issuecomment-2799870211
@rgoers,
I moved `jspecify` into the `provided` scope for `log4j-api`. Can you review
this PR again?
**Note**: The build is expected to fail until #3601 is fixed. I
ppkarwasz commented on PR #3322:
URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2799875695
@jesmith17,
Could you address @vy's suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
30 matches
Mail list logo
